https://github.com/dtcxzyw approved this pull request.
LGTM. Thank you!
https://github.com/llvm/llvm-project/pull/129868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/129937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan deleted
https://github.com/llvm/llvm-project/pull/129937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/129967
>From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 5 Mar 2025 17:27:20 -0800
Subject: [PATCH 1/2] [lldb][Mach-O] Don't read symbol table of specially
mar
@@ -0,0 +1,110 @@
+//===-- MemoryMonitor.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,110 @@
+//===-- MemoryMonitor.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jasonmolenda wrote:
The change to ObjectFileMachO looks a little larger than it really is because i
moved the SectionSP initializations ~100 lines earlier in ParseSymtab than they
were. I'm scanning for this new section the same way we scan for eh_frame.
ObjectFileMachO already had "load lev
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
We have a binary image on Darwin that has no code, only metadata. It has a
large symbol table with many external symbol names that will not be needed in
the debugger. And it is possible to not have thi
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/129967
We have a binary image on Darwin that has no code, only metadata. It has a
large symbol table with many external symbol names that will not be needed in
the debugger. And it is possible to not have this b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
While running lldb-dap over stdin/stdout the `stdout` and `stderr` FD's are
replaced with a pipe that is reading the output to forward to the dap client.
During shutdown we were not properly restoring those F
ashgti wrote:
Checking this with:
```
$ echo 'Content-Length: 51\r\n\r\n{"command":"disconnect","seq": 1,"type":
"request"' > /tmp/partial_message
$ lldb lldb-dap
(lldb) process handle -s true SIGPIPE
(lldb) process launch -i /tmp/partial_message
```
Without the `LLDBDAP_LOG` env set is how I
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/129964
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/129964
While running lldb-dap over stdin/stdout the `stdout` and `stderr` FD's are
replaced with a pipe that is reading the output to forward to the dap client.
During shutdown we were not properly restoring those FDs,
jimingham wrote:
> > You should complete the module -> symbol_context mutatis mutandis. Other
> > than that this seems like the right foundation for adding a user way to
> > control the symbol lookups.
>
> I kept the list of preferred contexts as a `ModuleList` in `IRExecutionUnit`.
> That's
Author: Jonas Devlieghere
Date: 2025-03-05T16:19:36-08:00
New Revision: b5e70d06827189cc701b4b02213549cee60c5160
URL:
https://github.com/llvm/llvm-project/commit/b5e70d06827189cc701b4b02213549cee60c5160
DIFF:
https://github.com/llvm/llvm-project/commit/b5e70d06827189cc701b4b02213549cee60c5160.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/129948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/129948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
That is a SIGPIPE, so something is writing after the output is closed.
I can try that locally and see if I have the same issue.
https://github.com/llvm/llvm-project/pull/129581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
@@ -517,6 +520,16 @@
"cwd": "^\"\\${workspaceRoot}\""
}
},
+ {
+"label": "LLDB: Attach to Process",
+"description": "",
+"body": {
+ "type": "lldb-dap",
+ "request": "atta
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/129921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-03-05T17:36:06-05:00
New Revision: 275eab91edba816b5c98828c53b7f21afd97dbd9
URL:
https://github.com/llvm/llvm-project/commit/275eab91edba816b5c98828c53b7f21afd97dbd9
DIFF:
https://github.com/llvm/llvm-project/commit/275eab91edba816b5c98828c53b7f21afd97dbd9.diff
LOG
@@ -354,14 +354,13 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
- /// Returns true if this SymbolContext should be ignored when setting
- /// breakpoints by line (number or regex). Helpful for languages that
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Consistently use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER when
parsing line and column numbers respectively.
---
Full diff: https://github.com/llvm/llvm-project/pull/129948.diff
2 Fil
@@ -354,14 +354,13 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
- /// Returns true if this SymbolContext should be ignored when setting
- /// breakpoints by line (number or regex). Helpful for languages that
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/129948
Consistently use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER when
parsing line and column numbers respectively.
>From 886bcf62cca14748bf7978062d310842416f95a0 Mon Sep 17 00:00:00 2001
From: Jonas
JDevlieghere wrote:
Haven't had a chance to investigate this yet, but this is failing consistently
for me locally:
```
FAIL: test_termination (TestDAP_launch.TestDAP_launch)
Tests the correct termination of lldb-dap upon a 'disconnect'
---
Michael137 wrote:
> You should complete the module -> symbol_context mutatis mutandis. Other than
> that this seems like the right foundation for adding a user way to control
> the symbol lookups.
I kept the list of preferred contexts as a `ModuleList` in `IRExecutionUnit`.
That's why I kept
@@ -354,14 +354,13 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
- /// Returns true if this SymbolContext should be ignored when setting
- /// breakpoints by line (number or regex). Helpful for languages that
jimingham wrote:
You should complete the module -> symbol_context mutatis mutandis. Other than
that this seems like the right foundation for adding a user way to control the
symbol lookups.
https://github.com/llvm/llvm-project/pull/129733
___
lldb-c
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/129921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -332,6 +333,14 @@ class EvaluateExpressionOptions {
m_language = SourceLanguage(language_type);
}
+ void SetPreferredSymbolContexts(SymbolContextList modules) {
jimingham wrote:
Not modules
https://github.com/llvm/llvm-project/pull/129733
_
@@ -396,6 +403,11 @@ class IRExecutionUnit : public
std::enable_shared_from_this,
///< defining no functions using that variable, would do this.) If this
///< is true, any allocations need to be committed immediately -- no
///< opportunity for relocation.
+
+ ///< Any
@@ -161,6 +162,12 @@ class IRExecutionUnit : public
std::enable_shared_from_this,
return m_jitted_global_variables;
}
+ void SetPreferredModules(SymbolContextList const &modules) {
jimingham wrote:
Also, these are no longer `modules` you should change
@@ -161,6 +162,12 @@ class IRExecutionUnit : public
std::enable_shared_from_this,
return m_jitted_global_variables;
}
+ void SetPreferredModules(SymbolContextList const &modules) {
jimingham wrote:
This is called `SetPreferredModules` but is actually
https://github.com/jimingham approved this pull request.
I can't see how this would hurt, and there no guarantee anywhere that these
potential hits will be treated strictly independently.
So this LGTM.
https://github.com/llvm/llvm-project/pull/129937
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This allows languages to make decisions based on the whole set of symbol
contexts, giving them strictly more power than when they are only allowed to
see one at a time.
---
Full diff: ht
@@ -207,16 +207,15 @@ bool operator<(const SourceLoc lhs, const SourceLoc rhs) {
void BreakpointResolver::SetSCMatchesByLine(
SearchFilter &filter, SymbolContextList &sc_list, bool skip_prologue,
llvm::StringRef log_ident, uint32_t line, std::optional column) {
- llvm:
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/129937
This allows languages to make decisions based on the whole set of symbol
contexts, giving them strictly more power than when they are only allowed to
see one at a time.
>From 3d6a826964326a408b8e3a9d79c
Author: Adrian Prantl
Date: 2025-03-05T12:58:22-08:00
New Revision: 46236f4c3dbe11e14fe7ac1f4b903637efedfecf
URL:
https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf
DIFF:
https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf.diff
oontvoo wrote:
P.S: Verified that it no longer crashed:
```
vyng@web:~/repo/oontvoo/llvm-project/build$ lldb
./tools/lldb/unittests/Core/LLDBCoreTests
(lldb) target create "./tools/lldb/unittests/Core/LLDBCoreTests"
Current executable set to
'~/repo/oontvoo/llvm-project/build/tools/lldb/unitt
@@ -0,0 +1,31 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t-main.exe
+
+# When we enable symbol preload and dump stats there should be a non-zero
+# time for parsing symbol tables for the main module.
dmpots wrote:
Added the comment, thanks!
https://github.co
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/129593
>From bca07d83152df179f7784d0003262fa54834 Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Wed, 26 Feb 2025 13:55:35 -0800
Subject: [PATCH 1/4] Avoid force loading symbol files in statistics collection
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129921
>From 38f07a83ff621ae4879e4b0cbc8bd361d0b12a93 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 5 Mar 2025 14:45:24 -0500
Subject: [PATCH 1/4] [LLDB]Fix test crash
Unregister the fake manager at end of test
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 1/9] [LLDB][Telemetry]Define TargetInfo for collecting data
about a
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/129921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/129921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2025-03-05T12:02:44-08:00
New Revision: 02f024ca97403e8dff55ca4feebe78009d9ea8f3
URL:
https://github.com/llvm/llvm-project/commit/02f024ca97403e8dff55ca4feebe78009d9ea8f3
DIFF:
https://github.com/llvm/llvm-project/commit/02f024ca97403e8dff55ca4feebe78009d9ea8f3.diff
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129921
>From 38f07a83ff621ae4879e4b0cbc8bd361d0b12a93 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 5 Mar 2025 14:45:24 -0500
Subject: [PATCH 1/3] [LLDB]Fix test crash
Unregister the fake manager at end of test
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129921
>From 38f07a83ff621ae4879e4b0cbc8bd361d0b12a93 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 5 Mar 2025 14:45:24 -0500
Subject: [PATCH 1/2] [LLDB]Fix test crash
Unregister the fake manager at end of test
https://github.com/jeffreytan81 approved this pull request.
Looks good other than one comment.
https://github.com/llvm/llvm-project/pull/129593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/129593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t-main.exe
+
+# When we enable symbol preload and dump stats there should be a non-zero
+# time for parsing symbol tables for the main module.
jeffreytan81 wrote:
Can you add top level comment explicitl
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Unregister the fake manager at end of test
(https://github.com/llvm/llvm-project/issues/129910)
---
Full diff: https://github.com/llvm/llvm-project/pull/129921.diff
1 Files Affected:
- (modified) lldb/unittest
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/129921
Unregister the fake manager at end of test
(https://github.com/llvm/llvm-project/issues/129910)
>From 38f07a83ff621ae4879e4b0cbc8bd361d0b12a93 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 5 Mar 2025 14:4
dmpots wrote:
> That's not to say that things cannot be flakey sometimes: because of how we
> test the debugger, we depend on a lot of things, many of which are out of our
> control and can cause a test to fail. But that's different from a specific
> test being flakey, which is what this decor
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (Da-Viper)
Changes
Completion of #129818
Did not want to put `llvm::StringRef()` as the default value instead it was `""`
---
Patch is 34.46 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull
https://github.com/Da-Viper created
https://github.com/llvm/llvm-project/pull/129919
Completion of #129818
Did not want to put `llvm::StringRef()` as the default value instead it was `""`
>From 14bd9a79299f2637dc400fa2bf718770674c38b0 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Wed, 5 M
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/129916
Sections now support specifying:
- user IDs
- file offset/size
- alignment
- flags
- bool values for fake, encrypted and thread specific sections
>From 150bbe0d8c3e2fb4e2dd324a0d9080a462eda156 Mon Sep 17 00:00:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
Sections now support specifying:
- user IDs
- file offset/size
- alignment
- flags
- bool values for fake, encrypted and thread specific sections
---
Full diff: https://github.com/llvm/llvm-project/pull/12991
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/21] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
dmpots wrote:
> How many others are close to the limit that you've found, just this one?
I was only seeing the one timeout in the runs so I had not thought to measure.
It's a good idea though. Based on the timings it looks like maybe
`TestGdbRemoteFork.py` is worth splitting as well? That one
@@ -5,9 +5,9 @@
lldb-server tests run where the lldb-server exe is
available.
-This class will be broken into smaller test case classes by
-gdb remote packet functional areas. For now it contains
-the initial set of tests implemented.
+The tests are split between the LldbGdbS
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/129601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/129614
>From bb034b3b8c43dae13d7f596c20863b47ce88e4d4 Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Mon, 3 Mar 2025 15:39:20 -0800
Subject: [PATCH 1/2] Split test to avoid timeout
This test is running right up to
@@ -969,12 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
-static uint64_t
-GetLargestRangeSize(const std::vector &ranges) {
- uint64_t max_size = 0;
- for (const auto &core_range : ranges)
-max_size = std::max(max_size, core_range.ran
JDevlieghere wrote:
I personally don't think we should have such a decorator: test shouldn't be
flakey. In my experience, when tests are flakey, they are almost always either
poor tests or actual bugs. I'm worried that a decorator like this makes it easy
to sweep these issues under the rug. Th
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/129753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Da-Viper
Date: 2025-03-05T09:43:29-08:00
New Revision: 5d8b4ea97b174d6d80dbdeaabf5a3664d99e6a19
URL:
https://github.com/llvm/llvm-project/commit/5d8b4ea97b174d6d80dbdeaabf5a3664d99e6a19
DIFF:
https://github.com/llvm/llvm-project/commit/5d8b4ea97b174d6d80dbdeaabf5a3664d99e6a19.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/129733
>From da950b7a55c8ee0a35bcfb7e3565fbc11095ab6e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 4 Mar 2025 16:14:59 +
Subject: [PATCH 1/5] [lldb][Expression] Allow specifying a preferred
ModuleList
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/20] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 1/9] [LLDB][Telemetry]Define TargetInfo for collecting data
about a
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/19] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/129753
>From 2f773debb694f5684664ea47e545027aeb6e33db Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Wed, 5 Mar 2025 10:32:16 +
Subject: [PATCH 1/3] [lldb-dap] Fix: disableASLR launch argument not working.
---
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,6 +29,17 @@
namespace lldb_private {
namespace telemetry {
+struct LLDBConfig : public ::llvm::telemetry::Config {
+ // If true, we will collect full details about a debug command (eg., args and
+ // original command). Note: This may contain PII, hence can only be ena
oontvoo wrote:
> > Defind telemetry...
>
> Define?
done
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -66,6 +80,50 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ // If the command is/can be associated with a target
@@ -66,6 +80,50 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ // If the command is/can be associated with a target
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/129753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks for bearing with me.
https://github.com/llvm/llvm-project/pull/129753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -32,12 +32,12 @@ MakeArgv(const llvm::ArrayRef &strs) {
}
static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
- llvm::StringRef key, lldb::LaunchFlags mask,
- bool default_value) {
- if (Get
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/129823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-03-05T09:06:14-08:00
New Revision: b53e75711c284d08b7377385c6f2a037842c0d5b
URL:
https://github.com/llvm/llvm-project/commit/b53e75711c284d08b7377385c6f2a037842c0d5b
DIFF:
https://github.com/llvm/llvm-project/commit/b53e75711c284d08b7377385c6f2a037842c0d5b.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/129823
>From 313d37f56eae39b1430417683c704880bcedc531 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 4 Mar 2025 20:41:17 -0800
Subject: [PATCH] [lldb-dap] Replace Get{Signed,Unsigned} with GetInteger
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/129753
>From 2f773debb694f5684664ea47e545027aeb6e33db Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Wed, 5 Mar 2025 10:32:16 +
Subject: [PATCH 1/2] [lldb-dap] Fix: disableASLR launch argument not working.
---
Author: Jonas Devlieghere
Date: 2025-03-05T08:49:49-08:00
New Revision: 6c4febee2992d206e95e2ed2294fe216739af1cb
URL:
https://github.com/llvm/llvm-project/commit/6c4febee2992d206e95e2ed2294fe216739af1cb
DIFF:
https://github.com/llvm/llvm-project/commit/6c4febee2992d206e95e2ed2294fe216739af1cb.d
DavidSpickett wrote:
> Defind telemetry...
Define?
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
A few more nits.
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
> Okay!
>
> Thank you for reverting! I will run more test and find a solution.
It seems that `ScriptInterpreterPython::SharedLibraryDirectoryHelper` can't
correctly determine path to liblldb.dll after this change.
`SharedLibraryDirectoryHelper("build-lldb\Lib\site-packages\ll
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/129332
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -66,6 +80,50 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ // If the command is/can be associated with a target
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/129354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,6 +29,17 @@
namespace lldb_private {
namespace telemetry {
+struct LLDBConfig : public ::llvm::telemetry::Config {
+ // If true, we will collect full details about a debug command (eg., args and
+ // original command). Note: This may contain PII, hence can only be ena
@@ -66,6 +80,50 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ // If the command is/can be associated with a target
@@ -31,7 +31,18 @@ MakeArgv(const llvm::ArrayRef &strs) {
return argv;
}
-// Both attach and launch take a either a sourcePath or sourceMap
+static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
+ llvm::StringRef key, lldb:
@@ -173,12 +184,13 @@ RequestHandler::LaunchProcess(const llvm::json::Object
&request) const {
auto flags = launch_info.GetLaunchFlags();
- if (GetBoolean(arguments, "disableASLR").value_or(true))
-flags |= lldb::eLaunchFlagDisableASLR;
- if (GetBoolean(arguments, "d
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/129733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 118 matches
Mail list logo
