================
@@ -66,6 +80,50 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ // If the command is/can be associated with a target entry this field
contains
+ // that target's UUID. <EMPTY> otherwise.
+ UUID target_uuid;
+ // A unique ID for a command so the manager can match the start entry with
+ // its end entry. These values only need to be unique within the same
session.
+ // Necessary because we'd send off an entry right before a command's
execution
+ // and another right after. This is to avoid losing telemetry if the command
+ // does not execute successfully.
+ uint64_t command_id;
+ // Eg., "breakpoint set"
+ std::string command_name;
+ // !!NOTE!! These two fields are not collected by default due to PII risks.
----------------
JDevlieghere wrote:
Drop the `!!NOTE!!`, or use `Note that`.
```suggestion
// These two fields are not collected by default due to PII risks.
```
When comments apply to multiple lines, you can use Doxygen groups:
```
/// Comment spanning multiple things
/// @{
thing one;
thing two;
/// @}
```
https://github.com/llvm/llvm-project/pull/129354
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
