cmtice wrote:
I think I have addressed all the current review comments. Please take another
look now. Thanks!
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/94034
>From 10dd5f4273efe6288ace38227561d2122d1ff05e Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 02:39:21 +0900
Subject: [PATCH] fix(lldb/**.py): fix invalid escape sequences
---
lldb/exampl
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From fd85cd7225ff5ddb861dbda8f0ace84e53b021bf Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/129110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/22] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
Author: Jonas Devlieghere
Date: 2025-02-27T19:56:56-06:00
New Revision: fb191efa70ba92c44c57dc53c1b9a2d1915dcabe
URL:
https://github.com/llvm/llvm-project/commit/fb191efa70ba92c44c57dc53c1b9a2d1915dcabe
DIFF:
https://github.com/llvm/llvm-project/commit/fb191efa70ba92c44c57dc53c1b9a2d1915dcabe.d
https://github.com/clayborg commented:
IIUC this is just moving funtionality around right now so that we can
eventually plug-in a different `IndexSet` where T is an improved version
that doesn't use `ConstString` objects?
https://github.com/llvm/llvm-project/pull/123732
___
JDevlieghere wrote:
> Some thoughts:
>
> * The server could shut itself down if the process gets a low memory warning
> and there are no active clients.
There is `SBDebugger::MemoryPressureDetected` that removes modules with a zero
refcount. That might be a good API to wire up first.
> * Th
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/110822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() {
m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr);
}
}
-
+ if (m_error.Fail() && variable->IsThreadLocal()) {
+ExecutionContext exe_ctx(GetExecutionContextRef());
+Thread *thread
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() {
m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr);
}
}
-
+ if (m_error.Fail() && variable->IsThreadLocal()) {
+ExecutionContext exe_ctx(GetExecutionContextRef());
+Thread *thread
@@ -438,6 +438,19 @@ Status Variable::GetValuesForVariableExpressionPath(
return error;
}
+bool Variable::IsThreadLocal() const {
+ ModuleSP module_sp(m_owner_scope->CalculateSymbolContextModule());
+ // Give the symbol vendor a chance to add to the unified section list.
+
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() {
m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr);
}
}
-
+ if (m_error.Fail() && variable->IsThreadLocal()) {
+ExecutionContext exe_ctx(GetExecutionContextRef());
+Thread *thread
@@ -73,19 +73,20 @@
#undef DECLARE_REGISTER_INFOS_ARM64_STRUCT
static lldb_private::RegisterInfo g_register_infos_pauth[] = {
-DEFINE_EXTENSION_REG(data_mask), DEFINE_EXTENSION_REG(code_mask)};
+DEFINE_EXTENSION_REG(data_mask, KIND_ALL_INVALID),
+DEFINE_EXTENSION_R
@@ -790,9 +793,12 @@ DynamicLoaderPOSIXDYLD::GetThreadLocalData(const
lldb::ModuleSP module_sp,
LLDB_LOGF(log, "GetThreadLocalData error: fail to read modid");
return LLDB_INVALID_ADDRESS;
}
-
+ const llvm::Triple &triple_ref =
+ m_process->GetTarget().GetArchi
@@ -438,6 +438,19 @@ Status Variable::GetValuesForVariableExpressionPath(
return error;
}
+bool Variable::IsThreadLocal() const {
+ ModuleSP module_sp(m_owner_scope->CalculateSymbolContextModule());
+ // Give the symbol vendor a chance to add to the unified section list.
+
https://github.com/clayborg requested changes to this pull request.
How is the DWARF encoded differently for a thread local variable for arm64?
Normally there is just one location attribute that specifies a TLS address. Why
do we need to lookup symbols by name if the DWARF has TLS info in it al
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1199bbb396fb9554401ad5ae1816b6648bab76a9
d653c41231ab7dd2ee649ea6ebef3d12aed4d4b9 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
When we don't specify the size of an ELF image when loading from memory, our
data for the ELF file might end up being truncated to only include the ELF
header and the program headers. The ObjectFileELF class
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/129166
When we don't specify the size of an ELF image when loading from memory, our
data for the ELF file might end up being truncated to only include the ELF
header and the program headers. The ObjectFileELF class w
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/128276
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -88,6 +88,12 @@
"additionalProperties": {
"type": "string"
}
+},
+"lldb-dap.serverMode": {
+ "scope": "resource",
+ "type": "boolean",
+ "description": "Run lldb-dap in server mode. When enabled, lldb
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128957
>From e95459a73ad5a1448841ed6c2422f66b23f6b486 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 26 Feb 2025 14:56:10 -0800
Subject: [PATCH 1/3] [lldb-dap] Adding server mode support to lldb-dap VSCode
ext
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/129155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds a new `Protocol.{h,cpp}` for defining structured types that represent
Debug Adapter Protocol messages.
This adds static types to define well structure messages for the protocol. This
iteration incl
ashgti wrote:
Replacing this with https://github.com/llvm/llvm-project/pull/129155 for a
smaller set of files to review.
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/129155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/129155
This adds a new `Protocol.{h,cpp}` for defining structured types that represent
Debug Adapter Protocol messages.
This adds static types to define well structure messages for the protocol. This
iteration include
https://github.com/ashgti converted_to_draft
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/129155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
For reference, this is part of a larger refactor to support 'cancel' requests.
I have a working prototype in
https://github.com/ashgti/llvm-project/tree/lldb-dap-cancel that I am splitting
up into smaller individual patches.
https://github.com/llvm/llvm-project/pull/129155
_
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: wieDasDing (dingxiangfei2009)
Changes
Fix #92603
This replaces #113066. I finally came back to this issue and it seems
that this approach is still very promising.
As requested, I have added a short explanation as to why CPython module sho
@@ -88,6 +88,12 @@
"additionalProperties": {
"type": "string"
}
+},
+"lldb-dap.serverMode": {
+ "scope": "resource",
+ "type": "boolean",
+ "description": "Run lldb-dap in server mode. When enabled, lldb
https://github.com/dingxiangfei2009 created
https://github.com/llvm/llvm-project/pull/129135
Fix #92603
This replaces #113066. I finally came back to this issue and it seems that this
approach is still very promising.
As requested, I have added a short explanation as to why CPython module sho
https://github.com/JDevlieghere commented:
Random question: what happens when the server crashes? Do you get a popup in
the UI telling you?
https://github.com/llvm/llvm-project/pull/128957
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128957
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
JDevlieghere wrote:
Should we store this as a `UU
ashgti wrote:
> This PR feels like it combines 3 different changes:
>
> * Introducing the Transport class
> * Using LLDB's logging
> * Introducing the protocol class
>
> Would it be a lot of work to split this up into 3 separate PRs? If not I'm
> happy to review everything together here. The T
@@ -0,0 +1,48 @@
+//===-- Transport.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
JDevlieghere wrote:
Adding Adrian and Walter as reviewers and tagging @Da-Viper as they might want
to take a look. To me this looks good.
https://github.com/llvm/llvm-project/pull/128943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
This PR feels like it combines 3 different changes:
- Introducing the Transport class
- Using LLDB's logging
- Introducing the protocol class
Would it be a lot of work to split this up into 3 separate PRs? If not I'm
happy to review everything to
@@ -0,0 +1,192 @@
+//===-- Protocol.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- Protocol.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,110 @@
+//===-- Transport.cpp ---*- C++
-*-===//
JDevlieghere wrote:
The `*- C++ -*` was only meant to go into headers (to tell emacs they were C++
rather than C headers) but there was an RFC to drop it altoget
JDevlieghere wrote:
Thanks for the additional perspective. I was on the fence when I mentioned it
and it sounds like sticking with the TS approach avoids some complications,
plus it matches what other VSCode plugins are doing.
https://github.com/llvm/llvm-project/pull/128943
_
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/129038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -102,12 +102,7 @@ static Status PushToLinuxGuardedControlStack(addr_t
return_addr,
size_t wrote = thread.GetProcess()->WriteMemory(gcspr_el0, &return_addr,
sizeof(return_addr), error);
if ((wrote != sizeof(return_addr) |
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/21] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
oontvoo wrote:
What use case do you have in mind?
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/20] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -41,6 +42,7 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
std::optional end_time;
// TBD: could add some memory stats here too?
+ uint64_t debugger_id = LLDB_INVALID_UID;
JDevlieghere wrote:
```suggestion
lldb::user_id_t
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
https://github.com/JDevlieghere commented:
A few more small comments but the overall approach LGTM.
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/18] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/129110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/19] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/4] Add a finalize method to the sbprogress, with an
associated
oontvoo wrote:
@labath @JDevlieghere I think I've resolved all the comments + added test.
Please have a look when you can. Thanks!
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
+
+%feature("docs
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
https://github.com/slackito approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/129110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -761,12 +764,27 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+ lldb_private::telemetry::ScopeTelemetryCollector helper;
DebuggerSP debugger_sp(new De
Author: Jacob Lalonde
Date: 2025-02-27T11:08:20-08:00
New Revision: 10a9dcab0a5904ce6c12efb3555a2e31017bce92
URL:
https://github.com/llvm/llvm-project/commit/10a9dcab0a5904ce6c12efb3555a2e31017bce92
DIFF:
https://github.com/llvm/llvm-project/commit/10a9dcab0a5904ce6c12efb3555a2e31017bce92.diff
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/129110
>From 1e5b4a5b5ae47f1cd44611d2d8933c33ad04c709 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 27 Feb 2025 14:11:05 -0600
Subject: [PATCH 1/2] [lldb-dap] Adaptor -> Adapter (NFC)
Both spellings
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/129110
Both spellings are considered correct and acceptable, with adapter being more
common in American English. Given that DAP stands for Debug Adapter Protocol
(with an e) let's go with that as the canonical sp
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/17] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/129110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
There are a few other places where `Adaptor` is used:
```
$ rg -i adaptor lldb
lldb/packages/Python/lldbsuite/test/test_categories.py
34:"lldb-dap": "Tests for the Debug Adaptor Protocol with lldb-dap",
lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
79:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Both spellings are considered correct and acceptable, with adapter being more
common in American English. Given that DAP stands for Debug Adapter Protocol
(with an e) let's go with that as the canon
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/16] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/15] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
https://github.com/clayborg commented:
Will this patch cause us to be able to have a `DW_TAG_subprogram` whose range
is `[0x1000-0x2000)` and then have a `DW_AT_lexical_block` whose range doesn't
exist within the `DW_TAG_subprogram` range and we will add it to the
`DW_TAG_subprogram`? I worry
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 01/14] [LLDB][Telemetry]Define DebuggerTelemetryInfo and
related met
@@ -761,12 +764,27 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+ lldb_private::telemetry::ScopeTelemetryCollector helper;
DebuggerSP debugger_sp(new De
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/128972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This removes the previous 'OutputStream' and 'InputStream' objects and the new
'Transport' class takes on the responsibility of serializing and encoding
messages.
The new Protocol.h file has a dedicated name
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-27T12:42:54-06:00
New Revision: 8f8529c137b1f659595e1064f5c8806eeb628b36
URL:
https://github.com/llvm/llvm-project/commit/8f8529c137b1f659595e1064f5c8806eeb628b36
DIFF:
https://github.com/llvm/llvm-project/commit/8f8529c137b1f659595e1064f5c8806eeb628b36.d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Mikhail Zakharov (real-mikhail)
Changes
This change prevents invalidating and updating values in
`ValueObject::UpdateValueIfNeeded` when only "internal" debugger memory is
updated. Writing to "internal" debugger memory happens when, for in
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/real-mikhail created
https://github.com/llvm/llvm-project/pull/129092
This change prevents invalidating and updating values in
`ValueObject::UpdateValueIfNeeded` when only "internal" debugger memory is
updated. Writing to "internal" debugger memory happens when, for instance
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/4] Fix bad optional access in sbprogress
---
lldb/source/API/
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
@@ -73,9 +104,46 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
+
static std::unique_ptr g_instance;
};
+/// Helper RAII clas
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From d34c8043bfe0d7bda5a4ef9c2c23915071d06bd5 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
1 - 100 of 161 matches
Mail list logo
