ashgti wrote: > This PR feels like it combines 3 different changes: > > * Introducing the Transport class > * Using LLDB's logging > * Introducing the protocol class > > Would it be a lot of work to split this up into 3 separate PRs? If not I'm > happy to review everything together here. The Transport changes LGTM and the > logging changes look pretty straightforward too, though I'm still worried > about the increasing amount of `lldb_private` stuff we're starting to rely > on. The largest code change is the introduction of the Protocol class which > I'd like to look at in more detail.
Sure, let me split this up. I can start with the protocol classes > logging > transport. https://github.com/llvm/llvm-project/pull/128972 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
