[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-27 Thread via lldb-commits
jimingham wrote: > > I'd rather keep the flexibility, if you don't mind doing the work to add > > that. For now, it seems okay for the current libc++/libstdc++ ones to > > declare what they support (which is 1 pointer depth). If someone has a > > reason to come back and extend these ones in th

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Jonas Devlieghere via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/124648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Walter Erquinigo via lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { -std::string message = m_title; -if (!m_details.empty()) { -

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-01-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/124648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] Sbdebugger progress no title prefix (PR #124648)

2025-01-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In my last DAP patch (#123837), we piped the DAP update message into the update event. However, we had the title embedded into the update message. This makes sense for progress Start, but makes the update me

[Lldb-commits] [lldb] [LLDB-DAP] Sbdebugger progress no title prefix (PR #124648)

2025-01-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/124648 In my last DAP patch (#123837), we piped the DAP update message into the update event. However, we had the title embedded into the update message. This makes sense for progress Start, but makes the update messa

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/8] [lldb] Analyze enum promotion type during parsing --- clang/in

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-27 Thread via lldb-commits
Sirraide wrote: Aaron and I just talked about this a bit, and I agree it would be cleaner to just make a single function that can be used everywhere and whose behaviour is customised with an enum. I’ll experiment with that approach and see how it goes. Also, my plan was to try and remove `isPo

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-27 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: Thank you for working on cleaning up these APIs! They are definitely a source of confusion in practice, so paying down this tech debt is great! > The names for the first two are rather verbose; I’m open to suggestions as to > better names for these functions since that was

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/7] [lldb] Analyze enum promotion type during parsing --- clang/in

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl { void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED, TemplateSpecializationKind TSK); +public: kuilpd wrote: I left this in so that that I could simply do

[Lldb-commits] [lldb] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-01-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Yeah this should work for core files. > > ``` > (lldb) target create > "lldb/test/API/functionalities/postmortem/elf-core/linux-riscv64.gpr_only.out" > --core > "ldb/test/API/functionalities/postmortem/elf-core/linux-riscv64.gpr_only.core" > > Core file > 'lldb/test/AP

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread Brad Smith via lldb-commits
@@ -29,6 +29,10 @@ #include #include +#ifdef __ANDROID__ +#include brad0 wrote: > what's the build failure you're seeing? this _should_ be included "for free" > by all of the #includes above (via , which they should all drag > in). > > of course, if you

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-27 Thread via lldb-commits
jimingham wrote: > On Jan 27, 2025, at 5:30 AM, Pavel Labath ***@***.***> wrote: > > > If I was holding a vector as a vector**, then I would would to see its > summary/size as well. And maybe even the children too. But the thing I > questioning is how often does one hold a C++ container as a

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-27 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/122783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 873426b - [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (#122783)

2025-01-27 Thread via lldb-commits
Author: John Harrison Date: 2025-01-27T08:58:50-08:00 New Revision: 873426bea3dd67d80dd10650e64e91c69796614f URL: https://github.com/llvm/llvm-project/commit/873426bea3dd67d80dd10650e64e91c69796614f DIFF: https://github.com/llvm/llvm-project/commit/873426bea3dd67d80dd10650e64e91c69796614f.diff

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-27 Thread John Harrison via lldb-commits
ashgti wrote: > Were you able to reproduce the windows failure (and confirm the problem was > indeed in the pipe code), or is this an attempt at speculation? I was able to reproduce the issue on an x86_64 cloud host and I also verified after applying 3ea2b546a8d17014d3ecf05356ecfaadf26ed846 th

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
https://github.com/OCHyams approved this pull request. Thanks, still LGTM https://github.com/llvm/llvm-project/pull/124287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Looks much better Left some more clarification comments https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl { void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED, TemplateSpecializationKind TSK); +public: Michael137 wrote: Don't need this change anymore https://gi

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse closed https://github.com/llvm/llvm-project/pull/124287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 81d18ad - [NFC][DebugInfo] Make some block-start-position methods return iterators (#124287)

2025-01-27 Thread via lldb-commits
Author: Jeremy Morse Date: 2025-01-27T16:27:54Z New Revision: 81d18ad86419fc612c7071e888d11aa923eaeb8a URL: https://github.com/llvm/llvm-project/commit/81d18ad86419fc612c7071e888d11aa923eaeb8a DIFF: https://github.com/llvm/llvm-project/commit/81d18ad86419fc612c7071e888d11aa923eaeb8a.diff LOG:

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse updated https://github.com/llvm/llvm-project/pull/124287 >From 3d2aa2734d6cb49c43565e3ac8584ba8130fe302 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Thu, 23 Jan 2025 12:24:14 + Subject: [PATCH 1/3] [NFC][DebugInfo] Make some block-start-position methods retur

[Lldb-commits] [lldb] 5f5cdf4 - [lldb][TypeSystemClang] CreateParameterDeclarations: don't specify SmallVector size

2025-01-27 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-01-27T16:15:30Z New Revision: 5f5cdf40382f06a8c417c42ec591f97aa76eeb67 URL: https://github.com/llvm/llvm-project/commit/5f5cdf40382f06a8c417c42ec591f97aa76eeb67 DIFF: https://github.com/llvm/llvm-project/commit/5f5cdf40382f06a8c417c42ec591f97aa76eeb67.diff LOG:

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
@@ -448,6 +455,9 @@ BasicBlock::const_iterator BasicBlock::getFirstNonPHIOrDbgOrAlloca() const { ++InsertPt; } } + + // Signal that this comes after any debug records. + InsertPt.setHeadBit(false); jmorse wrote: The other two call-sites always g

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse commented: Adjusted two call sites, see comments on the others. I've also added an extra unwrap to CoroSplit.cpp due to it not compiling -- this is going to be reworked in #124288 anyway. https://github.com/llvm/llvm-project/pull/124287 ___

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/124287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
@@ -1656,7 +1656,8 @@ static Value *emitSetAndGetSwiftErrorValueAround(Instruction *Call, Builder.SetInsertPoint(Call->getNextNode()); } else { auto Invoke = cast(Call); -Builder.SetInsertPoint(Invoke->getNormalDest()->getFirstNonPHIOrDbg()); +BasicBlock::ite

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse updated https://github.com/llvm/llvm-project/pull/124287 >From 3d2aa2734d6cb49c43565e3ac8584ba8130fe302 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Thu, 23 Jan 2025 12:24:14 + Subject: [PATCH 1/2] [NFC][DebugInfo] Make some block-start-position methods retur

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/18062 Here is the relevant piece of th

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: @Michael137 Reused the code I merged in #120965 to get the best promotion type. https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/6] [lldb] Analyze enum promotion type during parsing --- clang/in

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-27 Thread via lldb-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/122938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-27 Thread via lldb-commits
enh-google wrote: > It's quite possible that didn't run as a part of the CTS from the start. If > you say it didn't, then I'll take your word for it. sorry, i didn't mean to imply that these tests didn't immediately go into CTS when they went into bionic: they will have automatically been incl

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread via lldb-commits
@@ -29,6 +29,10 @@ #include #include +#ifdef __ANDROID__ +#include enh-google wrote: > is it possible those includes were necessary 10 years ago? yeah, one reason i'm so confidently asserting that you shouldn't need this now is because i know we had a bi

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -29,6 +29,10 @@ #include #include +#ifdef __ANDROID__ +#include labath wrote: It sounds like it's mainly for "style", but given what you've said, maybe that shouldn't be the style we should use (is it possible those includes were necessary 10 years ag

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/124279 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 081723b - [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (#124279)

2025-01-27 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-27T14:56:47Z New Revision: 081723b9db84e78d7dd240b46af2aeb3b51b00be URL: https://github.com/llvm/llvm-project/commit/081723b9db84e78d7dd240b46af2aeb3b51b00be DIFF: https://github.com/llvm/llvm-project/commit/081723b9db84e78d7dd240b46af2aeb3b51b00be.diff LOG:

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-27 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Android 9 has added the spawn.h header (PR #124452)

2025-01-27 Thread via lldb-commits
@@ -26,10 +26,14 @@ #include #endif +#ifdef __ANDROID__ +#include +#endif + #if defined(__linux__) || defined(__FreeBSD__) || \ defined(__FreeBSD_kernel__) || defined(__APPLE__) || \ defined(__NetBSD__) || defin

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread via lldb-commits
@@ -29,6 +29,10 @@ #include #include +#ifdef __ANDROID__ +#include enh-google wrote: what's the build failure you're seeing? this _should_ be included "for free" by all of the #includes above (via , which they should all drag in). of course, if you're ai

[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

2025-01-27 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
@@ -1656,7 +1656,8 @@ static Value *emitSetAndGetSwiftErrorValueAround(Instruction *Call, Builder.SetInsertPoint(Call->getNextNode()); } else { auto Invoke = cast(Call); -Builder.SetInsertPoint(Invoke->getNormalDest()->getFirstNonPHIOrDbg()); +BasicBlock::ite

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
@@ -408,9 +412,13 @@ BasicBlock::getFirstNonPHIOrDbgOrLifetime(bool SkipPseudoOp) const { if (SkipPseudoOp && isa(I)) continue; -return &I; +BasicBlock::const_iterator It = I.getIterator(); +// Signal that this comes after any debug records. +It.setH

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
@@ -448,6 +455,9 @@ BasicBlock::const_iterator BasicBlock::getFirstNonPHIOrDbgOrAlloca() const { ++InsertPt; } } + + // Signal that this comes after any debug records. + InsertPt.setHeadBit(false); OCHyams wrote: And again https://github.com/ll

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
@@ -383,20 +383,24 @@ BasicBlock::const_iterator BasicBlock::getFirstNonPHIIt() const { return It; } -const Instruction *BasicBlock::getFirstNonPHIOrDbg(bool SkipPseudoOp) const { +BasicBlock::const_iterator +BasicBlock::getFirstNonPHIOrDbg(bool SkipPseudoOp) const { for

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
https://github.com/OCHyams approved this pull request. LGTM + nits https://github.com/llvm/llvm-project/pull/124287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-01-27 Thread Orlando Cazalet-Hyams via lldb-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/124287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for Guarded Control Stack registers (PR #124295)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/124295 >From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 27 Aug 2024 11:45:52 +0100 Subject: [PATCH 1/2] [lldb][AArch64] Add Guarded Control Stack support for

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for Guarded Control Stack registers (PR #124295)

2025-01-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: 1st commit(s) is https://github.com/llvm/llvm-project/pull/124293, last commit is the new code. https://github.com/llvm/llvm-project/pull/124295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-27 Thread Pavel Labath via lldb-commits
labath wrote: If I **was** holding a vector as a `vector**`, then I would would to see its summary/size as well. And maybe even the children too. But the thing I questioning is how often does one hold a C++ container as a double pointer. Is there like some common programming pattern that produ

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack support for Linux core files (PR #124293)

2025-01-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Rebased, PR is just new code now. https://github.com/llvm/llvm-project/pull/124293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack support for Linux core files (PR #124293)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/124293 >From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 27 Aug 2024 11:45:52 +0100 Subject: [PATCH] [lldb][AArch64] Add Guarded Control Stack support for Lin

[Lldb-commits] [lldb] e9e06be - [lldb][AArch64][NFC] Move a comment in GCS tests

2025-01-27 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-01-27T13:27:31Z New Revision: e9e06bea8661ddd474557a0db2cdc8770a55b66f URL: https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f DIFF: https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/123918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b31e974 - [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (#123918)

2025-01-27 Thread via lldb-commits
Author: David Spickett Date: 2025-01-27T13:06:33Z New Revision: b31e9747d0866ff97a1cd4a608b7eade31c0aa0b URL: https://github.com/llvm/llvm-project/commit/b31e9747d0866ff97a1cd4a608b7eade31c0aa0b DIFF: https://github.com/llvm/llvm-project/commit/b31e9747d0866ff97a1cd4a608b7eade31c0aa0b.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/123918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/124279 >From 23c7f4a3e067739a050964b3f1c2140787b0c31f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 24 Jan 2025 13:33:07 + Subject: [PATCH 1/6] [lldb][TypeSystem] Ensure that ParmVarDecls have the corr

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/123918 >From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 20 Aug 2024 16:06:34 +0100 Subject: [PATCH 1/4] [lldb][AArch64] Fix expression evaluation with Guarde

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,218 @@ +//===-- DILLexerTests.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b7286dbef9dc1986860d29e390b092599e1d7db5...3436294db831d78dddacb186c93007ec05c0cfee lldb/

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/123918 >From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 20 Aug 2024 16:06:34 +0100 Subject: [PATCH 1/3] [lldb][AArch64] Fix expression evaluation with Guarde

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/123521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -3157,7 +3158,8 @@ bool DWARFASTParserClang::ParseChildMembers( void DWARFASTParserClang::ParseChildParameters( clang::DeclContext *containing_decl_ctx, const DWARFDIE &parent_die, bool &is_variadic, bool &has_template_params, -std::vector &function_param_types)

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/124279 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify preprocessor conditional (PR #124522)

2025-01-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/124522 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6087c30 - [lldb] Simplify preprocessor conditional (#124522)

2025-01-27 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-27T13:41:18+01:00 New Revision: 6087c3049656bbaef51fffb48e2404e86f7e0d3f URL: https://github.com/llvm/llvm-project/commit/6087c3049656bbaef51fffb48e2404e86f7e0d3f DIFF: https://github.com/llvm/llvm-project/commit/6087c3049656bbaef51fffb48e2404e86f7e0d3f.diff

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,218 @@ +//===-- DILLexerTests.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,189 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,189 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,218 @@ +//===-- DILLexerTests.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,218 @@ +//===-- DILLexerTests.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: There are some simplifications (and one rewrite :P) that I'd like to talk about, but I think we're not far. The main thing that's bothering me is this identifier vs. keyword issue (and for this part, I'd like to loop in @jimingham (at least)). Your implem

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-27 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,158 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-27 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. I agree this is as good as we can get for now with failure handling during expression. https://github.com/llvm/llvm-project/pull/123918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-01-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/124279 >From 23c7f4a3e067739a050964b3f1c2140787b0c31f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 24 Jan 2025 13:33:07 + Subject: [PATCH 1/5] [lldb][TypeSystem] Ensure that ParmVarDecls have the corr

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please update the PR description to reflect what the current code does, or if you want to leave the notes there, move them into an obvious section that you can cut out if/when this gets merged. https://github.com/llvm/llvm-project/pull/108072 __

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
@@ -575,6 +575,10 @@ Changes to LLDB 24 int main() { Likely cause: f->b->d accessed 0x4 ``` +* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows + does not provide API to query the number of supported hardware watchpoints. + Therefore curr

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
@@ -110,8 +110,8 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-27 Thread David Spickett via lldb-commits
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance, } case DWORD(STATUS_BREAKPOINT): case STATUS_WX86_BREAKPOINT: DavidSpickett wrote: W = something related to WOW64 here right, not W for watchpoint? And we get this even on a

  1   2   >