================ @@ -44,12 +44,16 @@ class ProgressEventData : public EventData { uint64_t GetCompleted() const { return m_completed; } uint64_t GetTotal() const { return m_total; } std::string GetMessage() const { - std::string message = m_title; - if (!m_details.empty()) { - message.append(": "); - message.append(m_details); - } - return message; + // Only put the title in the message of the progress create event. + if (m_completed == 0) { + std::string message = m_title; + if (!m_details.empty()) { + message.append(": "); + message.append(m_details); + } + return message; + } else + return !m_details.empty() ? m_details : std::string(); ---------------- clayborg wrote:
We can't change the way that progress events get reported. It will work for DAP nicely, but not for anyone else. We are removing the title from any subsequent notications and that will affect everyone. I would propose adding a new call like `SBDebugger::GetProgressFromEvent(...)` where we can get just the detail and the title as separate strings. Maybe: ``` const char *SBDebugger::GetProgressFromEvent(const lldb::SBEvent &event, uint64_t &progress_id, uint64_t &completed, uint64_t &total, bool &is_debugger_specific, const char **detail); ``` And if detail is NULL, we return the combined string of `title + ": " + detail` and if it is non NULL, the return value is the title only, and the detail gets filled into `detail`. Or we can make accessors for the title and detail like: ``` const char *SBDebugger::GetProgressTitleFromEvent(const lldb::SBEvent &event); const char *SBDebugger::GetProgressDetailFromEvent(const lldb::SBEvent &event); ``` Any thoughts on which approach? https://github.com/llvm/llvm-project/pull/124648 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits