[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-22 Thread Adeel Mujahid via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { am11 wrote: A nit: perhaps call it `isa_to_abi_alias_map`;

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] cd5694e - [StrTable] Switch the option parser to `llvm::StringTable` (#123308)

2025-01-22 Thread via lldb-commits
Author: Chandler Carruth Date: 2025-01-22T23:19:47-08:00 New Revision: cd5694ecea2da1990365f46f9737be1b29d94f0c URL: https://github.com/llvm/llvm-project/commit/cd5694ecea2da1990365f46f9737be1b29d94f0c DIFF: https://github.com/llvm/llvm-project/commit/cd5694ecea2da1990365f46f9737be1b29d94f0c.di

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Chandler Carruth via lldb-commits
https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #124077)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/124077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #124077)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124077.diff 1 Files Affected: - (modified) lldb/source/Target/DynamicRegisterInfo.cpp (+5-4) ``diff diff --git a/lldb/source/Target

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #124077)

2025-01-22 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/124077 None >From ef8125e2022772009b72d4b8b0da5db1b611d2c6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 22 Jan 2025 00:47:57 -0800 Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC) --- lldb/so

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: wanglei (wangleiat) Changes Fixes: https://github.com/llvm/llvm-project/issues/123903 --- Full diff: https://github.com/llvm/llvm-project/pull/124059.diff 1 Files Affected: - (modified) lldb/source/Plugins/ABI/LoongArch/ABISysV_loongarc

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-22 Thread via lldb-commits
https://github.com/wangleiat created https://github.com/llvm/llvm-project/pull/124059 Fixes: https://github.com/llvm/llvm-project/issues/123903 >From f404df6b2ac7b7ab33e3baadd3830154904a Mon Sep 17 00:00:00 2001 From: Ray Wang Date: Thu, 23 Jan 2025 12:13:32 +0800 Subject: [PATCH] =?UTF-8

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd860bcfb57df429c0a1ad2e2d869ff3b795bc4d 1948805894e006d84fbb78299574b3c7618959d8 --e

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r dd860bcfb57df429c0a1ad2e2d869ff3b795bc4d...1948805894e006d84fbb78299574b3c7618959d8 lldb

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes Currently, the type `T`'s formatter will be matched for `T`, `T*`, `T**` and so on. This is inconsistent with the behaviour of `SBValue::GetChildMemberWithName` which can only dereference the pointer type at m

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-22 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/124048 Currently, the type `T`'s formatter will be matched for `T`, `T*`, `T**` and so on. This is inconsistent with the behaviour of `SBValue::GetChildMemberWithName` which can only dereference the pointer type at

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] a939a9f - [LLDB-DAP] Send Progress update message over DAP (#123837)

2025-01-22 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-01-22T15:49:13-08:00 New Revision: a939a9fd53d98f33b94f9121646d5906a2b9f598 URL: https://github.com/llvm/llvm-project/commit/a939a9fd53d98f33b94f9121646d5906a2b9f598 DIFF: https://github.com/llvm/llvm-project/commit/a939a9fd53d98f33b94f9121646d5906a2b9f598.diff

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/123837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-22 Thread Greg Clayton via lldb-commits
clayborg wrote: > The reason this code looks the way it does is that we've had crashes when > trying to read corrupted elf files from memory, where we load the size of the > elf file from the process memory, find that out that it's size is 935872395 > GB, try to allocate a host buffer of that

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-22 Thread via lldb-commits
@@ -0,0 +1,205 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; rnk wrote: Got

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Chandler Carruth via lldb-commits
@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; chandlerc wrote

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Chandler Carruth via lldb-commits
@@ -33,25 +33,26 @@ using namespace llvm::opt; namespace { struct OptNameLess { - const char *StrTable; - ArrayRef PrefixesTable; + const StringTable *StrTable; chandlerc wrote: (same as above) https://github.com/llvm/llvm-project/pull/123308

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-22 Thread via lldb-commits
https://github.com/cmtice edited https://github.com/llvm/llvm-project/pull/123521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-22 Thread via lldb-commits
@@ -0,0 +1,205 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-22 Thread via lldb-commits
@@ -0,0 +1,205 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-22 Thread via lldb-commits
@@ -0,0 +1,156 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo commented: To be honest it's a bit hard to review this because I'm not versed in these low level APIs, let along Windows. Could you make sure that your changes pass mac, linux and windows CI? IIRC you can trigger manually buildbots if you want to run custom

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-22 Thread Walter Erquinigo via lldb-commits
@@ -21,21 +23,22 @@ namespace lldb_dap { /// The file is destroyed when the destructor is invoked. struct FifoFile { FifoFile(llvm::StringRef path); + FifoFile(llvm::StringRef path, FILE *f); + // FifoFile(llvm::StringRef path, FILE *f); + FifoFile(FifoFile &&other); + +

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/121269 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-22 Thread Walter Erquinigo via lldb-commits
@@ -111,8 +111,10 @@ Error RunInTerminalLauncherCommChannel::WaitUntilDebugAdaptorAttaches( return message.takeError(); } -Error RunInTerminalLauncherCommChannel::NotifyPid() { - return m_io.SendJSON(RunInTerminalMessagePid(getpid()).ToJSON()); +Error RunInTerminalLaunch

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/123837 >From bc7bb2471e44ca7441f592611fd293f2b8c90435 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 21 Jan 2025 14:34:49 -0800 Subject: [PATCH 1/5] Have Progress message updates include their messages when s

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/123837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,49 @@ +""" +Test lldb-dap output events +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import os +import time + +import lldbdap_testcase + + +class TestDAP_progress(lldbdap_testcase.DAPTestCaseBase): +@skipIfWindows +def

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,85 @@ +import inspect +import optparse +import shlex +import sys +import time + +import lldb + + +class ProgressTesterCommand: +program = "test-progress" + +@classmethod +def register_lldb_command(cls, debugger, module_name): +parser = cls.create_opt

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,85 @@ +import inspect +import optparse +import shlex +import sys +import time + +import lldb + + +class ProgressTesterCommand: +program = "test-progress" + +@classmethod +def register_lldb_command(cls, debugger, module_name): +parser = cls.create_opt

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,85 @@ +import inspect +import optparse +import shlex +import sys +import time + +import lldb + + +class ProgressTesterCommand: +program = "test-progress" + +@classmethod +def register_lldb_command(cls, debugger, module_name): +parser = cls.create_opt

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,49 @@ +""" +Test lldb-dap output events +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import os +import time + +import lldbdap_testcase + + +class TestDAP_progress(lldbdap_testcase.DAPTestCaseBase): +@skipIfWindows +def

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,49 @@ +""" +Test lldb-dap output events +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import os +import time + +import lldbdap_testcase + + +class TestDAP_progress(lldbdap_testcase.DAPTestCaseBase): +@skipIfWindows +def

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
@@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; rnk wrote: Can

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
@@ -33,25 +33,26 @@ using namespace llvm::opt; namespace { struct OptNameLess { - const char *StrTable; - ArrayRef PrefixesTable; + const StringTable *StrTable; rnk wrote: Can this be a const reference instead? Is there a reason you chose to make this a p

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-22 Thread Reid Kleckner via lldb-commits
https://github.com/rnk commented: Thanks, I just had one question. https://github.com/llvm/llvm-project/pull/123308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/123837 >From bc7bb2471e44ca7441f592611fd293f2b8c90435 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 21 Jan 2025 14:34:49 -0800 Subject: [PATCH 1/3] Have Progress message updates include their messages when s

[Lldb-commits] [lldb] [LLDB-DAP] Send Progress update message over DAP (PR #123837)

2025-01-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8e79ade49d68c49aeb8ba008b59f559b86d22765...56846b2fb5f491311af5ebfe98750c3159259e66 lldb/

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @DavidSpickett this is your branch now ... can you add @skipIfRemote to the tests? https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > I also noticed that if you don't save memory at all, the breakpoint tests > pass. Which is surprising, but ok given that the test doesn't check any > memory values, and watchpoint tests _do_ fail if you do not save memory. Yeah, this is why I think it was a good idea to add

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -1198,13 +1207,13 @@ bool FormatEntity::Format(const Entry &entry, Stream &s, // FormatEntity::Entry::Definition encoding return false; case Entry::Type::EscapeCode: -if (exe_ctx) { - if (Target *target = exe_ctx->GetTargetPtr

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,60 @@ +//===-- Statusline.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From ecd2f911e597e02c0e3bb82384e701ada09e811e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/123981 >From 3929895879a226bf8f0e407fead4524597a429af Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 22 Jan 2025 08:18:36 -0800 Subject: [PATCH 1/2] [lldb] Add SBThread.selected_frame property --- lldb/bindin

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ec15b242505a46ea7d195a6520fb869a80a2cd10...3929895879a226bf8f0e407fead4524597a429af lldb/

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread Dave Lee via lldb-commits
@@ -99,11 +99,8 @@ def test_api(self): (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint( self, "// break here", lldb.SBFileSpec("main.cpp") ) -frame = thread.GetSelectedFrame() num_hidden = 0 -for i in rang

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/123981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/123981.diff 5 Files Affected: - (modified) lldb/bindings/interface/SBThreadExtensions.i (+7) - (modified) lldb/test/API/commands/frame/recognizer/T

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/123981 None >From 3929895879a226bf8f0e407fead4524597a429af Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 22 Jan 2025 08:18:36 -0800 Subject: [PATCH] [lldb] Add SBThread.selected_frame property --- lldb/bind

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,161 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 9fd8d303ebc289e5b362e7252ae2f105a421a2e3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-22 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/123340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-22 Thread via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] 511dc26 - [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (#123951)

2025-01-22 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-22T17:47:26Z New Revision: 511dc261ab94da7db6e67b05cdcef9dcff44798a URL: https://github.com/llvm/llvm-project/commit/511dc261ab94da7db6e67b05cdcef9dcff44798a DIFF: https://github.com/llvm/llvm-project/commit/511dc261ab94da7db6e67b05cdcef9dcff44798a.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/123951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123951 >From 99398439a91ee5130c4907e8ea08f83dc93ee699 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 22 Jan 2025 13:01:44 + Subject: [PATCH 1/3] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-22 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/123905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -159,6 +159,79 @@ static bool TagIsRecordType(dw_tag_t tag) { } } +/// Get the object parameter DIE if one exists, otherwise returns +/// a default DWARFDIE. If \c containing_decl_ctx is not a valid +/// C++ declaration context for class methods, assume no object +/// par

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -159,6 +159,79 @@ static bool TagIsRecordType(dw_tag_t tag) { } } +/// Get the object parameter DIE if one exists, otherwise returns +/// a default DWARFDIE. If \c containing_decl_ctx is not a valid +/// C++ declaration context for class methods, assume no object +/// par

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/123951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread Pavel Labath via lldb-commits
labath wrote: @rocallahan The fix makes sense, but I think we still need to figure out what's the deal with green dragon. I can check out [the arm64 watchpoint failure](https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/18969/testReport/junit/lldb-api/functionalities_reverse-

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,161 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -1958,6 +1984,12 @@ lldb::thread_result_t Debugger::DefaultEventHandler() { // are now listening to all required events so no events get missed m_sync_broadcaster.BroadcastEvent(eBroadcastBitEventThreadIsListening); + if (!m_statusline && GetShowStatusline()) +m_st

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,58 @@ +//===-- Statusline.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-22 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/123905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-22 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. Ah, I missed `address_of_atomic`. Sorry. LGTM then. https://github.com/llvm/llvm-project/pull/123905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123951 >From 99398439a91ee5130c4907e8ea08f83dc93ee699 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 22 Jan 2025 13:01:44 + Subject: [PATCH 1/2] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch continues simplifying `ParseChildParameters` by moving out the logic that parses the first parameter of a function DIE into a helper function. Since with GCC (and lately Clang) function declarat

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Factor out CV-qualifier/is_static parsing from ParseChildParameters (PR #123951)

2025-01-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/123951 This patch continues simplifying `ParseChildParameters` by moving out the logic that parses the first parameter of a function DIE into a helper function. Since with GCC (and lately Clang) function declaratio

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,528 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,528 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: I also noticed that if you don't save memory at all, the breakpoint tests pass. Which is surprising, but ok given that the test doesn't check any memory values, and watchpoint tests *do* fail if you do not save memory. https://github.com/llvm/llvm-project/pull/123945 _

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/123945 to fix the testing. https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This reverts commit 22561cfb443267905d4190f0e2a738e6b412457f and fixes b7b9ccf44988edf49886743ae5c3cf4184db211f (#112079). The problem is that x86_64 and Arm 32-bit have memory regions above the stack

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/123945 This reverts commit 22561cfb443267905d4190f0e2a738e6b412457f and fixes b7b9ccf44988edf49886743ae5c3cf4184db211f (#112079). The problem is that x86_64 and Arm 32-bit have memory regions above the stack th

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -192,6 +192,33 @@ class SymbolContext { bool GetAddressRange(uint32_t scope, uint32_t range_idx, bool use_inline_block_range, AddressRange &range) const; + /// Get the address represented by this symbol context. + /// + /// The exact meaning of t

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-22 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123340 >From 2d6210ad9527df5147987f856e941e61d9851a97 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 17 Jan 2025 12:36:36 +0100 Subject: [PATCH 1/3] [lldb] Add SymbolContext::GetAddress Many (most?) uses of SC:

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,492 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes, I presented AArch64 as the counter example to show where it does work, but didn't make that clear. I've got a solution for this bit, but the watchpoint test is still failing one part on Arm 32 bit. https://github.com/llvm/llvm-project/pull/112079

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread Pavel Labath via lldb-commits
labath wrote: The failure was on the arm(32), not aarch64. (but yes, ptrace-read-only memory sounds like a plausible explanation) https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,492 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-22 Thread Pavel Labath via lldb-commits
labath wrote: Yes, the issue is two instances of the atomic counter in two libraries (well, one of them is an executable). I'm not sure why `GetTickCount` would be a better solution though. It returns time in milliseconds, which definitely too coarse-grained. Even if we used an API with greate

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,492 @@ +import os +import os.path +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbproxy import * +import lldbgdbserverutils +import re + + +class ThreadSnapshot: +def __init__(self, thread_

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: The first commit of this is https://github.com/llvm/llvm-project/pull/123720. I'm putting this up now because that previous PR is pretty straightforward, it's just adding registers. But this is the one that needs the most thought. So if you like, you can tackle them in one

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes When the Guarded Control Stack (GCS) is enabled, returns cause the processor to validate that the address at the location pointed to by gcspr_el0 matches the one in the link register. ``` ret (lr=A) <

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/123918 When the Guarded Control Stack (GCS) is enabled, returns cause the processor to validate that the address at the location pointed to by gcspr_el0 matches the one in the link register. ``` ret (lr=A) << pc

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-22 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: If `two copies of the pipe code` means 2 instances of g_pipe_serial in different dlls, probably it is better to use GetTickCount() or such. https://github.com/llvm/llvm-project/pull/123905 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Simplify ParseChildParameters (PR #123790)

2025-01-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/123790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 23fd8f6 - [lldb][DWARFASTParserClang][NFCI] Simplify ParseChildParameters (#123790)

2025-01-22 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-22T09:21:16Z New Revision: 23fd8f6f263d14d43fd4b2a599652beaadc9920e URL: https://github.com/llvm/llvm-project/commit/23fd8f6f263d14d43fd4b2a599652beaadc9920e DIFF: https://github.com/llvm/llvm-project/commit/23fd8f6f263d14d43fd4b2a599652beaadc9920e.diff LOG:

  1   2   >