[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff dd860bcfb57df429c0a1ad2e2d869ff3b795bc4d 
1948805894e006d84fbb78299574b3c7618959d8 --extensions h,cpp -- 
lldb/include/lldb/DataFormatters/FormatManager.h 
lldb/source/DataFormatters/FormatManager.cpp 
lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/DataFormatters/FormatManager.cpp 
b/lldb/source/DataFormatters/FormatManager.cpp
index d6d6935f3e..d6b621fe41 100644
--- a/lldb/source/DataFormatters/FormatManager.cpp
+++ b/lldb/source/DataFormatters/FormatManager.cpp
@@ -225,7 +225,7 @@ void FormatManager::GetPossibleMatches(
     CompilerType non_ptr_type = compiler_type.GetPointeeType();
     if (dereference_ptr)
       GetPossibleMatches(valobj, non_ptr_type, use_dynamic, entries,
-                        current_flags.WithStrippedPointer(), false);
+                         current_flags.WithStrippedPointer(), false);
     if (non_ptr_type.IsTypedefType()) {
       CompilerType deffed_pointed_type =
           non_ptr_type.GetTypedefedType().GetPointerType();
diff --git 
a/lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp 
b/lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
index 41b1d28234..5c330ac2ae 100644
--- a/lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
+++ b/lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
@@ -6,8 +6,8 @@ int main() {
        Foo& y = lval;
        Foo&& z = 1;
 
-       // Test lldb doesn't dereference pointer more than once.
-       Foo** xp = &x;
-       return 0; // Set breakpoint here
+        // Test lldb doesn't dereference pointer more than once.
+        Foo **xp = &x;
+        return 0; // Set breakpoint here
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/124048
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits