Author: Pavel Labath
Date: 2024-11-26T07:40:34+01:00
New Revision: 5e3f6150b1d490090faf945777985b18db73ea3f
URL:
https://github.com/llvm/llvm-project/commit/5e3f6150b1d490090faf945777985b18db73ea3f
DIFF:
https://github.com/llvm/llvm-project/commit/5e3f6150b1d490090faf945777985b18db73ea3f.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/117581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@tuliom Experimented on godbolt a bit, it looks like alignas(8) will handle our
padding to 56 on 32 and 64 https://godbolt.org/z/ssqeeEs71
https://github.com/llvm/llvm-project/pull/117604
___
lldb-commits mailing list
lldb-commits@lists
bwendling wrote:
Ah, okay. Thanks.
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Endilll wrote:
For the record, Aaron is not on vacation. So if you need his sign-off, you
should wait.
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/117604
>From 693f1039e10e5dd26ef0d600b03895f71f340b23 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 25 Nov 2024 10:26:07 -0800
Subject: [PATCH 1/2] Set all the properties of ELFLinuxSigInfo to a non build
de
https://github.com/Sirraide approved this pull request.
The changes seem fine to me now; not sure we’re handling this in all places
where it needs to be handled though. I’d say maybe wait a day or two before
merging in case anyone else wants to comment on that.
https://github.com/llvm/llvm-pro
bwendling wrote:
Yeah, but I'd like to get this off my plate. :-)
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Sirraide wrote:
> I image @AaronBallman is on vacation this week. @Sirraide would you be
> willing to LGTM this so that I can move it along?
I mean, this is stricly a performance issue, so I’m not sure why we’d want to
merge it this urgently...
https://github.com/llvm/llvm-project/pull/116719
bwendling wrote:
I image @AaronBallman is on vacation this week. @Sirraide would you be willing
to LGTM this so that I can move it along? It's certainly better than what we
have and I can address any concerns Aaron has afterwards.
https://github.com/llvm/llvm-project/pull/116719
__
https://github.com/tuliom requested changes to this pull request.
This didn't help. The size on 32-bits continue to be 44.
I think the difference is not really caused the size of the properties on 32
bits, but the implicit padding on 32/64 bits.
Look at the code generated here: https://godbolt.
https://github.com/mbucko closed
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,182 @@
+//===-- Socket.h *- C++
-*-===//
ashgti wrote:
Sounds good, I can re-work my patch to use `lldb/Hosts/*`
https://github.com/llvm/llvm-project/pull/116392
@@ -32,35 +34,44 @@ using namespace lldb_dap;
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, ReplMode repl_mode)
-: debug_adaptor_path(path), broadcaster("lldb-dap"),
- exception_breakpoints(), focus_tid(LLDB_INVALID_THREAD_ID),
- stop_at_entry(false), is_
@@ -0,0 +1,182 @@
+//===-- Socket.h *- C++
-*-===//
walter-erquinigo wrote:
Thanks for bringing this up. I think that ideally, we should be able to reuse
components from LLDB, like the `Host` library, as you point
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mbucko wrote:
> We obviously aren't checking this return anywhere. The only way it can return
> false that I can see is if you call RegisterPlugin with no callback pointer -
> which seems more like a programming error than a run-time check. Do we
> actually need this bool return?
It is indeed
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/114120
>From 362d6f52709ddf303d9d9fa256526182ba60fa53 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 29 Oct 2024 13:02:21 -0700
Subject: [PATCH] Fix return value of 'PluginManager::RegisterPlugin()'.
---
lldb/so
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Saleem Abdulrasool (compnerd)
Changes
The `find_package(LibXml2 ...)` invocation that we are currently using
precludes the use of "CONFIG mode" for libxml2. This is important to allow
dependencies to flow through the build with static buil
https://github.com/compnerd created
https://github.com/llvm/llvm-project/pull/117615
The `find_package(LibXml2 ...)` invocation that we are currently using
precludes the use of "CONFIG mode" for libxml2. This is important to allow
dependencies to flow through the build with static builds on Wi
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/117604
On #110065 the changes to LinuxSigInfo Struct introduced some variables that
will differ in size on 32b or 64b. I've rectified this by setting them all to
build independent types.
>From 693f1039e10e5dd26ef0d60
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
On #110065 the changes to LinuxSigInfo Struct introduced some variables
that will differ in size on 32b or 64b. I've rectified this by setting them all
to build independent types.
---
Full diff: https://git
Jlalond wrote:
@tuliom I don't have a way to verify this, would you mind assisting?
https://github.com/llvm/llvm-project/pull/117604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/117581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Ack, sorry about the delay. I will get this fixed today.
https://github.com/llvm/llvm-project/pull/110065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > The patch is still a bit larger than I'd like. I've tried to highlight a
> > few things that could be split off into separate PRs, but I think the
> > biggest question now (not really for you, but for lldb-dap maintainers) is
> > whether this could be using the socket abstrac
dwblaikie wrote:
> > Where those names go from "const string" to "const std::__1::string" (and
> > from "string" to "std::__1::string")? or something like that.
>
> Yes. In some cases, it's getting super verbose, e.g:
> `std::__1::basic_string,
> std::__1::allocator >::value_type`.
Oh yeah,
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/117581
>From 704eaf250480e0f74e4f135d61b7e66c3356eb97 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 25 Nov 2024 18:05:54 +0100
Subject: [PATCH 1/2] [lldb/NativePDB] Don't create parentless blocks
In case of an
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e5faeb69fbb87722ee315884eeef2089b10b0cee
704eaf250480e0f74e4f135d61b7e66c3356eb97 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
In case of an error GetBlock would return a reference to a Block without adding
it to a parent. This doesn't seem like a good idea, and none of the other
plugins do that.
This patch fixes that by propagating
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/117581
In case of an error GetBlock would return a reference to a Block without adding
it to a parent. This doesn't seem like a good idea, and none of the other
plugins do that.
This patch fixes that by propagating er
ashgti wrote:
> The patch is still a bit larger than I'd like. I've tried to highlight a few
> things that could be split off into separate PRs, but I think the biggest
> question now (not really for you, but for lldb-dap maintainers) is whether
> this could be using the socket abstractions al
tuliom wrote:
We're also seeing this issue.
We have a full build log available at
https://download.copr.fedorainfracloud.org/results/@fedora-llvm-team/llvm-snapshots-big-merge-20241123/fedora-rawhide-i386/08305565-llvm/builder-live.log.gz
, in case it helps.
https://github.com/llvm/llvm-projec
Author: David Spickett
Date: 2024-11-25T09:53:15Z
New Revision: 84fec7757ea330bbaf82b46ed081ccc45b120e45
URL:
https://github.com/llvm/llvm-project/commit/84fec7757ea330bbaf82b46ed081ccc45b120e45
DIFF:
https://github.com/llvm/llvm-project/commit/84fec7757ea330bbaf82b46ed081ccc45b120e45.diff
LOG
@@ -24,9 +24,8 @@ class AddressRangeListImpl {
public:
AddressRangeListImpl();
- AddressRangeListImpl(const AddressRangeListImpl &rhs) = default;
labath wrote:
I've deleted this because of a combination of a default copy constructor and a
non-default assi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
SBFunction::GetEndAddress doesn't really make sense for discontinuous
functions, so I'm declaring it deprecated. GetStartAddress sort of makes sense,
if one uses it to find the functions entry point, so I'm ke
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/117532
SBFunction::GetEndAddress doesn't really make sense for discontinuous
functions, so I'm declaring it deprecated. GetStartAddress sort of makes sense,
if one uses it to find the functions entry point, so I'm keep
@@ -32,35 +34,44 @@ using namespace lldb_dap;
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, ReplMode repl_mode)
-: debug_adaptor_path(path), broadcaster("lldb-dap"),
- exception_breakpoints(), focus_tid(LLDB_INVALID_THREAD_ID),
- stop_at_entry(false), is_
Author: Pavel Labath
Date: 2024-11-25T09:52:19+01:00
New Revision: 1bc98957c898d7e7233746a7b284982d20539593
URL:
https://github.com/llvm/llvm-project/commit/1bc98957c898d7e7233746a7b284982d20539593
DIFF:
https://github.com/llvm/llvm-project/commit/1bc98957c898d7e7233746a7b284982d20539593.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/116989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -250,6 +251,13 @@ def which(program):
return None
+def pickrandomport():
+"""Returns a random open port."""
+with socket.socket() as sock:
+sock.bind(("", 0))
+return sock.getsockname()[1]
labath wrote:
Cool. So I guess this me
@@ -0,0 +1,182 @@
+//===-- Socket.h *- C++
-*-===//
labath wrote:
I'm not quite comfortable with this essentially reimplementing large parts of
`source/Host/common/*Socket.cpp`. @walter-erquinigo do you have any
@@ -52,11 +51,11 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
- bool read_full(std::ofstream *log, size_t length, std::string &text);
+ bool read_full(llvm::raw_ostream *log, size_t length, std::string &text);
- bool read_line(std::ofst
@@ -0,0 +1,67 @@
+"""
+Test lldb-dap server integration.
+"""
+
+import os
+import tempfile
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+import lldbdap_testcase
+
+
+class TestDAP_server(lldbdap_testcase.DAPTestCaseBase):
+
@@ -1196,6 +1202,62 @@ def terminate(self):
self.process.wait()
self.process = None
+@classmethod
+def launch(
+cls, executable: str, /, connection=None, log_file=None, env=None
+) -> tuple[subprocess.Popen, str]:
+adaptor_en
@@ -0,0 +1,67 @@
+"""
+Test lldb-dap server integration.
+"""
+
+import os
+import tempfile
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+import lldbdap_testcase
+
+
+class TestDAP_server(lldbdap_testcase.DAPTestCaseBase):
+
@@ -1154,34 +1154,38 @@ class DebugAdaptorServer(DebugCommunication):
def __init__(
self,
executable=None,
+launch=True,
port=None,
+unix_socket=None,
init_commands=[],
log_file=None,
env=None,
):
https://github.com/labath commented:
The patch is still a bit larger than I'd like. I've tried to highlight a few
things that could be split off into separate PRs, but I think the biggest
question now (not really for you, but for lldb-dap maintainers) is whether this
could be using the socket
@@ -1196,6 +1202,62 @@ def terminate(self):
self.process.wait()
self.process = None
+@classmethod
+def launch(
+cls, executable: str, /, connection=None, log_file=None, env=None
+) -> tuple[subprocess.Popen, str]:
+adaptor_en
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
50 matches
Mail list logo
