dwblaikie wrote: > > Where those names go from "const string" to "const std::__1::string" (and > > from "string" to "std::__1::string")? or something like that. > > Yes. In some cases, it's getting super verbose, e.g: > `std::__1::basic_string<char, std::__1::char_traits<char>, > std::__1::allocator<char> >::value_type`.
Oh yeah, still good though. > > Probably the most common way to test this would be to add something in > > llvm/test/DebugInfo/X86/dwarfdump-*.ll > > Oh, this test might be where we test most of this in the past: > > llvm/test/tools/llvm-dwarfdump/X86/prettyprint_types.s > > Because DWARTTypePrinter is used by both llvm-dwarfump and lldb (after a > reland), how about just test DWARTTypePrinter in > `llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp` as an unit test? Perhaps - if it's easy to write/legible. Though I don't think we should feel bad about somewhat "indirectly" testing libDebugInfoDWARF via llvm-dwarfdump tests, rather than restricting ourselves to API tests for bugs in libDebugInfoDWARF. So whichever's more legible/maintainable. https://github.com/llvm/llvm-project/pull/117239 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
