ashgti wrote: > The patch is still a bit larger than I'd like. I've tried to highlight a few > things that could be split off into separate PRs, but I think the biggest > question now (not really for you, but for lldb-dap maintainers) is whether > this could be using the socket abstractions already present in lldb (instead > of building your own). If the answer to that is "yes", then switching to > those should probably be a separate patch as well.
I can split this into smaller patches. As far as the socket abstraction, at the moment lldb-dap doesn't use much (if anything) from lldb outside of the API folder. I saw the `lldb/Host/Socket.h` files but they also are built on top of the `IOObject` and interact with the `MainLoop` which would mean taking on a few new dependencies from the Host folder. I did look at the [`llvm::ListeningSocket`](https://github.com/llvm/llvm-project/blob/99fd1c5536547ed4fc360b16e7fa2e06278707a8/llvm/include/llvm/Support/raw_socket_stream.h#L59) which supports unix sockets / named pipes and the [`lldb_private::SocketAddress`](https://github.com/llvm/llvm-project/blob/99fd1c5536547ed4fc360b16e7fa2e06278707a8/lldb/include/lldb/Host/SocketAddress.h#L34) types when I implemented my socket, but I also tried to keep the socket simple for the lldb-dap's purposes. https://github.com/llvm/llvm-project/pull/116392 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
