[Lldb-commits] [lldb] [lldb][test] Fix tests Test*FromStdModule where called missing at(0) (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix tests Test*FromStdModule where called missing at(0) (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112485 >From 4736ff60f79352f2f9f703eced07c3555fef8a63 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 16 Oct 2024 10:37:37 +0400 Subject: [PATCH 1/2] [lldb][test] Fix the test TestArrayFromStdModule.py This

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112485 >From 4736ff60f79352f2f9f703eced07c3555fef8a63 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 16 Oct 2024 10:37:37 +0400 Subject: [PATCH 1/2] [lldb][test] Fix the test TestArrayFromStdModule.py This

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: I doubt those linker flags are going to work on windows. It might be more "portable" to ensure the symbols are present by using them from inside the program. https://github.com/llvm/llvm-project/pull/98701 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3860e29e0e743c5f411c3023396d1ea07c28da7d...4736ff60f79352f2f9f703eced07c3555fef8a63 lldb

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: > NativeProcessManager::Attach Also worth noting that the test is *attaching*. That's probably because on darwin we are launching the process in suspended mode and then asking the debugserver to attach to it. That's might not be what the packet forwarder expects (or is it?) htt

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This patch fixes the error https://lab.llvm.org/staging/#/builders/195/builds/4464 ``` File "llvm-project/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py", line 55, in

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/112485 This patch fixes the error https://lab.llvm.org/staging/#/builders/195/builds/4464 ``` File "llvm-project/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py", line 55, in test

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #112471)

2024-10-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/112471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 282ab2f - [lldb] Avoid repeated hash lookups (NFC) (#112471)

2024-10-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-10-15T23:11:30-07:00 New Revision: 282ab2f1895450707c9f8fc6a46634620165d1c9 URL: https://github.com/llvm/llvm-project/commit/282ab2f1895450707c9f8fc6a46634620165d1c9 DIFF: https://github.com/llvm/llvm-project/commit/282ab2f1895450707c9f8fc6a46634620165d1c9.diff L

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes depends on https://github.com/llvm/llvm-project/pull/112451 --- Full diff: https://github.com/llvm/llvm-project/pull/112466.diff 2 Files Affected: - (modified) lldb/source/Utility/DiagnosticsRenderin

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112466 None >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on t

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112451 >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same c

[Lldb-commits] [lldb] 69f7758 - Revert "[lldb] Fix command-expr-diagnostics.test for Windows (#112109)"

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T06:08:13+05:00 New Revision: 69f7758ddba662b63667507f2c472c008909dd7e URL: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd7e DIFF: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/5] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/4] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
@@ -962,6 +962,67 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/3] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 224f62de9e34d537b1fd282b47b773b04bea34f1 ea5bf236b32bb852d4461d37b732f6e7f0f3007b --e

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 224f62de9e34d537b1fd282b47b773b04bea34f1...ea5bf236b32bb852d4461d37b732f6e7f0f3007b lldb/

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -290,6 +290,30 @@ The initial repl-mode can be configured with the cli flag `--repl-mode=` and may also be adjusted at runtime using the lldb command `lldb-dap repl-mode `. + `lldb-dap custom-event` ashgti wrote: Renamed the event to `lldb-dap send-ev

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a custom DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/2] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] eca3206 - [lldb] Fix command-expr-diagnostics.test for Windows (#112109)

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T05:33:27+05:00 New Revision: eca3206d29e7ce97dd6336deaa3da96be37f8277 URL: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f8277 DIFF: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f82

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/112420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/111911 >From 55eab57c695d4be99305d2b6cee0c4f44261a473 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Oct 2024 14:39:44 -0700 Subject: [PATCH 1/4] [lldb] Log errors to the system log if they would

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +std::sort(ds.begin(), ds.end(), [](a

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes …reverse order The second inner loop (only) was missing the check for offset > column. Also this patch sorts the diagnostics before printing them. --- Full diff: https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112451 …reverse order The second inner loop (only) was missing the check for offset > column. Also this patch sorts the diagnostics before printing them. >From 934214ae1daf3fd70ee1cf332b269d636fbbc193 Mon Sep 1

[Lldb-commits] [lldb] cc13d4f - [lldb] Make the system log a NOOP on non-Darwin platforms

2024-10-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-15T16:13:42-07:00 New Revision: cc13d4fb4a208363ed1dab29829cd200a3e39c52 URL: https://github.com/llvm/llvm-project/commit/cc13d4fb4a208363ed1dab29829cd200a3e39c52 DIFF: https://github.com/llvm/llvm-project/commit/cc13d4fb4a208363ed1dab29829cd200a3e39c52.d

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -1896,6 +1896,8 @@ void request_initialize(const llvm::json::Object &request) { cmd.AddCommand( "repl-mode", new ReplModeRequestHandler(), "Get or set the repl behavior of lldb-dap evaluation requests."); + cmd.AddCommand("custom-event", new CustomDAPEventReq

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -290,6 +290,30 @@ The initial repl-mode can be configured with the cli flag `--repl-mode=` and may also be adjusted at runtime using the lldb command `lldb-dap repl-mode `. + `lldb-dap custom-event` vogelsgesang wrote: afaict, this command could also

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a custom DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently all of LLDB is being compiled with -Wno-deprecated-declarations. That's not desirable, especially as part of the LLVM monorepo, as we miss deprecation warnings from LLVM and clang. Accord

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/112276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: There was an attempt to remove this (https://reviews.llvm.org/D106035) but this hit some issues on Arch and with column counting which is out of scope for what I'm trying to achieve. https://github.com/llvm/llvm-project/pull/112446 _

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for #112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB. --- Full diff: https://

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/112446 Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for #112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB. >From 4c53565414c95ddd49050363

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
@@ -1896,6 +1896,8 @@ void request_initialize(const llvm::json::Object &request) { cmd.AddCommand( "repl-mode", new ReplModeRequestHandler(), "Get or set the repl behavior of lldb-dap evaluation requests."); + cmd.AddCommand("custom-event", new CustomDAPEventReq

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. looks pretty good. Just a minor nit https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-15 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Alex had a PR a month ago https://github.com/llvm/llvm-project/pull/106791 that got reverted from the same test failing on x86, I tried to repo the failure a few times on an intel mac and never succeeded. I'll try again with your patch when I have that set up. If this tes

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Or is @slydiman implying this PR isn't needed anymore? This patch should fix the following tests: array/TestArrayFromStdModule.py vector-of-vectors/TestVectorOfVectorsFromStdModule.py vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py See the buildbot https://lab

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Very nice! And now we'll see what all the CI bots think of this change. :) https://github.com/llvm/llvm-project/pull/110646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/110646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5f2cf99 - DynamicLoaderDarwin load images in parallel with preload (#110646)

2024-10-15 Thread via lldb-commits
Author: Dmitrii Galimzianov Date: 2024-10-15T13:25:01-07:00 New Revision: 5f2cf99e146ce99d4e148038d9bdd012331b4821 URL: https://github.com/llvm/llvm-project/commit/5f2cf99e146ce99d4e148038d9bdd012331b4821 DIFF: https://github.com/llvm/llvm-project/commit/5f2cf99e146ce99d4e148038d9bdd012331b4821

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis updated https://github.com/llvm/llvm-project/pull/112420 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00:00:00 2001 From: Brooks Davis Date: Tue, 15 Oct 2024 20:03:54 +0100 Subject: [PATCH 1/3] [llbd] Finish Turn lldb_private::Status into a value typ

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] de7f7ea - [lldb][test] Fix TestStdCXXDisassembly test (#112357)

2024-10-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-10-16T00:08:58+04:00 New Revision: de7f7ea884525cca24e8797319452bd8bc150752 URL: https://github.com/llvm/llvm-project/commit/de7f7ea884525cca24e8797319452bd8bc150752 DIFF: https://github.com/llvm/llvm-project/commit/de7f7ea884525cca24e8797319452bd8bc150752.dif

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Can we change the Darwin case to `USE_LIBCPP` though? The less reliance on > the system stdlib the better i think. I cannot test it on Darwin, so I would leave that to the Darwin experts. > Also lets check that the PR CI actually does run the test (aka doesn't > trigger the

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis updated https://github.com/llvm/llvm-project/pull/112420 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00:00:00 2001 From: Brooks Davis Date: Tue, 15 Oct 2024 20:03:54 +0100 Subject: [PATCH 1/2] [llbd] Finish Turn lldb_private::Status into a value typ

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] 224f62d - [lldb-dap] Improving the naming consistency of startDebugging reverse request. (#112396)

2024-10-15 Thread via lldb-commits
Author: John Harrison Date: 2024-10-15T12:19:21-07:00 New Revision: 224f62de9e34d537b1fd282b47b773b04bea34f1 URL: https://github.com/llvm/llvm-project/commit/224f62de9e34d537b1fd282b47b773b04bea34f1 DIFF: https://github.com/llvm/llvm-project/commit/224f62de9e34d537b1fd282b47b773b04bea34f1.diff

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/112396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From be42193c499f28f8b078f1b443ad09d94e7ba2c5 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 83368191a21340a6c3a8f88b01ecae6433640957 1732a1841a24e411cb261d7ae3bff16af618268c --e

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brooks Davis (brooksdavis) Changes Fix a few bare Status() invocations that were missed in the conversion. This is sufficent to build lldb on FreeBSD/aaarch64. Fixes: 0642cd768b80 --- Full diff: https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis created https://github.com/llvm/llvm-project/pull/112420 Fix a few bare Status() invocations that were missed in the conversion. This is sufficent to build lldb on FreeBSD/aaarch64. Fixes: 0642cd768b80 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: Can you add in the PR description why the `--whole-archive and --allow-multiple-definition` fixes the issue? And paste the log of the CI test that's failing? https://github.com/llvm/llvm-project/pull/98701 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Doing both seems fine, thanks! Can we change the Darwin case to `USE_LIBCPP` though? The less reliance on the system stdlib the better i think. Also lets check that the PR CI actually does run the test (aka doesn't trigger the skip add

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. cool https://github.com/llvm/llvm-project/pull/112396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 closed https://github.com/llvm/llvm-project/pull/110439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: I'm closing this in favor https://github.com/llvm/llvm-project/pull/110646 https://github.com/llvm/llvm-project/pull/110439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
@@ -642,26 +652,86 @@ ModuleSP DynamicLoaderDarwin::GetDYLDModule() { void DynamicLoaderDarwin::ClearDYLDModule() { m_dyld_module_wp.reset(); } +template +static std::vector parallel_map( +llvm::ThreadPoolInterface &threadPool, InputIterator first, +InputIterator las

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112357 >From 29326dedbc1c786e699fb30655d4105c867d1b84 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 15 Oct 2024 17:20:13 +0400 Subject: [PATCH 1/2] [lldb][test] Fix TestStdCXXDisassembly test The path #98

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread Alex Langford via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Adjusting the name from `lldb-dap startDebugging` to `lldb-dap start-debugging` to improve consistency with other names for commands in lldb/lldb-dap. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/112396 Adjusting the name from `lldb-dap startDebugging` to `lldb-dap start-debugging` to improve consistency with other names for commands in lldb/lldb-dap. >From 2aa7abfbdeaed07a5c46068ea2533c2d20613c5f Mon Sep 17 00

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > > I suggest @medismailben (or an Apple colleague he nominates), runs this > > test locally and does their best to narrow down the problem. > > @rocallahan does `rr` work on Mac? Because one cross check here would be to > > connect lldb to actual `rr` and see if that works.

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 5ec5d350f78d284634ffbc7800d7f34a5017707a Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: It seems #106885 fixed the issue for `deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py` and `list-dbg-info-content/TestDbgInfoContentListFromStdModule.py`, but not for `vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py`. The following 3 tests don'

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: Thank you for your understanding. Before trying to split up the other large files (a fairly large undertaking), I'd still recommend doing the initial thing of dropping the file in a PR (which should be relatively fast) and getting some feedback. ObjectFile plugins are one of the

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Custom DAP events can be detected using https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent. This API allows an lldb python script to send custom events to the

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/112384 Custom DAP events can be detected using https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent. This API allows an lldb python script to send custom events to the DAP

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/112360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/112307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks @jmorse! https://github.com/llvm/llvm-project/pull/112307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 74eb079 - [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (#112307)

2024-10-15 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-15T08:25:28-07:00 New Revision: 74eb079e06ae052feda28e63f4f63303efc01236 URL: https://github.com/llvm/llvm-project/commit/74eb079e06ae052feda28e63f4f63303efc01236 DIFF: https://github.com/llvm/llvm-project/commit/74eb079e06ae052feda28e63f4f63303efc01236.d

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > I suggest @medismailben (or an Apple colleague he nominates), runs this test > locally and does their best to narrow down the problem. > > @rocallahan does `rr` work on Mac? Because one cross check here would be to > connect lldb to actual `rr` and see if that works. If i

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @Michael137 Thanks. I have updated the patch with both solutions to be sure. https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112357 >From 29326dedbc1c786e699fb30655d4105c867d1b84 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 15 Oct 2024 17:20:13 +0400 Subject: [PATCH 1/2] [lldb][test] Fix TestStdCXXDisassembly test The path #98

[Lldb-commits] [lldb] a7b7af7 - [lldb] Avoid repeated map lookups (NFC) (#112315)

2024-10-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-10-15T07:37:00-07:00 New Revision: a7b7af7ad5c45fba87d9b423752601865cdfbee2 URL: https://github.com/llvm/llvm-project/commit/a7b7af7ad5c45fba87d9b423752601865cdfbee2 DIFF: https://github.com/llvm/llvm-project/commit/a7b7af7ad5c45fba87d9b423752601865cdfbee2.diff L

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112315)

2024-10-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/112315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-15 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/111891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4d78881 - [LLDB]Provide clearer error message for invalid commands. (#111891)

2024-10-15 Thread via lldb-commits
Author: Vy Nguyen Date: 2024-10-15T10:14:48-04:00 New Revision: 4d788814061a1003f577e293f2cd74b30223e050 URL: https://github.com/llvm/llvm-project/commit/4d788814061a1003f577e293f2cd74b30223e050 DIFF: https://github.com/llvm/llvm-project/commit/4d788814061a1003f577e293f2cd74b30223e050.diff LOG

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: > > maybe we could just skip the test if we can't locate the module? > > Can you suggest how to do that (locate the module)? Instead of, ``` self.expect( lib_stdcxx, "Libraray StdC++ is located", exe=False, substr

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Bots are fine and `functionalities/completion` kept passing: * https://lab.llvm.org/buildbot/#/builders/141/builds/3195 * https://lab.llvm.org/buildbot/#/builders/162/builds/8408 * https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/6753 It affects quite a numb

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > maybe we could just skip the test if we can't locate the module? Can you suggest how to do that (locate the module)? > Won't setting USE_LIBSTDCPP be an issue on Darwin? I can't test on Darwin. Maybe the following? ``` ifneq ($(OS),Darwin) USE_LIBSTDCPP := 1 else USE_S

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) Changes Following up from https://github.com/llvm/llvm-project/pull/112342, we roll out the fix and quote nested `make` invocations in all API tests. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail created https://github.com/llvm/llvm-project/pull/112360 Following up from https://github.com/llvm/llvm-project/pull/112342, we roll out the fix and quote nested `make` invocations in all API tests. From 80688469060b8956a36797d2b75863545df75801 Mon Sep 17 00:0

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 1/2 (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail edited https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: So the problem is that because we statically link we fail to find a `libstdc++.so`? Won't setting `USE_LIBSTDCPP` be an issue on Darwin? Generally, why is this test trying to do disassembly on every STL symbol? Can't really tell if this was actually STL specific from the git

  1   2   >