github-actions[bot] wrote:
@serby2000 Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a buil
Author: Serban
Date: 2024-09-18T08:05:35+02:00
New Revision: 30eb19321349827056facd54afab9b856b9f9d0a
URL:
https://github.com/llvm/llvm-project/commit/30eb19321349827056facd54afab9b856b9f9d0a
DIFF:
https://github.com/llvm/llvm-project/commit/30eb19321349827056facd54afab9b856b9f9d0a.diff
LOG: [
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
serby2000 wrote:
> @serby2000 do you have the necessary permissions to merge this? Or does one
> of us need to press the button?
I don't have the permissions
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@
jimingham wrote:
Do we need to worry about whether this recognizer hides frames that might be
useful to someone actually working on the libc++ they are debugging? I would
imagine in that case, you'd probably want to turn off this recognizer anyway,
since you want to see the details.
Seems to
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/109062
>From a0b5801ab231670215657ec720fa0c89bc262c04 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 29 Aug 2024 18:22:13 -0700
Subject: [PATCH 1/2] Add the ability to define custom completers for option
value
medismailben wrote:
Depends on https://github.com/llvm/llvm-project/pull/109063/files
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 090850f15dba926e2436089ff679b7015bb59e11
a0b5801ab231670215657ec720fa0c89bc262c04 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
090850f15dba926e2436089ff679b7015bb59e11...a0b5801ab231670215657ec720fa0c89bc262c04
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch adds new requirements to the Scripted Interface abstract method
checker to check the minimum number of argument for abstract methods.
This check is done when creating the interface objec
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/109063
This patch adds new requirements to the Scripted Interface abstract method
checker to check the minimum number of argument for abstract methods.
This check is done when creating the interface object so the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
If your arguments or option values are of a type that naturally uses one of
our common completion mechanisms, you will get completion for free. But if you
have your own custom values or if you want to do fancy th
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/109062
If your arguments or option values are of a type that naturally uses one of
our common completion mechanisms, you will get completion for free. But if you
have your own custom values or if you want to do fa
topperc wrote:
> I read through the patch again cleanly, and I don't have any problems with
> the PR at this point. The only thing I would note is that in
> `GetClangTargetABI` we're constructing a string which indicates which ISA
> extensions are enabled (that are relevant here) to return a s
jasonmolenda wrote:
I read through the patch again cleanly, and I don't have any problems with the
PR at this point. The only thing I would note is that in `GetClangTargetABI`
we're constructing a string which indicates which ISA extensions are enabled
(that are relevant here) to return a str
vogelsgesang wrote:
I think there is actually an even simpler fix for this test failure...
https://github.com/llvm/llvm-project/pull/109057
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
So far, the test case was also testing the offset -1. This test cases failed if
the string is immediately at the beginning of the memory region, though, and
the offset -1 hence belonged to a diffe
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/109057
So far, the test case was also testing the offset -1. This test cases failed if
the string is immediately at the beginning of the memory region, though, and
the offset -1 hence belonged to a different memo
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/serby2000 updated
https://github.com/llvm/llvm-project/pull/108948
>From 30e1a6fdc39f637095eec89584f6b163bc53037d Mon Sep 17 00:00:00 2001
From: Serby
Date: Tue, 17 Sep 2024 12:19:36 +0300
Subject: [PATCH 1/2] vscode-lldb - Add Environment configuration for the
lldb-dap proc
vogelsgesang wrote:
@serby2000 do you have the necessary permissions to merge this? Or does one of
us need to press the button?
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
vogelsgesang wrote:
> I actually wrote this for a team that already has their own viewer. We've
> suggested that they upstream that as well.
Is that viewer in VS-Code or in some other editor? (Trying to avoid duplicating
effort, so I don't accidentally implement the same thing)
https://github
ldionne wrote:
> Do you have an idea how we could de-risk this change? E.g., would do you have
> a couple more scenarios in mind for which I should add test cases? Are there
> similar patterns to the `operator()` which I should also cover in test cases?
What I could imagine is to drive this v
@@ -682,17 +683,51 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
}
bool DAP::HandleObject(const llvm::json::Object &object) {
+ auto start_time = std::chrono::steady_clock::now();
const auto packet_type = GetString(object, "type");
if (packet_type ==
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 11 Sep 2024 10:35:37 +0200
Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the
gdb-r
@@ -0,0 +1,96 @@
+"""
+Test RISC-V expressions evaluation.
+"""
dlav-sc wrote:
yep, addressed
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 2fc70cf82a7e67bde2d4fb35d2457d2812b34273 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/4] [lldb][RISCV] add jitted function calls to ABI
Function call
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 11 Sep 2024 10:35:37 +0200
Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the
gdb-r
jennphilqc wrote:
> Given this, I think we should take the best parts of both PRs 🙂 What do you
> think about the following path forward?
>
> * rebase this PR on top of [[lldb-dap] Support inspecting memoryÂ
> #104317](https://github.com/llvm/llvm-project/pull/104317)
> * scope this PR down to
bulbazord wrote:
> Do we have a sense of whether it's just a broken test, or if the PR broke
> some functionality? We tested the change on some internal scenarios and it
> showed good improvement, so we'd like to cherry-pick this patch (or a new
> patch).
I'm not sure yet, I haven't had time
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/8] [lldb-dap] Add feature to remember last non-empty
expression.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2d13302d3851747a023ffecc6388585e888cd0e9
60045b710e1102d6f220dfd4367f997b73bb64df --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2d13302d3851747a023ffecc6388585e888cd0e9...60045b710e1102d6f220dfd4367f997b73bb64df
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tom Yang (zhyty)
Changes
Somewhat recently, we made the change to hide the behavior to save LLDB session
history to the transcript buffer behind the flag `interpreter.save-transcript`.
By default, `interpreter.save-transcript` is false. Se
https://github.com/zhyty created
https://github.com/llvm/llvm-project/pull/109020
Somewhat recently, we made the change to hide the behavior to save LLDB session
history to the transcript buffer behind the flag `interpreter.save-transcript`.
By default, `interpreter.save-transcript` is false.
royitaqi wrote:
Do we have a sense of whether it's just a broken test, or if the PR broke some
functionality? We tested the change on some internal scenarios and it showed
good improvement, so we'd like to cherry-pick this patch (or a new patch).
https://github.com/llvm/llvm-project/pull/106
DavidSpickett wrote:
Will look at this properly tomorrow but just looking at the title, I'm
surprised that https://github.com/llvm/llvm-project/pull/88812 did not also fix
this. Perhaps putfile and install are different paths.
https://github.com/llvm/llvm-project/pull/108996
__
@@ -0,0 +1,13 @@
+# Tests that we show the first non-STL frame when
+# a verbose_trap triggers from within the STL.
+
+# UNSUPPORTED: system-windows
+#
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap-in-stl-nested.cpp -o %t.out
+# RUN: %lldb -b -s %s %t.out | FileCheck %s --chec
@@ -1390,7 +1414,10 @@ llvm::json::Value CreateVariable(lldb::SBValue v,
int64_t var_ref,
object.try_emplace("variablesReference", 0);
if (v.GetDeclaration().IsValid())
-object.try_emplace("declarationLocationReference", var_ref);
+object.try_emplace("declaratio
@@ -4087,32 +4114,64 @@ void request_variables(const llvm::json::Object
&request) {
void request_locations(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
- auto arguments = request.getObject("arguments");
+ auto *argume
@@ -1611,16 +1624,17 @@ void request_evaluate(const llvm::json::Object
&request) {
VariableDescription desc(value);
EmplaceSafeString(body, "result", desc.GetResult(context));
EmplaceSafeString(body, "type", desc.display_type_name);
- if (value.MightHave
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
Lldb documentation says that during remote debugging lldb client should check
the existence of the desired executable file on the remote target and only if
the file is missing copy it there. There is no such check in
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/108996
Lldb documentation says that during remote debugging lldb client should check
the existence of the desired executable file on the remote target and only if
the file is missing copy it there. There is no such ch
@@ -0,0 +1,13 @@
+# Tests that we show the first non-STL frame when
+# a verbose_trap triggers from within the STL.
+
+# UNSUPPORTED: system-windows
+#
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap-in-stl-nested.cpp -o %t.out
+# RUN: %lldb -b -s %s %t.out | FileCheck %s --chec
@@ -16,6 +16,31 @@ using namespace llvm;
using namespace lldb;
using namespace lldb_private;
+/// The 0th frame is the artificial inline frame generated to store
+/// the verbose_trap message. So, starting with the current parent frame,
+/// find the first frame that's not ins
cmtice wrote:
> > > Is the plan to get the DIL data structures merged before the rest of the
> > > patch series is up for review? I think it'd be great to see how the
> > > infrastructure introduced here will be used
> >
> >
> > There are 3 major pieces to the DIL implementation (soon to be 4
DavidSpickett wrote:
If folks could close any of their comments that have now been addressed, it
would be much easier to determine what is left to do.
We're going for the "most thorough review" record here :) Thanks for sticking
with it @dlav-sc .
https://github.com/llvm/llvm-project/pull/993
@@ -279,6 +279,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error,
lldb::addr_t &func_addr,
.setMCJITMemoryManager(std::make_unique(*this))
.setOptLevel(llvm::CodeGenOptLevel::Less);
+ if (triple.isRISCV64())
DavidSpickett wrote:
This shou
@@ -1011,6 +1011,135 @@ void RuntimeDyldELF::resolveBPFRelocation(const
SectionEntry &Section,
}
}
+static void applyUTypeImmRISCV(uint8_t *InstrAddr, uint32_t Imm) {
DavidSpickett wrote:
Does this still need to be done?
https://github.com/llvm/llvm-proje
@@ -0,0 +1,96 @@
+"""
+Test RISC-V expressions evaluation.
+"""
DavidSpickett wrote:
Are these tests going to be removed then?
On the grounds that existing tests in the test suite will cover these scenarios.
https://github.com/llvm/llvm-project/pull/99336
_
https://github.com/serby2000 updated
https://github.com/llvm/llvm-project/pull/108948
>From 30e1a6fdc39f637095eec89584f6b163bc53037d Mon Sep 17 00:00:00 2001
From: Serby
Date: Tue, 17 Sep 2024 12:19:36 +0300
Subject: [PATCH 1/2] vscode-lldb - Add Environment configuration for the
lldb-dap proc
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -78,6 +78,15 @@
"scope": "resource",
"type": "string",
"description": "The log path for lldb-dap (if any)"
+},
+ "lldb-dap.environment": {
vogelsgesang wrote:
Use whitespaces instead of tabs for indentatio
DavidSpickett wrote:
I've disabled this on Windows for now but please address the issue generally.
Testing memory region overlaps is tricky. I did it for memory tagging by hoping
that the kernel would allocate pages in the right order, which worked for at
least simulated systems. Pavel recentl
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI {
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance
// instead.
bool m_is_rv64; // true if target is riscv64; fa
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 08b0bb18e46be06ddf6397455382c5b75bc3b757 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI
Function call
Author: David Spickett
Date: 2024-09-17T12:51:46Z
New Revision: ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
URL:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
DIFF:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6.diff
LOG
egorzhdan wrote:
This is a great UX improvement, thanks!
https://github.com/llvm/llvm-project/pull/108825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
The test case is failing on Windows, for reasons not related to it being
Windows but due to data layout.
The const string is placed at the start of a region:
```
(lldb) p rawptr
(const char *) 0x7ff77fcb5000 "dead"
(lldb) memory region --all
<...>
[0x7ff77fc61000-0x
asavonic wrote:
> Our idea is summarized in
> https://discourse.llvm.org/t/rfc-lldb-more-reliable-completion-of-record-types/77442.
> Basically the goal is to guarantee that a call to `getDefinition`, _will_
> fetch the definition. This is something that Clang already does, but we just
> neve
Author: David Spickett
Date: 2024-09-17T09:30:14Z
New Revision: b39a100ff4ec16f1f9cafcc48ea7fed920726650
URL:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650
DIFF:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Serban (serby2000)
Changes
Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are
needed to be able to use lldb-dap in vscode
This PR adds a way to set the environment for the lldb-dap process using
configuration.
---
https://github.com/serby2000 created
https://github.com/llvm/llvm-project/pull/108948
Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are
needed to be able to use lldb-dap in vscode
This PR adds a way to set the environment for the lldb-dap process using
configuration.
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 60b26a50218e20431dd645b93d341403ff5b2ee4 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/2] [lldb][libc++] Hide all libc++ implementation det
https://github.com/Michael137 commented:
Are there cases where we fail to `ParseVariableDIE` the first time around but
could succeed later on in the debug sessions?
This comment seems to suggest that's possible:
https://github.com/llvm/llvm-project/blob/bbab5e47c17c0ebc9dfe20f43c8aeaae95f37b9e
Michael137 wrote:
> > Is the plan to get the DIL data structures merged before the rest of the
> > patch series is up for review? I think it'd be great to see how the
> > infrastructure introduced here will be used
>
> There are 3 major pieces to the DIL implementation (soon to be 4, once I've
Michael137 wrote:
When you're stopped in a frame and you have libc++ frames above you in the
backtrace, you're either stopped in a callback (like `std::function`,
`std::make_unique`, `std::sort`), or you're deliberately stepping into libc++
code. For the latter, you probably don't want to hide
vogelsgesang wrote:
> [...] like I said I'm a bit scared of it being too aggressive.
Yes, this is also my main concern here. E.g., for `std::ranges::sort`, it
already turns out to be slightly too aggressive, as discussed in the commit
message and the test case comment. The "`std::ranges::sort`
74 matches
Mail list logo
