jennphilqc wrote: > Given this, I think we should take the best parts of both PRs 🙂 What do you > think about the following path forward? > > * rebase this PR on top of [[lldb-dap] Support inspecting memory > #104317](https://github.com/llvm/llvm-project/pull/104317) > * scope this PR down to `writeMemory` > * modify this PR to also extend the test cases in `TestDAP_memory.py` (added > by my PR) to introduce test coverage also for `writeMemory`
It sounds like a great idea to work together on this, @vogelsgesang ! Let me set up the rebase and work on all the suggested edits above. > > Also, I noticed that you did not introduce any `memoryReference`s as part of > your pull request. With your PR, how can a user even open the hex-viewer in > VS-Code? Is there some way which I am not aware of to open the hex-viewer > without a `memoryReference`? Asking, because I was considering introducing a > "View memory address" via TypeScript, similar to [what VSCodeLLDB > does](https://github.com/vadimcn/codelldb/blob/05502bf75e4e7878a99b0bf0a7a81bba2922cbe3/extension/main.ts#L476) > - but if there already is some other way to pop up the memory-viewer, doing > so would be unnecessary I actually wrote this for a team that already has their own viewer. We've suggested that they upstream that as well. https://github.com/llvm/llvm-project/pull/108036 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
