vogelsgesang wrote:

> [...] like I said I'm a bit scared of it being too aggressive.

Yes, this is also my main concern here. E.g., for `std::ranges::sort`, it 
already turns out to be slightly too aggressive, as discussed in the commit 
message and the test case comment. The "`std::ranges::sort` calls an operator() 
of an internal struct type" pattern is already slightly problematic...

Do you have an idea how we could de-risk this change? E.g., would do you have a 
couple more scenarios in mind for which I should add test cases? Are there 
similar patterns to the `operator()` which I should also cover?

Do we have some libc++ developers which are using lldb top-of-tree for their 
day-to-day work on libc++ and who would make us aware in case this commit turns 
out to be too aggressive?

https://github.com/llvm/llvm-project/pull/108870
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to