https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/3] Squash 64b-memory-regions-minidump and take only
llvm-chang
clayborg wrote:
So the BaseRVA does look good, the memory range is being set to 8 bytes instead
of 5 for each data.
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
clayborg wrote:
```
0x07fcf081828b - 0x07fcf0818283 = 8 (from MemoryRanges[0]) and there
are only 5 bytes in the file's hexdump
```
So the data for MemoryRanges[1] will be off since it will think it starts at:
```
BaseRva + 8 = 0x5c + 8 = 0x0064
```
And that points to the last 2 byte
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Note GDBRemoteCommunicationServerPlatform::DebugserverProcessReaped() may cause
a crash if this callback will be called from the child monitor thread after
destroing the instance of GDBRemoteCommunicationServerPlatform. It is
impossible to control this thread anyway.
Hope I wil
clayborg wrote:
Does look like this is working correctly:
```
$ minidump.py /tmp/md.dmp
MINIDUMP_HEADER:
Signature = 0x504d444d
Version= 0xa793
NumberOfStreams= 0x0001
StreamDirectoryRva = 0x0020
CheckSum = 0x
TimeDateStamp = 0x
@@ -152,15 +165,15 @@ class MinidumpFile : public Binary {
}
/// Return a slice of the given data array, with bounds checking.
- static Expected> getDataSlice(ArrayRef Data,
- size_t Offset, size_t Size);
+ static Expected
@@ -336,3 +336,51 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
@@ -336,3 +336,51 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
@@ -136,6 +136,22 @@ static size_t layout(BlobAllocator &File,
MinidumpYAML::ExceptionStream &S) {
return DataEnd;
}
+static size_t layout(BlobAllocator &File, MinidumpYAML::Memory64ListStream &S)
{
+ size_t BaseRVA = File.tell() + sizeof(minidump::Memory64ListHeader);
--
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From 396b9a0595c04a8ec2e01c06788ddf9498ee3c4c Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH] [lldb] Updated lldb-server to spawn the child process and
sh
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
`lldb-server --server` works on Windows now w/o multithreading. The rest
functionality remains unchanged.
Added also PipeWindows::WriteWithTimeout(), fixed
PipeWindows::ReadWithTimeout() and missing init
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/101283
`lldb-server --server` works on Windows now w/o multithreading. The rest
functionality remains unchanged.
Added also PipeWindows::WriteWithTimeout(), fixed
PipeWindows::ReadWithTimeout() and missing initializ
Author: Med Ismail Bennani
Date: 2024-07-30T19:54:11-07:00
New Revision: e72cdae47b4e263ea97b2bdd75cf44c1510cf3be
URL:
https://github.com/llvm/llvm-project/commit/e72cdae47b4e263ea97b2bdd75cf44c1510cf3be
DIFF:
https://github.com/llvm/llvm-project/commit/e72cdae47b4e263ea97b2bdd75cf44c1510cf3be.
Author: Med Ismail Bennani
Date: 2024-07-30T19:46:19-07:00
New Revision: f65fa5461dcbaf554babf10ca67ae8fea5b4da7e
URL:
https://github.com/llvm/llvm-project/commit/f65fa5461dcbaf554babf10ca67ae8fea5b4da7e
DIFF:
https://github.com/llvm/llvm-project/commit/f65fa5461dcbaf554babf10ca67ae8fea5b4da7e.
medismailben wrote:
@Michael137 This broke the windows bot:
https://lab.llvm.org/buildbot/#/builders/141/builds/1214 Should we skip it on
that platform or do you see an easy fix ?
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mail
Author: Med Ismail Bennani
Date: 2024-07-30T18:26:04-07:00
New Revision: c35c4c72e4977258fc1da940e0470e8d0671bf07
URL:
https://github.com/llvm/llvm-project/commit/c35c4c72e4977258fc1da940e0470e8d0671bf07
DIFF:
https://github.com/llvm/llvm-project/commit/c35c4c72e4977258fc1da940e0470e8d0671bf07.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0891ccc0c68c35e17562c752955788f08054bcdb
9be9a32f57c5bd516eb5e64282ed71292a78c27a --e
@@ -550,7 +588,7 @@ Stream::create(const Directory &StreamDesc, const
object::MinidumpFile &File) {
llvm_unreachable("Unhandled stream kind!");
}
-Expected Object::create(const object::MinidumpFile &File) {
+Expected Object::create(object::MinidumpFile &File) {
@@ -356,6 +370,13 @@ void yaml::MappingContextTraits::mapping(
IO.mapRequired("Content", Content);
}
+void yaml::MappingContextTraits::mapping(
+IO &IO, MemoryDescriptor_64 &Memory, BinaryRef &Content) {
+ mapRequiredHex(IO, "Start of Memory Range", Memory.StartOfMemory
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This PR adds support for `obj2yaml` and `yaml2obj` to generate minidumps that
have a Memory64List stream. This is a prerequisite to #101086.
Worth noting
- const dropped on minidumps so we could cache a Memo
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/101272
This PR adds support for `obj2yaml` and `yaml2obj` to generate minidumps that
have a Memory64List stream. This is a prerequisite to #101086.
Worth noting
- const dropped on minidumps so we could cache a MemoryD
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jon Roelofs
Date: 2024-07-30T17:17:04-07:00
New Revision: a982cabea3cfbf456a01ed85499fa7dfc7ec18c7
URL:
https://github.com/llvm/llvm-project/commit/a982cabea3cfbf456a01ed85499fa7dfc7ec18c7
DIFF:
https://github.com/llvm/llvm-project/commit/a982cabea3cfbf456a01ed85499fa7dfc7ec18c7.diff
L
jasonmolenda wrote:
Thanks for the suggestion @jimingham , I pushed an update to implement that
idea.
https://github.com/llvm/llvm-project/pull/101130
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -52,6 +52,7 @@ def test_negative_indexing(self):
self.build()
self.validate_negative_indexing()
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
I see the same function name/signature.
Btw, I'd recommend add
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/101243
>From 61371af08b82e1229c34b43f56772813c2f74b1c Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 30 Jul 2024 13:56:21 -0700
Subject: [PATCH 1/7] [cmake][llvm] Limit the number of Xcode schemes created
by d
@@ -1423,3 +1423,11 @@ endif()
if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
add_subdirectory(utils/llvm-locstats)
endif()
+
+if (XCODE)
+ set(LLVM_XCODE_EXTRA_TARGET_SCHEMES "" CACHE STRING "Specifies an extra list
of targets to turn into schemes")
jroelo
@@ -1423,3 +1423,11 @@ endif()
if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
add_subdirectory(utils/llvm-locstats)
endif()
+
+if (XCODE)
+ set(LLVM_XCODE_EXTRA_TARGET_SCHEMES "" CACHE STRING "Specifies an extra list
of targets to turn into schemes")
claybo
clayborg wrote:
Great! That will be very useful.
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/101243
>From 61371af08b82e1229c34b43f56772813c2f74b1c Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 30 Jul 2024 13:56:21 -0700
Subject: [PATCH 1/6] [cmake][llvm] Limit the number of Xcode schemes created
by d
jroelofs wrote:
neat idea. that's doable.
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Can we add a cmake settings that allows users to add custom target names that
will be added? I would love to use this for my common projects like:
```
-DCMAKE_LLVM_XCODE_TARGETS=lldb;llvm-dwarfdump;llvm-gsymutil;lld
```
And it would add those top level targets?
https://github.co
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Currently a Module has a std::optional which is created when
the UnwindTable is requested from outside the Module. The idea is to delay its
creation until the Module has an ObjectFile init
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/101130
>From 55b1ac1fbad89ebc50038738c1e09045e9884be8 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 29 Jul 2024 22:37:43 -0700
Subject: [PATCH 1/3] [lldb] Change Module to have a concrete UnwindTable,
u
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/101243
>From 61371af08b82e1229c34b43f56772813c2f74b1c Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Tue, 30 Jul 2024 13:56:21 -0700
Subject: [PATCH 1/5] [cmake][llvm] Limit the number of Xcode schemes created
by d
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/101237
>From 6ef64acd518afe8bdc42c5042f35c857be96e3b4 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 30 Jul 2024 13:37:44 -0700
Subject: [PATCH 1/2] Impove ObjectFileELF's .dynamic parsing and usage.
This pat
JDevlieghere wrote:
> I was hoping to fix everything in one Pull Request so that it at least
> becomes usable once this merges.
The LLVM project generally
[prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
smaller patches as they're easier to review. We'll def
https://github.com/jasonmolenda approved this pull request.
Thanks for the good cleanup.
https://github.com/llvm/llvm-project/pull/101169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
jasonmolenda wrote:
> It is a little odd that the laziness of the UnwindTable itself gets defeated
> by Update, which forces the Initialize even if the unwind table isn't
> currently being requested.
I could add an ivar `m_module_has_updated` which is set when a new
ObjectFile/SymbolFileVendo
@@ -64,7 +64,7 @@ class UnwindTable {
private:
void Dump(Stream &s);
- void Initialize();
+ void Initialize(bool force = false);
jasonmolenda wrote:
Yeah I'm not thrilled with the terminology I used. But I had `Initialize`
which assumed no unwind source
jimingham wrote:
So the strategy here is the UnwindTable class calls its `Initialize()` any time
a client wants to use an UnwindTable so that it can be lazily filled. Then
Module calls `UnwindTable::Update()` any time something gets added to the
module that might change the unwind table.
Th
https://github.com/tschuett edited
https://github.com/llvm/llvm-project/pull/101237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bee2654300a8f524e05dd4cad41411d597246ac0
6ef64acd518afe8bdc42c5042f35c857be96e3b4 --e
clayborg wrote:
I am going to split this up. New PR with just .dynamic changes is here:
https://github.com/llvm/llvm-project/pull/101237
https://github.com/llvm/llvm-project/pull/100900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/100900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
This patch improves the ability of a ObjectFileELF instance to read the
.dynamic section. It adds the ability to read the .dynamic section from a ELF
file that is read from memory, cleans up the usage of the
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/101237
This patch improves the ability of a ObjectFileELF instance to read the
.dynamic section. It adds the ability to read the .dynamic section from a ELF
file that is read from memory, cleans up the usage of the .
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
> For comparison, my objdump output shows no symbol table:
>
> ```
> PS C:\workspace\
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
```
$ F:/Users/vdzhidzhoev/temp/build-lldb-native/bin/clang.exe main.o -gdwarf -O0
-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -64,7 +64,7 @@ class UnwindTable {
private:
void Dump(Stream &s);
- void Initialize();
+ void Initialize(bool force = false);
jimingham wrote:
This needs a comment explaining what you are forcing.
https://github.com/llvm/llvm-project/pull/101130
_
https://github.com/jimingham approved this pull request.
This is a great cleanup, thanks for doing it!
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/101208
>From 515525357026eb49508b1322b3b9ee40840f7b5e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 29 Jul 2024 16:32:45 -0700
Subject: [PATCH 1/2] [lldb] Unify the way we get the Target in CommandOb
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
kendalharland wrote:
For comparison, my objdump output shows no symbol table:
```
PS C:\workspace\llvm-
@@ -369,12 +369,12 @@ class CommandObject : public
std::enable_shared_from_this {
"currently stopped.";
}
- // This is for use in the command interpreter, when you either want the
- // selected target, or if no target is present you want to prime the dummy
- /
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
kendalharland wrote:
I see. Our command lines look identical. Can you also please share the linker
comm
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -369,12 +369,12 @@ class CommandObject : public
std::enable_shared_from_this {
"currently stopped.";
}
- // This is for use in the command interpreter, when you either want the
- // selected target, or if no target is present you want to prime the dummy
- /
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Currently, CommandObjects are obtaining a target in a variety of ways. Often
the command incorrectly operates on the selected target. As an example, when a
breakpoint command is running, the current
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/101208
Currently, CommandObjects are obtaining a target in a variety of ways. Often
the command incorrectly operates on the selected target. As an example, when a
breakpoint command is running, the current target
tedwoodward wrote:
BTW, if you call SetCanInterpretFunctionCalls(true); somewhere, you can use the
IR interpreter to call functions. PrepareTrivialCall below the implementation
you do here, for JIT, handles that.
https://github.com/llvm/llvm-project/pull/99336
_
dzhidzhoev wrote:
Update: fixed condition for remote execution.
Now this PR is ready for review.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH] [lldb][test] Support remote run of Shell tests
1. This
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From d21c76b25e20e45b20f0f95bd7b4324fb5a19a81 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH] [lldb][test] Support remote run of Shell tests
1. This
labath wrote:
> > Sounds good. Could you split off the lldb parts to a separate review though?
>
> @labath I think we need both, in order to fix `SBProcess` to return all
> memory regions we need the LLDB change, which enables us to test if the
> yaml2obj generates correctly
I can believe you
@@ -1,3 +1,4 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
dzhidzhoev wrote:
> @dzhidzhoev would you be able to share the CMake configuration your Windows
> native CI is using? I'm having trouble spotting what's wrong with my local
> build.
For sure! Sorry,
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
"first" is preset in both dumps
https://github.com/llvm/llvm-project/pull/100477
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
Here's the execution log on my setup
https://gist.github.com/dzhidzhoev/c6af2c83c6175
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -154,3 +155,17 @@ MinidumpFile::create(MemoryBufferRef Source) {
return std::unique_ptr(
new MinidumpFile(Source, Hdr, *ExpectedStreams, std::move(StreamMap)));
}
+
+Expected> MinidumpFile::getMemory64List() const {
+ Expected MemoryList64 =
getMemoryList64Header()
Jlalond wrote:
> Sounds good. Could you split off the lldb parts to a separate review though?
@labath I think we need both, in order to fix `SBProcess` to return all memory
regions we need the LLDB change, which enables us to test if the yaml2obj
generates correctly
https://github.com/llvm/ll
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/100624
>From 223075d6f036537a7edec10b370f6d922135cb79 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 23 Jul 2024 13:30:40 -0700
Subject: [PATCH 1/2] [lldb] Add constant value mode for Regis
@@ -153,6 +155,9 @@ void UnwindPlan::Row::RegisterLocation::Dump(Stream &s,
if (m_type == atDWARFExpression)
s.PutChar(']');
} break;
+ case isConstant:
+s.Printf("=%x", m_location.offset);
felipepiovezan wrote:
Ohh oops, you're totally right!
90 matches
Mail list logo
