jasonmolenda wrote:

> It is a little odd that the laziness of the UnwindTable itself gets defeated 
> by Update, which forces the Initialize even if the unwind table isn't 
> currently being requested.

I could add an ivar `m_module_has_updated` which is set when a new 
ObjectFile/SymbolFileVendor is added to the Module.  And all the getter methods 
in UnwindTable call `Initialize()` which currently checks that it has been 
initialized or not, and add that in.

> Not sure if that matters? If it does, Update could just tell the UnwindTable 
> that next time it gets asked a question it has to reread the unwind 
> information. Maybe it could even just set m_initialized back to `false` and 
> then let the lazy initialization redo the work when requested?

Hah, I didn't read your full comment.  Yes, same idea, and just as good.  I'll 
do that.


https://github.com/llvm/llvm-project/pull/101130
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to