[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-30 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/93548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 71ccd0d - [IRInterpreter] Return zero address for missing weak function (#93548)

2024-05-30 Thread via lldb-commits
Author: Nikita Popov Date: 2024-05-31T08:18:35+02:00 New Revision: 71ccd0d8ccf876e32e21514839195f159642fe4c URL: https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c DIFF: https://github.com/llvm/llvm-project/commit/71ccd0d8ccf876e32e21514839195f159642fe4c.diff

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-30 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: This patch look good to me, do you have necessary permissions to squash & merge? https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-30 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-30 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-30 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 852aaf5 - Reapply "[Support] Remove terminfo dependency (#92865)" (#93889)

2024-05-30 Thread via lldb-commits
Author: Aaron Siddhartha Mondal Date: 2024-05-31T01:29:00+02:00 New Revision: 852aaf54071ad072335dcac57f544d4da34c875a URL: https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c875a DIFF: https://github.com/llvm/llvm-project/commit/852aaf54071ad072335dcac57f544d4da34c

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] Reapply "[Support] Remove terminfo dependency (#92865)" (PR #93889)

2024-05-30 Thread Aaron Siddhartha Mondal via lldb-commits
https://github.com/aaronmondal closed https://github.com/llvm/llvm-project/pull/93889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] Reapply "[Support] Remove terminfo dependency (#92865)" (PR #93889)

2024-05-30 Thread Aaron Siddhartha Mondal via lldb-commits
https://github.com/aaronmondal edited https://github.com/llvm/llvm-project/pull/93889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-30 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: Did a bit of digging around; it looks like at the very least the Arch Linux python package and the Python docker container don't contain the `packaging` library. https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
jimingham wrote: > Also, something to keep in mind: If Dlang ever decides to change their > mangled name scheme in the future, this change may become wrong then. I'm not > sure what commitments the D language project has for their ABI stability > though. That's why this shouldn't be in lldb i

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] Reapply "[Support] Remove terminfo dependency (#92865)" (PR #93889)

2024-05-30 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/93889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] Reapply "[Support] Remove terminfo dependency (#92865)" (PR #93889)

2024-05-30 Thread Fangrui Song via lldb-commits
MaskRay wrote: Consider copying the original description to ensure that the linked issues will be properly closed. https://github.com/llvm/llvm-project/pull/93889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
kastiglione wrote: > This a little bit raises the question why we don't do the same checks for > `_R` and `_Z`. I asked myself the same. Turns out Rust doesn't have a number following the `_R` prefix, so it's not as simple. Given that C++ is much more load bearing, I didn't want to include ch

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes This argument allows to specify the path to make which is used by LLDB API tests to compile test programs. It might come in handy for setting up cross-platform remote runs of API tests on Windows h

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-30 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/93883 This argument allows to specify the path to make which is used by LLDB API tests to compile test programs. It might come in handy for setting up cross-platform remote runs of API tests on Windows host. It ca

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
https://github.com/jimingham approved this pull request. This a little bit raises the question why we don't do the same checks for `_R` and `_Z`. It would be even better if the various demanglers in llvm had a quick "could this be mine" check so we didn't have to encode this in lldb. But you

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-30 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From e7823321c1b7e23b077a0b785af50d641fc9a6b7 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/5] Single thread timeout feature --- lldb/include/lldb/Targ

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/93881 >From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 30 May 2024 13:29:41 -0700 Subject: [PATCH 1/2] [lldb] Improve identification of Dlang mangled names --- lld

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f795853d1f77bff69c3805f75e54fa7a32cc23d9...21a61a1a5ae68fc1e913f73c4311258675990f95 lldb/

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/93881.diff 4 Files Affected: - (modified) lldb/source/Core/Mangled.cpp (+9-2) - (added) lldb/test/API/lang/c/non-mangled/Makefile (+4) - (added) l

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/93881 None >From 21a61a1a5ae68fc1e913f73c4311258675990f95 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 30 May 2024 13:29:41 -0700 Subject: [PATCH] [lldb] Improve identification of Dlang mangled names --- l

[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-30 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with @labath's command. https://github.com/llvm/llvm-project/pull/93833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6...007bab454cd9aa2c73ce167ee15900523d3b7318 lldb/

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes But one made in a situation where that's impossible might only have an error, and no symbol context, so that's not necessarily true. Check for the target's validity before using it. Fixes issue #93313 --- Full d

[Lldb-commits] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-30 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/93880 But one made in a situation where that's impossible might only have an error, and no symbol context, so that's not necessarily true. Check for the target's validity before using it. Fixes issue #93313 >From

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-30 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: > > @felipepiovezan I have another question. For the same example. I see: > > You are right. The fact that they have the same relative offset tells me that > some part of the code is failing to account for TUs. I just checked the > printing code in the hope that it was a mistak

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/93871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 493eefc - [lldb][test] Fix failing test TestAddressRange.py (#93871)

2024-05-30 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-30T13:44:51-07:00 New Revision: 493eefc93f2901dd987b8ff441004352b317cab9 URL: https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9 DIFF: https://github.com/llvm/llvm-project/commit/493eefc93f2901dd987b8ff441004352b317cab9.diff LO

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/93871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread Greg Clayton via lldb-commits
@@ -1425,4 +1425,6 @@ let Command = "statistics dump" in { Desc<"Dump the total possible debug info statistics. " "Force loading all the debug information if not yet loaded, and collect " "statistics with those.">; + def statistics_dump_transcript: Option<"transcri

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/93871 >From afcd5a2524fc27cab2ff55ffba06cc19c62bbc4e Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Thu, 30 May 2024 13:04:17 -0700 Subject: [PATCH] [lldb][test] Fix failing test TestAddressRange.py Summary: Test llvm

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
@@ -191,7 +191,7 @@ def test_address_range_print_resolved(self): interp.HandleCommand(script, result, False) self.assertTrue(result.Succeeded(), "script command succeeded") # [0x1000-0x2000] // Resolved with target or addresses without sections -

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
@@ -191,7 +191,7 @@ def test_address_range_print_resolved(self): interp.HandleCommand(script, result, False) self.assertTrue(result.Succeeded(), "script command succeeded") # [0x1000-0x2000] // Resolved with target or addresses without sections -

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/93871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/93871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-30 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > @felipepiovezan I have another question. For the same example. I see: > > ``` > Name 4 { > Hash: 0x2F94396D > String: 0x0049 "_Z9get_statev" > Entry @ 0x112 { > Abbrev: 0x2 > Tag: DW_TAG_subprogram > DW_IDX_die_offset: 0x0

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-30 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: We don't have `pexpect` either; instead the tests that require it are disabled. Our build is as hermetic as possible; even if the package were available in the Python on the bots, we wouldn't be able to use it, since we don't make use of the Python on the bots, for the most

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
@@ -320,10 +320,13 @@ class SBCommandInterpreter { /// Returns a list of handled commands, output and error. Each element in /// the list is a dictionary with the following keys/values: - /// - "command" (string): The command that was executed. + /// - "command" (string)

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics( global_stats.try_emplace("modules", std::move(json_modules)); global_stats.try_emplace("memory", std::move(json_memory)); global_stats.try_emplace("commands", std::move(cmd_stats)); + +// Wh

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-30 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 1/9] Add resolvedCommand to transcript, add transcript to statistics d

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: Test llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py is failing on Windows due adding a carriage return character at the end of line. Original PR is #93836. Test Plan: llvm-lit

[Lldb-commits] [lldb] [lldb][test] Fix failing test TestAddressRange.py (PR #93871)

2024-05-30 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/93871 Summary: Test llvm-project/lldb/test/API/python_api/address_range/TestAddressRange.py is failing on Windows due adding a carriage return character at the end of line. Original PR is #93836. Test Plan: llvm-lit -

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: GreenDragon now has `packaging` and based on David's message, the Linaro bots do as well. @labath Does your ✅ mean the [debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package installed? @mysterymath Can you install this package on the Fuchia bots? I as

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-30 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: > One easy question would be: do you/your users use -fdebug-types-section? If > so, that'd probably explain what you were seeing & you could add some test > coverage for that wherever you like (in lldb, presumably, maybe in bolt too). > But if you/they don't, then it's unclear

[Lldb-commits] [lldb] [lldb][test] Add flags useful for remote cross-platform testing to dotest.py (PR #93800)

2024-05-30 Thread Pavel Labath via lldb-commits
labath wrote: It might be better to split this up per flag. For example, I don't see any issues with the --make flag, but I would like to understand more about why you need the --os flag (like, how it differs/why can't that be deduced from the platform name?) The sysroot arg is probably also f

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-30 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,142 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] 48175a5 - [lldb] Add SBAddressRange and SBAddressRangeList to SB API (#93836)

2024-05-30 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-30T10:38:21-07:00 New Revision: 48175a5d9f62f0586c04e5a742dafa5e1943f19c URL: https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c DIFF: https://github.com/llvm/llvm-project/commit/48175a5d9f62f0586c04e5a742dafa5e1943f19c.diff LO

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/93836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/93836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-30 Thread via lldb-commits
jimingham wrote: It's been a long time since I've looked at this code, but the change to return a 0 value rather than an error seems consistent at least. Was there no way to test this? https://github.com/llvm/llvm-project/pull/93548 ___ lldb-commits

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-05-30 Thread John McCall via lldb-commits
rjmccall wrote: I agree with Eli. We should trust external record layout to the extent that it generates a valid layout, but if it generates something with overlapping fields, or that runs outside the claimed bounds of the type, we'll just end up crashing in IRGen. I assume those things are

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: One easy question would be: do you/your users use -fdebug-types-section? If so, that'd probably explain what you were seeing & you could add some test coverage for that wherever you like (in lldb, presumably, maybe in bolt too). But if you/they don't, then it's unclear where t

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/93839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3d9d485 - [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (#93839)

2024-05-30 Thread via lldb-commits
Author: Zequan Wu Date: 2024-05-30T13:05:29-04:00 New Revision: 3d9d48523977af3590f7dd0edfd258454cb9e9cf URL: https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf DIFF: https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf.diff LOG

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-30 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: Still would be nice to have a small repro to make sure clang, and BOLT, now does the right thing. https://github.com/llvm/llvm-project/pull/91808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/93839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/93839 >From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 30 May 2024 11:36:10 -0400 Subject: [PATCH 1/4] [lldb][DWARF] Do not differentiate DW_TAG_class_type and DW_TAG

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/93712 >From 4666a6a6470fc91ed17a9e60624a005dc97c4531 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 29 May 2024 10:36:47 -0700 Subject: [PATCH 1/2] [lldb] Use packaging module instead of pkg_resources

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-05-30 Thread Eli Friedman via lldb-commits
efriedma-quic wrote: I'm skeptical it's correct to skip all the assertions like this; the assertions are there to ensure the layout of the LLVM IR type matches the layout provided by the RecordLayout. If the LLVM IR layout is wrong, address-related computations will be wrong, and ultimately y

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-30 Thread Pavel Labath via lldb-commits
labath wrote: What do the failures look like? I tried to force -pie on some of the tests that you modified, and I couldn't get them to fail. Is this somehow specific to remote execution? https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-30 Thread Jonas Devlieghere via lldb-commits
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view): # Windows SDK version numbers consist of 4 dotted components, so we # have to use LooseVersion, as StrictVersion supports 3 or fewer. JDevlieghere wrote: No, it do

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Lets do the cleanup of `IsClassOrStruct` as a follow-up since there seem quite a few places that could benefit from it https://github.com/llvm/llvm-project/pull/93839 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { felipepiovezan wrote: Yeah, we definitely need to clean all of these up. There might be one inside ll

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/93839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { Michael137 wrote: There's also ``` /// Returns true if `tag` is a class_type of structure_type tag.

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 16a5fd3fdb91ffb39b97dbd3a7e9346ba406360d e7fc16ec5f31693191188b3b95728c4320465923 --

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-05-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: Could probably adjust the assertions to be `assert (debug || whatever)` rather than `if (!debug) assert(whatever)`. My understanding/expectation was that these assertions would be removed entirely - that whatever generated the AST should just be trusted, whether it's the debu

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/93839 >From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 30 May 2024 11:36:10 -0400 Subject: [PATCH 1/3] [lldb][DWARF] Do not differentiate DW_TAG_class_type and DW_TAG

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -2232,6 +2232,10 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, // For objective C we don't start the definition when the class is // created. TypeSystemClang::StartTagDeclarationDefinition(clang_type); +} else { + assert( +

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { ZequanWu wrote: Yeah, we can probably do it in a different change. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, // For objective C we don't start the definition when the class is // created. TypeSystemClang::StartTagDeclarationDefinition(clang_type); +} else if (!clang_type.IsB

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/93839 >From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 30 May 2024 11:36:10 -0400 Subject: [PATCH 1/2] [lldb][DWARF] Do not differentiate DW_TAG_class_type and DW_TAG

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { Michael137 wrote: Are there more tag equality checks around LLDB that could benefit from re-using th

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, // For objective C we don't start the definition when the class is // created. TypeSystemClang::StartTagDeclarationDefinition(clang_type); +} else if (!clang_type.IsB

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, // For objective C we don't start the definition when the class is // created. TypeSystemClang::StartTagDeclarationDefinition(clang_type); +} else if (!clang_type.IsB

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/93839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die, // For objective C we don't start the definition when the class is // created. TypeSystemClang::StartTagDeclarationDefinition(clang_type); +} else if (!clang_type.IsB

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { ZequanWu wrote: It's here: https://github.com/llvm/llvm-project/blob/ed35a92c404650b15a79ff38bcaff41

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { Michael137 wrote: Ah yes in `SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext` we have the sam

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Michael Buch via lldb-commits
@@ -13,12 +13,18 @@ using namespace lldb_private::dwarf; using namespace lldb_private::plugin::dwarf; +static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) { Michael137 wrote: I think we have this function somewhere already. Might be worth checking (possibly

[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-30 Thread Pavel Labath via lldb-commits
@@ -61,8 +61,14 @@ def test_session_save(self): self.assertFalse(res.Succeeded()) raw += self.raw_transcript_builder(cmd, res) -tf = tempfile.NamedTemporaryFile() -output_file = tf.name +fd, output_file = tempfile.mkstemp() -

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-30 Thread Zequan Wu via lldb-commits
ZequanWu wrote: For this specific case, we could fix it by making `DW_TAG_structure_type` equals to `DW_TAG_class_type` in the `UniqueDWARFASTTypeList::Find`. There's few things I noticed with this: 1. If `DW_TAG_structure_type` and `DW_TAG_class_type` are interchangeable, then this compariso

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This fixes https://github.com/llvm/llvm-project/pull/92328#issuecomment-2139339444. This contains two fixes: 1. Do not differentiate `DW_TAG_class_type` and `DW_TAG_structure_type` in `UniqueDWARFASTTypeList`,

[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemotePlatformFile test running on a remote target (PR #93832)

2024-05-30 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/93832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b62ba7f - [lldb] Fixed the TestGdbRemotePlatformFile test running on a remote target (#93832)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:57:16+04:00 New Revision: b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416 URL: https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416 DIFF: https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416.dif

[Lldb-commits] [lldb] [lldb][DWARF] Fix adding children to clang type that hasn't started definition. (PR #93839)

2024-05-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/93839 This fixes https://github.com/llvm/llvm-project/pull/92328#issuecomment-2139339444. This contains two fixes: 1. Do not differentiate `DW_TAG_class_type` and `DW_TAG_structure_type` in `UniqueDWARFASTTypeList`,

[Lldb-commits] [lldb] 59e2a6b - [lldb] Fixed the TestDebuggerAPI test running on a remote target (#93829)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:56:46+04:00 New Revision: 59e2a6b08f3e40afea87da3838ba69e1e15b6672 URL: https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672 DIFF: https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672.dif

[Lldb-commits] [lldb] [lldb] Fixed the TestDebuggerAPI test running on a remote target (PR #93829)

2024-05-30 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/93829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/93825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] facb767 - [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (#93825)

2024-05-30 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-30T19:56:04+04:00 New Revision: facb767e5b78a024d70585b24254c769473b6b54 URL: https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54 DIFF: https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54.dif

[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemotePlatformFile test running on a remote target (PR #93832)

2024-05-30 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a2bcb93 - [lldb] Attempt to fix TestCompletion on macos

2024-05-30 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2024-05-30T15:28:13Z New Revision: a2bcb932f3130c3c18ceb06872da9002f6845c4b URL: https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b DIFF: https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b.diff LOG:

[Lldb-commits] [lldb] [lldb] Fixed the TestDebuggerAPI test running on a remote target (PR #93829)

2024-05-30 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Can confirm that tests pass on my mac now https://github.com/llvm/llvm-project/pull/93836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: This adds new SB API calls and classes to allow a user of the SB API to obtain an address range from SBFunction and SBBlock. This is a second attempt to land the reverted PR #92014. Test Plan: llvm-lit

[Lldb-commits] [lldb] [lldb] Add AddressRange to SB API (PR #93836)

2024-05-30 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/93836 Summary: This adds new SB API calls and classes to allow a user of the SB API to obtain an address range from SBFunction and SBBlock. This is a second attempt to land the reverted PR #92014. Test Plan: llvm-lit

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-30 Thread Pavel Labath via lldb-commits
labath wrote: > Mind taking a look @labath ? I think I know how to fix this, just a sec. https://github.com/llvm/llvm-project/pull/93458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

  1   2   >