[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531992. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h lldb/include/lldb/U

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG07b9e6ed0db2: [lldb] Fix handling of cfi_restore in the unwinder (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/ https://revi

[Lldb-commits] [lldb] 07b9e6e - [lldb] Fix handling of cfi_restore in the unwinder

Author: Jaroslav Sevcik Date: 2023-06-16T08:01:29+02:00 New Revision: 07b9e6ed0db206912b99c153a6bcfcb41f792cc5 URL: https://github.com/llvm/llvm-project/commit/07b9e6ed0db206912b99c153a6bcfcb41f792cc5 DIFF: https://github.com/llvm/llvm-project/commit/07b9e6ed0db206912b99c153a6bcfcb41f792cc5.dif

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531990. splhack added a comment. fixed typo and rebase onto D153102 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/s

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. D153102 should fix the last test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 ___ lldb-c

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

splhack created this revision. splhack added reviewers: clayborg, labath, bulbazord, yinghuitan, JDevlieghere, leonardchan. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscr

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin updated this revision to Diff 531987. jarin added a comment. Added a comment explaining that we are restoring the caller's value of the register. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/ https://reviews.llvm.org/D153043 Files: lldb/source/Symbol/DWARFCallFrame

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. Verified D153091 fixed TerminalTest failures. from `Failed Tests (13)` https://lab.llvm.org/buildbot/#/builders/96/builds/40769 to `Failed Tests (1)` https://lab.llvm.org/buildbot/#/builders/96/builds/40781 will submit a diff to fix th

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG75e93ec72073: [lldb][TerminalTest] Fix assertion failure (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153091/new/ https://reviews.ll

[Lldb-commits] [lldb] 75e93ec - [lldb][TerminalTest] Fix assertion failure

Author: Kazuki Sakamoto Date: 2023-06-15T21:24:40-07:00 New Revision: 75e93ec720739291640005681f062b0e1e8e0f53 URL: https://github.com/llvm/llvm-project/commit/75e93ec720739291640005681f062b0e1e8e0f53 DIFF: https://github.com/llvm/llvm-project/commit/75e93ec720739291640005681f062b0e1e8e0f53.dif

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153091/new/ https://reviews.llvm.org/D153091 ___

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531974. splhack added a comment. Added eFileKindInvalid with assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileReso

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1336 + // "zip_path!/so_path". Resolve the zip file path, .so file offset and size. + ZipFileResolver::FileKind file_kind; + std::string file_path; ---

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531969. splhack added a comment. Rename `ResolveBionicPath` to `ResolveSharedLibraryPath`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

russelltg added a comment. Thanks for the reviews and approval. I don't have git access so if someone could push this that'd be fantastic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153060/new/ https://reviews.llvm.org/D153060

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @leonardchan I think D153091 will fix the abort (`-6` should be `SIGABRT`), therefore it should be the assertion check of re-initialization in `FileSystem::Instance`. Is there a way to run the Linux builder with D153091

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

splhack created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152712 replaced `llvm::sys::RetryAfterSignal(

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Big fan of this kind of cleanup. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/new/

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

kastiglione created this revision. kastiglione added reviewers: bulbazord, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove `virtual` from `ValueObject` functions that aren't overridde

[Lldb-commits] [lldb] 538df1d - lldb [NFC] Add logging to Process when address masks are updated

Author: Jason Molenda Date: 2023-06-15T17:38:45-07:00 New Revision: 538df1d8a2428d06de7f26c859969ddec14928c1 URL: https://github.com/llvm/llvm-project/commit/538df1d8a2428d06de7f26c859969ddec14928c1 DIFF: https://github.com/llvm/llvm-project/commit/538df1d8a2428d06de7f26c859969ddec14928c1.diff

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531954. splhack added a comment. added non zip .so file (normal file) case to the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. found symbolicated stack trace in https://lab.llvm.org/buildbot/#/builders/96/builds/40769/steps/6/logs/stdio TerminalTest does not instantiate FileSystem. now preparing to submit a diff to fix it. #0 0xcc46d6d4 llvm::sys::PrintStackTrace(llvm::raw_ostream&,

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531950. splhack added a comment. add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/uni

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @leonardchan yes, I'm looking into. -6 is ENXIO? Is it using POSIX code path? Is it possible to see symbolicated stack trace of the crash? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

leonardchan added a comment. Hi. I think this is leading to the lldb test failures we're seeing on our linux builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778187770933863505/+/u/lldb/test/stdout?format=raw): FAIL: lldb-unit :: Host/./HostTe

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

clayborg added a comment. LGTM. Anyone else have any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1336 + // "zip_path!/so_path". Resolve the zip file path, .so file offset and size. + ZipFileResolver::FileKind file_kind; + std::string file_path; --

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I can see why the existing code is written as it is, given the dwarf spec for DW_CFA_restore: "The DW_CFA_restore instruction takes a single operand (encoded with the opcode) that

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

clayborg added inline comments. Comment at: lldb/scripts/generate-project.py:21 +def generate_c_header(directory: str, index: int) -> None: +header_path = f"{directory}/obj{index}.h" +with open(header_path, "w") as f: kastiglione wrote: > kastiglione wrot

[Lldb-commits] [PATCH] D153079: Add an llvm::report_fatal_error for when the darwin kernel says we've finished an insn-step but the thread doesn't think it was insn-stepping

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a8e2538afc1: Add a fatal error for debug builds when disagreement about stepping (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 6a8e253 - Add a fatal error for debug builds when disagreement about stepping

Author: Jason Molenda Date: 2023-06-15T15:41:37-07:00 New Revision: 6a8e2538afc10e6b7a321fd38bf5faf550518f2a URL: https://github.com/llvm/llvm-project/commit/6a8e2538afc10e6b7a321fd38bf5faf550518f2a DIFF: https://github.com/llvm/llvm-project/commit/6a8e2538afc10e6b7a321fd38bf5faf550518f2a.diff

[Lldb-commits] [PATCH] D153079: Add an llvm::report_fatal_error for when the darwin kernel says we've finished an insn-step but the thread doesn't think it was insn-stepping

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. Let's see if we can get this to actually trap the concurrent test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153079/new/

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe29cc5216a86: [lldb][NFCI] Remove use of ConstString from IOHandler (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https

[Lldb-commits] [lldb] e29cc52 - [lldb][NFCI] Remove use of ConstString from IOHandler

Author: Alex Langford Date: 2023-06-15T14:57:20-07:00 New Revision: e29cc5216a8608b026e390b69022878b2ec3071a URL: https://github.com/llvm/llvm-project/commit/e29cc5216a8608b026e390b69022878b2ec3071a DIFF: https://github.com/llvm/llvm-project/commit/e29cc5216a8608b026e390b69022878b2ec3071a.diff

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack added a comment. @clayborg > platform.plugin.remote-android.package-name sure, sounds good. will update. @bulbazord > What happens if you do run-as with an empty package name? $ adb shell "run-as '' ls"; echo $? run-as: unknown package: 1 which is the same as when specify non

[Lldb-commits] [PATCH] D153079: Add an llvm::report_fatal_error for when the darwin kernel says we've finished an insn-step but the thread doesn't think it was insn-stepping

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We have some failures on an arm6

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fb919a1154a: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 8fb919a - [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

Author: Alex Langford Date: 2023-06-15T14:46:46-07:00 New Revision: 8fb919a1154a593fdf01e759ece7904afc73f687 URL: https://github.com/llvm/llvm-project/commit/8fb919a1154a593fdf01e759ece7904afc73f687 DIFF: https://github.com/llvm/llvm-project/commit/8fb919a1154a593fdf01e759ece7904afc73f687.diff

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } bulbazord wrote: > `GetAdbClient()` cal

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord added a comment. If nobody else has any comments, I plan on landing this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 ___ lldb-commits ma

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4d710e41059: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15271

[Lldb-commits] [lldb] b4d710e - [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

Author: Kazuki Sakamoto Date: 2023-06-15T14:24:14-07:00 New Revision: b4d710e410595905c6c1d40cd5d257dfa9143bbe URL: https://github.com/llvm/llvm-project/commit/b4d710e410595905c6c1d40cd5d257dfa9143bbe DIFF: https://github.com/llvm/llvm-project/commit/b4d710e410595905c6c1d40cd5d257dfa9143bbe.dif

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, mib wrote: > mib wrote: > > T

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

kusmour added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

jloser added a comment. Excited to see this come together! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153073/new/ https://reviews.llvm.org/D153073 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. LGTM, but deferring to code owners for full approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153073/new/ https://reviews.llvm.org/D1530

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

bulbazord added a comment. What happens if you do `run-as` with an empty package name? I'm also not tied to the name `"platform.plugin.remote-android.run-as"` if others don't like it. `platform.plugin.remote-android.package-name` is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The new language Mojo recently r

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

mib added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, mib wrote: > This function name s

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

clayborg added a comment. I am wondering if the current proposed setting name "platform.plugin.remote-android.run-as" should actually be "platform.plugin.remote-android. package-name" to be a bit more clear. Not sure if we can use the package name in other places? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

mib added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec &file_spec, FileKind &file_kind, +std::string &file_path, This function name sounds like th

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } `GetAdbClient()` calls `make_unique`

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very easy fix for this as suggested in code changes and this will be good to go Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.h:73 + typed

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for reworking it! You may want to wait a little bit before landing so others have some time to look over it, but I don't see anything that should prevent this from going in. Rep

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah that's an unintended bottleneck. If you're debugging to debugserver on a darwin system, it will tell lldb it uses a 128k max packet size, so larger read requests are still be

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

russelltg created this revision. Herald added a project: All. russelltg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://github.com/llvm/llvm-project/issues/62750 I setup a simple test with a large .so (~100MiB) that was only presen

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:76 + + compiler_type = scratch_ts_sp->GetTypeForIdentifier(g_lldb_autogen_nspair); + aprantl wrote: > why not directly pass in `"__lldb_autogen_nspair"` here? It's u

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:76 + + compiler_type = scratch_ts_sp->GetTypeForIdentifier(g_lldb_autogen_nspair); + w

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b0b244401a: [lldb] Introduce DynamicRegisterInfo::CreateFromDict (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https:

[Lldb-commits] [lldb] 35b0b24 - [lldb] Introduce DynamicRegisterInfo::CreateFromDict

Author: Alex Langford Date: 2023-06-15T10:51:17-07:00 New Revision: 35b0b244401aad5ca3a16c9e4d97a5892ca7592b URL: https://github.com/llvm/llvm-project/commit/35b0b244401aad5ca3a16c9e4d97a5892ca7592b DIFF: https://github.com/llvm/llvm-project/commit/35b0b244401aad5ca3a16c9e4d97a5892ca7592b.diff

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: aprantl, Michael137, augusto2112, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method just takes its ConstString parame

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jarin requested review of this revision. Herald added a subscriber: lldb-commits. Currently, lldb's unwinder ignores cfi_restore opcodes f

[Lldb-commits] [lldb] 74113a4 - [lldb] Fix build error after 7bca6f45

Author: Jan Svoboda Date: 2023-06-15T11:59:47+02:00 New Revision: 74113a4150d683c9478331ae91018ab9092a634d URL: https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d DIFF: https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d.diff L

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286 src = (uint8_t *)GetMTEControl() + offset; + } else if (IsTLS(reg)) { +error = ReadTLSTPIDR(); --

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good to me, just a minor nit above. I have not run the test myself. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

baoyuxu added a comment. @kasper81, I just tried this patch with lastest repo in github and can bulid patched lldb. But when I try to remote debug with riscv qemu, it still get all 1s frame. Could you please see what I'm doing wrong？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

DavidSpickett added a comment. TIL what gcore is. One can save a corefile from within lldb too, I assume you've checked what that does (and with this change, it wouldn't matter either way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/