clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Very easy fix for this as suggested in code changes and this will be good to go ================ Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.h:73 + typedef std::unique_ptr<AdbClient> AdbClientSP; + virtual AdbClientSP GetAdbClient(); ---------------- Using the "SP" suffix is for std::shared_ptr, "UP" is for unique pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
