[Lldb-commits] [lldb] d920ab4 - [lldb] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T23:32:18-08:00 New Revision: d920ab4a8bf26d3201e08460bea542fcd5ea URL: https://github.com/llvm/llvm-project/commit/d920ab4a8bf26d3201e08460bea542fcd5ea DIFF: https://github.com/llvm/llvm-project/commit/d920ab4a8bf26d3201e08460bea542fcd5ea.diff L

[Lldb-commits] [lldb] 529ca5a - [lldb] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T23:18:15-08:00 New Revision: 529ca5ad07d5b872b7c0a8e8d27ce559a5bde4f7 URL: https://github.com/llvm/llvm-project/commit/529ca5ad07d5b872b7c0a8e8d27ce559a5bde4f7 DIFF: https://github.com/llvm/llvm-project/commit/529ca5ad07d5b872b7c0a8e8d27ce559a5bde4f7.diff L

[Lldb-commits] [lldb] 1d0ba31 - [lldb] Use std::nullopt instead of llvm::None (NFC)

Author: Kazu Hirata Date: 2022-12-05T22:43:53-08:00 New Revision: 1d0ba311d88d02caa6b5e1607047fdb6c909b705 URL: https://github.com/llvm/llvm-project/commit/1d0ba311d88d02caa6b5e1607047fdb6c909b705 DIFF: https://github.com/llvm/llvm-project/commit/1d0ba311d88d02caa6b5e1607047fdb6c909b705.diff L

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

andrewrk added a comment. In D139102#3963388 , @DavidSpickett wrote: > > @andrewrk I seem to remember that Zig uses these files for generating > compiler options of its own? A basic search didn't show anything but we'd > better check if you're usin

[Lldb-commits] [lldb] d5c6dc8 - [lldb] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-05T20:54:05-08:00 New Revision: d5c6dc8f0269067f39c6ce6f37639dd6d8879582 URL: https://github.com/llvm/llvm-project/commit/d5c6dc8f0269067f39c6ce6f37639dd6d8879582 DIFF: https://github.com/llvm/llvm-project/commit/d5c6dc8f0269067f39c6ce6f37639dd6d8879582.diff L

[Lldb-commits] [lldb] 9ba308f - Remove "using llvm::None; " in *.cpp

Author: Kazu Hirata Date: 2022-12-05T20:39:10-08:00 New Revision: 9ba308f71c92a228120f084ba0fa740b4c61247f URL: https://github.com/llvm/llvm-project/commit/9ba308f71c92a228120f084ba0fa740b4c61247f DIFF: https://github.com/llvm/llvm-project/commit/9ba308f71c92a228120f084ba0fa740b4c61247f.diff L

[Lldb-commits] [lldb] a220026 - [lldb][Test] TestRerunAndExpr.py: skip on Windows

Author: Michael Buch Date: 2022-12-06T02:16:31Z New Revision: a22002635ddfa10033ed56c8308a4d5bf56979dd URL: https://github.com/llvm/llvm-project/commit/a22002635ddfa10033ed56c8308a4d5bf56979dd DIFF: https://github.com/llvm/llvm-project/commit/a22002635ddfa10033ed56c8308a4d5bf56979dd.diff LOG:

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. Don't have a Windows setup to confidently test this on right now but will see if I can get one going this week. Skipped it for now. But the problem is really what Pavel was alluding to. Rebuilding the binary doesn't trigger the module unload in the same way it does o

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:115 +private: + uint64_t Fields[2]; + dblaikie wrote: > How come this became an array? Rather than keeping it as two named fields? So I can provide a generic s

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. In D139379#3972871 , @dblaikie wrote: > Perhaps the change to use accessors could be removed, now that you've used it > to find all the places that needed to be fixed up? (like just using it for > cleanup/temporary purposes, wi

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

dblaikie added a comment. Perhaps the change to use accessors could be removed, now that you've used it to find all the places that needed to be fixed up? (like just using it for cleanup/temporary purposes, without needing to commit that API change?) Comment at: llvm/include/

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480299. ayermolo added a comment. update s/getLength()/getLength32() in DWP.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

lh03061238 updated this revision to Diff 480297. lh03061238 edited the summary of this revision. lh03061238 added a comment. (1) Use sort alphabetically in the following file lldb/source/Plugins/Instruction/CMakeLists.txt lldb/source/Plugins/Instruction/LoongArch/CMakeLists.txt lldb/tools/lldb-ser

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

stella.stamenova added a comment. Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480283. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

jasonmolenda updated this revision to Diff 480277. jasonmolenda added a comment. Update patch to use Jonas' suggested wording of the warning we will issue when the objc class scanner functions cannot run yet, to make it clearer that they will run later and to match the style of the other warning

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo created this revision. Herald added subscribers: mstorsjo, hoy, modimo, wenlei, arphaman, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. ayermolo requested review of this revision. Herald added subs

[Lldb-commits] [lldb] fe3103f - Increase search for kernel image from 32MB to 128MB

Author: Jason Molenda Date: 2022-12-05T15:11:43-08:00 New Revision: fe3103fa485f67b15efffd11d592a3341eb7bd57 URL: https://github.com/llvm/llvm-project/commit/fe3103fa485f67b15efffd11d592a3341eb7bd57 DIFF: https://github.com/llvm/llvm-project/commit/fe3103fa485f67b15efffd11d592a3341eb7bd57.diff

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fcc1840c31: [lldb-tests] Force system's libcxx on tests failing with debug symbols (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [lldb] b1fcc18 - [lldb-tests] Force system's libcxx on tests failing with debug symbols

Author: Felipe de Azevedo Piovezan Date: 2022-12-05T17:42:00-05:00 New Revision: b1fcc1840c312472cb9ccb8c4e5e02ca13b31113 URL: https://github.com/llvm/llvm-project/commit/b1fcc1840c312472cb9ccb8c4e5e02ca13b31113 DIFF: https://github.com/llvm/llvm-project/commit/b1fcc1840c312472cb9ccb8c4e5e02ca1

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 480249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/scripted/CMakeLists.txt lldb/source/Plugins/Platform/scripted/Scripte

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

mib updated this revision to Diff 480230. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 Files: lldb/include/lldb/Interpreter/ScriptedMetadata.h lldb

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed6311b1b7d: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with… (authored by akyrtzi). Re

[Lldb-commits] [lldb] 3ed6311 - [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

Author: Argyrios Kyrtzidis Date: 2022-12-05T13:43:36-08:00 New Revision: 3ed6311b1b7dfec44eb96327a1a4f5b712cc3884 URL: https://github.com/llvm/llvm-project/commit/3ed6311b1b7dfec44eb96327a1a4f5b712cc3884 DIFF: https://github.com/llvm/llvm-project/commit/3ed6311b1b7dfec44eb96327a1a4f5b712cc3884.

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:36 + + std::string GetClassName() const { return m_class_name; } + StructuredData::DictionarySP GetArgsSP() const { return m_args_sp; }

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:36 + + std::string GetClassName() const { return m_class_name; } + StructuredData::DictionarySP GetArgsSP() const { return m_args_sp; } Why return a copy? Can this

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139361/new/ https://reviews.llvm.org/D139361 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

bulbazord accepted this revision. bulbazord added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

jasonmolenda added a comment. In D139066#3971697 , @akyrtzi wrote: > I prefer my original version because: > > - `eSymbolContextLastItem` is not an appropriate name for collection of bits, > it should be named like `eSymbolContextReallyEverything` or som

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

fdeazeve updated this revision to Diff 480214. fdeazeve added a comment. Add FIXME comment with the same observation from the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139361/new/ https://reviews.llvm.org/D139361 Files: lldb

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for bearing with me. I think this is good now. One last suggestion I have is to turn the bools into an enum, so we can't accidentally mix their order up. Otherwise this LGTM! =

[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tests in this patch expose failures of LLDBs expression evaluator when a standard library is compiled with debug symbo

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

mib updated this revision to Diff 480209. mib marked an inline comment as done. mib added a comment. Update header guard CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 Files: lldb/include/lldb/Interpreter/ScriptedMetadata.h lldb/source/Pl

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi added a comment. I prefer my original version because: - `eSymbolContextLastItem` is not an appropriate name for collection of bits, it should be named like `eSymbolContextReallyEverything` or something, which then makes things a bit confusing due to having multiple "everything" enums.

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

jasonmolenda added a comment. In D139066#3971564 , @akyrtzi wrote: > In D139066#3964435 , @akyrtzi wrote: > >> In D139066#3964353 , @jasonmolenda >> wrote: >> >>> FWIW I

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 480164. mib added a comment. Update `ScriptedMetadata` header location CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/script

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:9-10 + +#ifndef LLDB_SOURCE_PLUGINS_SCRIPTED_METADATA_H +#define LLDB_SOURCE_PLUGINS_SCRIPTED_METADATA_H + This should be `LLDB_INTERPRETER_SCRIPTEDMETADATA_H` to be con

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib updated this revision to Diff 480160. mib added a comment. Update `ScriptedMetadata` header location CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBDebugger.h lldb/

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi added a comment. In D139066#3964435 , @akyrtzi wrote: > In D139066#3964353 , @jasonmolenda > wrote: > >> FWIW I think the only change needed to the original patch is to keep using >> `#define RESOLVED_FR

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. @clayborg https://reviews.llvm.org/D139332 is the platform Android options version. I'm happy with either of this connect url version https://reviews.llvm.org/D138164 or platform options version https://reviews.llvm.org/D139332. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

mib updated this revision to Diff 480157. mib retitled this revision from "[lldb/Utility] Make ScriptedProcessInfo more generic" to "[lldb/Interpreter] Make ScriptedProcessInfo more generic". mib edited the summary of this revision. mib added a comment. Move class from `Utility` to `Interpreter`

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. Handled in https://reviews.llvm.org/rGe31160155e48 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] e311601 - [lldb][Test] TestRerunAndExprDylib.py on Linux: dlclose solib to force destruction module

Author: Michael Buch Date: 2022-12-05T18:14:26Z New Revision: e31160155e484414db9177806ae9f0840c985b49 URL: https://github.com/llvm/llvm-project/commit/e31160155e484414db9177806ae9f0840c985b49 DIFF: https://github.com/llvm/llvm-project/commit/e31160155e484414db9177806ae9f0840c985b49.diff LOG:

[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic

mib added inline comments. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:12-14 +#include "lldb/Host/Host.h" +#include "lldb/Host/ProcessLaunchInfo.h" +#include "lldb/Interpreter/OptionGroupPythonClassWithDict.h" JDevlieghere wrote: > These are layering

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 _

[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:12-14 +#include "lldb/Host/Host.h" +#include "lldb/Host/ProcessLaunchInfo.h" +#include "lld

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. Argh broke linux again. This time it's a lack of `dlclose` to make LLDB destroy the module the way I want it to. About to push a fix... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1edcf7d14c1: Reland "[lldb][Target] Flush the scratch TypeSystem when owning lldb_private… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] e1edcf7 - Reland "[lldb][Target] Flush the scratch TypeSystem when owning lldb_private::Module gets unloaded"

Author: Michael Buch Date: 2022-12-05T16:57:42Z New Revision: e1edcf7d14c126b9ebd2a77fcd9041d056cce64a URL: https://github.com/llvm/llvm-project/commit/e1edcf7d14c126b9ebd2a77fcd9041d056cce64a DIFF: https://github.com/llvm/llvm-project/commit/e1edcf7d14c126b9ebd2a77fcd9041d056cce64a.diff LOG:

[Lldb-commits] [PATCH] D139332: [LLDB][Android] Add platform options

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 480112. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a subs

[Lldb-commits] [PATCH] D139294: [LLDB][RISCV] Add RV64F instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d7f43f9eaf3: [LLDB][RISCV] Add RV64F instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] 2d7f43f - [LLDB][RISCV] Add RV64F instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-12-05T22:54:08+08:00 New Revision: 2d7f43f9eaf36cb8ab976a24544099f496aba248 URL: https://github.com/llvm/llvm-project/commit/2d7f43f9eaf36cb8ab976a24544099f496aba248 DIFF: https://github.com/llvm/llvm-project/commit/2d7f43f9eaf36cb8ab976a24544099f496aba248.diff LOG: [

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added inline comments. Comment at: clang/test/Frontend/sarif-reason.cpp:15 +void g() { + f1<0>(); // expected-error{{no matching function for call to 'f1'}} + f1(); // expected-error{{no matching function for call to 'f1'}} cjdb wrote: > erichkeane w

[Lldb-commits] [PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480054. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

lh03061238 added a comment. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:66 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *success); + bool WritePC(lldb::addr_t pc);

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. In D138618#3967933 , @ayermolo wrote: > How would you like me to break up this diff? Is factoring OSO into another > diff enough, or do you want more granular one? Hard to say without seeing what the patches would look like, but

[Lldb-commits] [lldb] 811ad24 - [lldb][Test] TestModulesCompileError.py: fix expected error string

Author: Michael Buch Date: 2022-12-05T10:50:16Z New Revision: 811ad246ac7b46d85171577333be3fa4a9f04dbd URL: https://github.com/llvm/llvm-project/commit/811ad246ac7b46d85171577333be3fa4a9f04dbd DIFF: https://github.com/llvm/llvm-project/commit/811ad246ac7b46d85171577333be3fa4a9f04dbd.diff LOG:

[Lldb-commits] [PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480025. paperchalice added reviewers: tstellar, MaskRay. paperchalice added a comment. Herald added a subscriber: StephenFan. Use genex `$` due to `CMAKE_CFG_INTDIR` is deprecated since cmake 3.21. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

DavidSpickett added a comment. And thanks for bringing the test up to date in general! (that test is less checking the disassembler, more a reference of what lldb should be capable of, though it has found some bugs) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > If some script _is_ manually parsing the .def, it ought to be easy enough to > update it to read the .cpp instead (it probably shouldn't do either). True. Hopefully the target