fdeazeve updated this revision to Diff 480214.
fdeazeve added a comment.

Add FIXME comment with the same observation from the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139361/new/

https://reviews.llvm.org/D139361

Files:
  
lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
  
lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
  
lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile


Index: 
lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
===================================================================
--- 
lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
+++ 
lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: 
lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
===================================================================
--- 
lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
+++ 
lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: 
lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
===================================================================
--- 
lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
+++ 
lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules


Index: lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits]... Felipe de Azevedo Piovezan via Phabricator via lldb-commits
    • [Lldb-com... Felipe de Azevedo Piovezan via Phabricator via lldb-commits
    • [Lldb-com... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-com... Felipe de Azevedo Piovezan via Phabricator via lldb-commits

Reply via email to