[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham added a comment. In D129814#3655750 , @jasonmolenda wrote: > In D129814#3654368 , @labath wrote: > >> In D129814#3654276 , @jasonmolenda >> wrote: >> >>> In D129

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129338/new/ https://reviews.llvm.org/D129338 ___

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

jingham updated this revision to Diff 445145. jingham added a comment. I added the pathname to the "invalid directory" output, but when the test passes an invalid directory we still execute the "invalid pathname" branch but not the "invalid directory" branch. I don't know enough about the llvm

[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

jingham added a comment. It might also be good to document that CompareTo doesn't try to calculate, and will never return eFrameCompareSameParent. A StackID can't do that because it doesn't really know how to unwind from itself, so that's a pretty sensible restriction, but it makes it easier t

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht added a comment. In D129898#3656268 , @JDevlieghere wrote: > Seems like there's another instance of this in > `TestForwardDeclFromStdModule.py`. Added that one too. There is also this one: https://github.com/llvm/llvm-project/blob/09531ede6

[Lldb-commits] [PATCH] D129900: Update the __1 in TestForwardDeclFromStdModule.py

rupprecht abandoned this revision. rupprecht added a comment. Herald added a subscriber: JDevlieghere. Meant to update D129898 instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129900/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09531ede6d56: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop (authored by mgorny). Herald added a project: LLDB. Changed prior to co

[Lldb-commits] [lldb] 09531ed - [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

Author: Michał Górny Date: 2022-07-15T21:50:39+02:00 New Revision: 09531ede6d5622da68941902072dbca517d31318 URL: https://github.com/llvm/llvm-project/commit/09531ede6d5622da68941902072dbca517d31318 DIFF: https://github.com/llvm/llvm-project/commit/09531ede6d5622da68941902072dbca517d31318.diff

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht updated this revision to Diff 445115. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129898/new/ https://reviews.llvm.org/D129898 Files: lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdM

[Lldb-commits] [PATCH] D129900: Update the __1 in TestForwardDeclFromStdModule.py

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D129898 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

JDevlieghere added a comment. Seems like there's another instance of this in `TestForwardDeclFromStdModule.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129898/new/ https://reviews.llvm.org/D129898 ___

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The libc++ data formatter for `std::shared_ptr` allows any namespace, but the test asserts that it must be the default

[Lldb-commits] [lldb] fc92f11 - [lldb] [test] Skip test_leave_nonstop on Windows

Author: Michał Górny Date: 2022-07-15T21:48:03+02:00 New Revision: fc92f11441894e65f76a856cfc55a03e0df726a6 URL: https://github.com/llvm/llvm-project/commit/fc92f11441894e65f76a856cfc55a03e0df726a6 DIFF: https://github.com/llvm/llvm-project/commit/fc92f11441894e65f76a856cfc55a03e0df726a6.diff

[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

jingham added a comment. Herald added a project: All. IIUC, the crux of this change is having the comparison able to return eFrameCompareUnknown when the `<` operator was returning "less than", and the handling of Unknown in the various thread plans. Is that right? There's so much formal chan

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu added a comment. In D129807#3654447 , @DavidSpickett wrote: > Is this fixing a specific situation and if so, can a test be written for it? > I'm sure we have existing tests you can adapt. It fixed the issue

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu updated this revision to Diff 445081. zequanwu added a reviewer: rnk. zequanwu added a comment. add testscase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129807/new/ https://reviews.llvm.org/D129807 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp lldb/source

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc732afa2c2e8: [lldb] [llgs] Fix disabling non-stop mode (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [lldb] c732afa - [lldb] [llgs] Fix disabling non-stop mode

Author: Michał Górny Date: 2022-07-15T20:16:49+02:00 New Revision: c732afa2c2e8bf4c3d068af180c1e9daa25b03c1 URL: https://github.com/llvm/llvm-project/commit/c732afa2c2e8bf4c3d068af180c1e9daa25b03c1 DIFF: https://github.com/llvm/llvm-project/commit/c732afa2c2e8bf4c3d068af180c1e9daa25b03c1.diff

[Lldb-commits] [lldb] 5d66597 - [lldb] [test] Skip test_stop_reason_while_running on Windows

Author: Michał Górny Date: 2022-07-15T20:14:55+02:00 New Revision: 5d6659739c4ed5f445dbdc5da499d84b5a8cebaa URL: https://github.com/llvm/llvm-project/commit/5d6659739c4ed5f445dbdc5da499d84b5a8cebaa DIFF: https://github.com/llvm/llvm-project/commit/5d6659739c4ed5f445dbdc5da499d84b5a8cebaa.diff

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham added a comment. In D129814#3654368 , @labath wrote: > In D129814#3654276 , @jasonmolenda > wrote: > >> In D129814#3654230 , @labath wrote: >> >>> Generally, this

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

labath added a comment. flake here: https://lab.llvm.org/buildbot/#/builders/68/builds/35932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128710/new/ https://reviews.llvm.org/D128710 ___ lldb-commits ma

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham added inline comments. Comment at: lldb/source/Target/StopInfo.cpp:805 + + m_step_over_wp_sp.reset(new ThreadPlanStepOverWatchpoint( + *(thread_sp.get()), shared_from_this(), wp_sp)); labath wrote: > This creates a shared pointer loop, does

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jingham updated this revision to Diff 445059. jingham added a comment. Address review comments. 1. Name changes and formatting 2. The ThreadPlan needs to keep the StopInfo alive but not vice versa. So I removed the sp to the StopInfo, and replaced it with a callback in the StopInfo that the th

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jasonmolenda added a comment. In D129814#3654368 , @labath wrote: > In D129814#3654276 , @jasonmolenda > wrote: > >> In D129814#3654230 , @labath wrote: >> >>> Generally,

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445039. Michael137 added a comment. - Add test for conditional breakpoints on lambda captures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include

[Lldb-commits] [lldb] ab9f1e8 - [lldb] [llgs] Fix `?` packet response for running threads

Author: Michał Górny Date: 2022-07-15T18:33:58+02:00 New Revision: ab9f1e88fd8a73a32914c18a52868d3a4b9e509e URL: https://github.com/llvm/llvm-project/commit/ab9f1e88fd8a73a32914c18a52868d3a4b9e509e DIFF: https://github.com/llvm/llvm-project/commit/ab9f1e88fd8a73a32914c18a52868d3a4b9e509e.diff

[Lldb-commits] [PATCH] D128879: [lldb] [llgs] Fix `?` packet response for running threads

This revision was automatically updated to reflect the committed changes. Closed by commit rGab9f1e88fd8a: [lldb] [llgs] Fix `?` packet response for running threads (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[lldb] 81e993f - [lldb] [test] Skip TestNonStop → test_stdio on Windows

Author: Michał Górny Date: 2022-07-15T18:33:19+02:00 New Revision: 81e993f08d6cd8d1658e3843594449b6fa622a4f URL: https://github.com/llvm/llvm-project/commit/81e993f08d6cd8d1658e3843594449b6fa622a4f DIFF: https://github.com/llvm/llvm-project/commit/81e993f08d6cd8d1658e3843594449b6fa622a4f.diff

[Lldb-commits] [PATCH] D128849: [lldb] [llgs] Send process output asynchronously in non-stop mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1903f358bcc7: [lldb] [llgs] Send process output asynchronously in non-stop mode (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] 1903f35 - [lldb] [llgs] Send process output asynchronously in non-stop mode

Author: Michał Górny Date: 2022-07-15T17:20:39+02:00 New Revision: 1903f358bcc74fd96c65f0d1deba577c63238c86 URL: https://github.com/llvm/llvm-project/commit/1903f358bcc74fd96c65f0d1deba577c63238c86 DIFF: https://github.com/llvm/llvm-project/commit/1903f358bcc74fd96c65f0d1deba577c63238c86.diff

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chrish_ericsson_atx added a comment. In D112374#3653967 , @JDevlieghere wrote: > I don't. I think reverting your change was well within the guidelines > outlined by LLVM's patch reversion policy: > https://llvm.org/docs/DeveloperPolicy.html#patch-rever

[Lldb-commits] [lldb] 5a6f1f3 - [lldb] [test] Skip new NonStop tests on Windows

Author: Michał Górny Date: 2022-07-15T16:02:47+02:00 New Revision: 5a6f1f3271720fffd9f82827f593737e1af7f833 URL: https://github.com/llvm/llvm-project/commit/5a6f1f3271720fffd9f82827f593737e1af7f833 DIFF: https://github.com/llvm/llvm-project/commit/5a6f1f3271720fffd9f82827f593737e1af7f833.diff

[Lldb-commits] [lldb] cd2e36e - [lldb][AArch64] Enable int128 test

Author: David Spickett Date: 2022-07-15T13:35:48Z New Revision: cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38 URL: https://github.com/llvm/llvm-project/commit/cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38 DIFF: https://github.com/llvm/llvm-project/commit/cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38.diff LOG

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. Thanks! The Arm/AArch64 Linux bots were green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129783/new/ https://reviews.llvm.org/D129783 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] eb43e43 - Reland "[lldb] [llgs] Fix multi-resume bugs with nonstop mode"

Author: Michał Górny Date: 2022-07-15T15:24:00+02:00 New Revision: eb43e43bb5b2d19e14309e120cb8e66136ae7c82 URL: https://github.com/llvm/llvm-project/commit/eb43e43bb5b2d19e14309e120cb8e66136ae7c82 DIFF: https://github.com/llvm/llvm-project/commit/eb43e43bb5b2d19e14309e120cb8e66136ae7c82.diff

[Lldb-commits] [lldb] 7a2b09b - Revert "[lldb] [llgs] Fix multi-resume bugs with nonstop mode"

Author: Michał Górny Date: 2022-07-15T13:43:34+02:00 New Revision: 7a2b09b4798dbd5ec69e934b595eab5afddf33c5 URL: https://github.com/llvm/llvm-project/commit/7a2b09b4798dbd5ec69e934b595eab5afddf33c5 DIFF: https://github.com/llvm/llvm-project/commit/7a2b09b4798dbd5ec69e934b595eab5afddf33c5.diff

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat added a comment. Relanded in https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 _

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat abandoned this revision. werat added a comment. I have relanded the patch with the fixed tests here -- https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129783/n

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8605da8758f: [lldb] [llgs] Fix multi-resume bugs with nonstop mode (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] f8605da - [lldb] [llgs] Fix multi-resume bugs with nonstop mode

Author: Michał Górny Date: 2022-07-15T13:01:39+02:00 New Revision: f8605da8758fbae16410e4ed5493a39429fd73ec URL: https://github.com/llvm/llvm-project/commit/f8605da8758fbae16410e4ed5493a39429fd73ec DIFF: https://github.com/llvm/llvm-project/commit/f8605da8758fbae16410e4ed5493a39429fd73ec.diff

[Lldb-commits] [lldb] 7d297de - Reland "[lldb] Add support for using integral const static data members in the expression evaluator"

Author: Andy Yankovsky Date: 2022-07-15T10:52:35Z New Revision: 7d297de95117e783bbfaecbba1f72fc55de05a30 URL: https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30 DIFF: https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30.diff LOG

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. > which disabled the test for both 32-bit and 64-bit That one also runs fine on Linux so probably just overly cautious. I see `lldb/test/API/commands/expression/rdar44436068/Test128BitsInteger.py` as well, that only disables Arm. Once your changes have passed the

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat added a comment. I didn't see the test failure on AArch64, so you're both probably right. I've searched the code for other uses of int128 and found a similar place, which disabled the test for both 32-bit and 64-bit -- https://github.com/llvm/llvm-project/blob/30c2406e270cc5dab8da813ce5c5

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. (in case you aren't familiar when we say "Arm" we mean 32 bit Arm and AArch64 refers to 64 bit, it's not always that way but for this purpose it is) I couldn't find a statement that AArch64 supports int128 but it will compile (https://godbolt.org/z/j5dqz4os4) and

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

DavidSpickett added a comment. Is this fixing a specific situation and if so, can a test be written for it? I'm sure we have existing tests you can adapt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129807/new/ https://reviews.llvm.org/D129807

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

DavidSpickett added inline comments. Comment at: lldb/source/Target/StopInfo.cpp:724 + m_watch_sp.reset(); +} +bool ShouldStop(Event *event_ptr) override { Blank line after this. Comment at: lldb/source/Target/StopInfo.cpp:748 +

[Lldb-commits] [PATCH] D129652: [lldb] [llgs] Convert m_debugged_processes into a map of structs

labath added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1058-1060 // Terminate the main loop only if vKill has not been used. // When running in non-stop mode, wait f

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

labath added a comment. In D129814#3654276 , @jasonmolenda wrote: > In D129814#3654230 , @labath wrote: > >> Generally, this makes sense to me, but I do have one question (not >> necessarily for Jim). These test

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks much better. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 ___ lldb-commits mai

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

labath added a comment. I find the aarch64 part surprising, and it seems that the aarch64 bot did not have a problem with this patch (https://lab.llvm.org/buildbot/#/builders/96/builds/26089). The arm part is expected, and most likely applies to all 32 bit architectures (but I think we only ha

[Lldb-commits] [lldb] 3c849d0 - Modernize Optional::{getValueOr, hasValue}

Author: Fangrui Song Date: 2022-07-15T01:20:39-07:00 New Revision: 3c849d0aefa1101cf38586449c2105a97797c414 URL: https://github.com/llvm/llvm-project/commit/3c849d0aefa1101cf38586449c2105a97797c414 DIFF: https://github.com/llvm/llvm-project/commit/3c849d0aefa1101cf38586449c2105a97797c414.diff

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added a comment. In D129682#3653049 , @bulbazord wrote: > In D129682#3651175 , @labath wrote: > >> Well.. first of let me say that the performance gain is impressive. I >> wouldn't have expected to gain th

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jasonmolenda added a comment. In D129814#3654230 , @labath wrote: > Generally, this makes sense to me, but I do have one question (not > necessarily for Jim). These tests work on (arm) linux, and I am wondering why > is that the case. Could it be relate

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

labath added a comment. Generally, this makes sense to me, but I do have one question (not necessarily for Jim). These tests work on (arm) linux, and I am wondering why is that the case. Could it be related to the fact that lldb-server preserves the stop reason for threads that are not running?

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

jasonmolenda added a comment. I read through the patch and I'm not sure I have much useful feedback because I haven't worked on the ThreadPlan code very much, but this does look like what we were discussing for this. I believe this patch will fix https://github.com/llvm/llvm-project/issues/487