jasonmolenda added a comment. I read through the patch and I'm not sure I have much useful feedback because I haven't worked on the ThreadPlan code very much, but this does look like what we were discussing for this. I believe this patch will fix https://github.com/llvm/llvm-project/issues/48777 . Regarding MIPS suport, in reading through the patch, I was reviewing relevant calls and saw this bit in `GDBRemoteCommunicationClient::GetWatchpointsTriggerAfterInstruction()` - so I believe you're right this change should also fix multithreaded watchpoint hitting on those targets.
// On targets like MIPS and ppc64, watchpoint exceptions are always // generated before the instruction is executed. The connected target may // not support qHostInfo or qWatchpointSupportInfo packets. after = !(triple.isMIPS() || triple.isPPC64()); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129814/new/ https://reviews.llvm.org/D129814 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
