DavidSpickett added inline comments.
================ Comment at: lldb/source/Target/StopInfo.cpp:724 + m_watch_sp.reset(); + } + bool ShouldStop(Event *event_ptr) override { ---------------- Blank line after this. ================ Comment at: lldb/source/Target/StopInfo.cpp:748 + uint32_t m_watch_index = LLDB_INVALID_INDEX32; + bool m_reset_watchpoint = false; + }; ---------------- Depending how you read it this seems backwards. if `m_reset_watchpoint` is true don't reset it? `m_did_reset_watchpoint` maybe? ================ Comment at: lldb/source/Target/StopInfo.cpp:755 + if (m_step_over_wp_sp) { + if (m_step_over_wp_sp->IsPlanComplete()) + return true; ---------------- `return m_step_over_wp_sp->IsPlanComplete();` ? ================ Comment at: lldb/source/Target/StopInfo.cpp:809 + error = thread_sp->QueueThreadPlan(m_step_over_wp_sp, false); + if (error.Success()) + return false; ---------------- `return error.Success()` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129814/new/ https://reviews.llvm.org/D129814 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits