[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Extracted from D99484 . My new plan is to start from the outside and work in

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

jasonmolenda updated this revision to Diff 393649. jasonmolenda marked 3 inline comments as done. jasonmolenda added a comment. Update patch to address the points David made. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115494/new/ https:

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

jasonmolenda marked 5 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:7005 + Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER)); if (image_infos.IsValid()) { for

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere added inline comments. Comment at: lldb/source/Version/Version.cpp:18 +#else + return "lldb version " CLANG_VERSION_STRING; +#endif thakis wrote: > thakis wrote: > > does this intentionally use CLANG_VERSION_STRING instead of > > LLDB_VERSION_STRIN

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2470 + const char *qn = die.GetQualifiedName(storage); + if (qn && !llvm::StringRef(qn).startswith(sc)) +return true; werat wrote: > `llvm::S

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 393485. lassefolger marked 2 inline comments as done. lassefolger added a comment. fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files: lldb/inc

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

thakis added inline comments. Comment at: lldb/source/CMakeLists.txt:4 -set(lldbBase_SOURCES -lldb.cpp - ) thakis wrote: > should lldb.cpp be deleted too? fixed in D115438 Comment at: lldb/source/Version/Version.cpp:18 +#else + return "ll

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a reviewer: omjavaid. DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1671 m_cmd_name.c_str(), m_cmd_syntax.c_str()); return false; } This check has

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. The original change was https://reviews.llvm.org/D102757, I'll add comments showing the new code relative to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ ht

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit 0df522969a7a0128052bd79182c8d58e00556e2f

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6984 + uint64_t slide = m_data.GetU64(&fileoff); + std::string filename = (const char *)m_data.GetCStr(&fileoff); + Seems like the cast wo

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp:830 + } return (pc & pac_sign_extension) ? pc | mask : pc & (~mask); } jasonmolenda wrote: > DavidSpickett wrote: > > Can you explain this logic? The "else"

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 393406. DavidSpickett added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/CommandObjectMemory.cpp

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Sent https://lists.llvm.org/pipermail/lldb-dev/2021-December/017163.html to get some more input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 ___

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Just to update where I am with this, I think I've got a good argument to not show the non-address bits in the output. That being that the memory itself that we read doesn't include these bits, so showing it is just going to be more confusing that the initial confu

[Lldb-commits] [lldb] efdac16 - Remove one change from https://reviews.llvm.org/D115431

Author: Jason Molenda Date: 2021-12-10T01:04:07-08:00 New Revision: efdac16b382b86358dba60f3a759c64a0fc446fc URL: https://github.com/llvm/llvm-project/commit/efdac16b382b86358dba60f3a759c64a0fc446fc DIFF: https://github.com/llvm/llvm-project/commit/efdac16b382b86358dba60f3a759c64a0fc446fc.diff

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. For some of our non-userland / non-kernel environments, there can be multiple binary images involved in the environment, and each enviro