DavidSpickett added a comment.

Just to update where I am with this, I think I've got a good argument to not 
show the non-address bits in the output.

That being that the memory itself that we read doesn't include these bits, so 
showing it is just going to be more confusing that the initial confusion of the 
address changing. In addition for things like memory tagging once you move 
beyond the granule your original pointer points to, the actual tag stored in 
hardware could be different. So we're misleading in that way.

The same applies to signed pointers where incrementing the signing bits isn't a 
thing in any case, so the signature for foo and foo+4 is probably different 
anyway.

I think that makes sense but I don't want to just go ahead until I get other's 
opinions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103626/new/

https://reviews.llvm.org/D103626

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to