[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

mgorny added a comment. I'm sorry for the trouble. I'll take a look at it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109326/new/ https://reviews.llvm.org/D109326 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:278 +if (error.Fail()) + return error; + If this is the only way out of this loop, does that mean we always return an error here? Repository: r

[Lldb-commits] [PATCH] D111200: Use llvm::VersionTuple to store DWARF producer info (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111200/new/ https://reviews.llvm.org/D111200 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D111200: Use llvm::VersionTuple to store DWARF producer info (NFC)

aprantl updated this revision to Diff 377403. aprantl added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111200/new/ https://reviews.llvm.org/D111200 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h In

[Lldb-commits] [PATCH] D111200: Use llvm::VersionTuple to store DWARF producer info (NFC)

aprantl updated this revision to Diff 377402. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111200/new/ https://reviews.llvm.org/D111200 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h Index: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D111200: Use llvm::VersionTuple to store DWARF producer info (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, kastiglione, jingham. aprantl requested review of this revision. This has the nice side-effect that it can actually store the quadruple version numbers that Apple's tools are using nowadays. rdar://82982162 https://reviews.l

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

brooks added a comment. This patch is sufficient to let things build, but doesn't address the tests. If there's a plan to MFC PT_COREDUMP that's probably an ok state of affairs. https://cgit.freebsd.org/ports/tree/devel/llvm-devel/files/patch-lldb-PT_COREDUMP.diff?id=7e2f156ce907e7785863d49cbd33

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

rnk added a comment. I had another idle thought on this matter: The unsigned overflow here really isn't that weird. It's the same thing as iterating over the range [-1, 0, `#args+1`]. We could update all these APIs to traffic in plain signed ints, and then there would be no wrapping, just norma

[Lldb-commits] [PATCH] D109326: [lldb] [Process/FreeBSD] Support SaveCore() using PT_COREDUMP

brooks added a comment. This needs to be guarded by the presence of PT_COREDUMP since it's a new feature. As it stands this breaks the lldb build on all supported FreeBSD releases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109326/new/ https:/

[Lldb-commits] [lldb] 730fca4 - [lldb] Improve meta data stripping from JSON crashlogs

Author: Jonas Devlieghere Date: 2021-10-05T12:15:54-07:00 New Revision: 730fca46fc87dad09040cb0b27ede10ae2c7c9d7 URL: https://github.com/llvm/llvm-project/commit/730fca46fc87dad09040cb0b27ede10ae2c7c9d7 DIFF: https://github.com/llvm/llvm-project/commit/730fca46fc87dad09040cb0b27ede10ae2c7c9d7.d

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib added a comment. ping @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib updated this revision to Diff 377326. mib edited the summary of this revision. mib added a comment. Reverted from `shared_ptr` to `unique_ptr` for SBMemoryRegionInfo opaque_ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib updated this revision to Diff 377324. mib marked 2 inline comments as done. mib added a comment. Address @JDevlieghere last comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 Files: lldb/bind

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:186 +void ScriptedThread::RefreshStateAfterStop() { + // TODO: Implement + if (m_reg_context_sp) JDevlieghere wrote: > Still rel

[Lldb-commits] [lldb] 5bc32ad - [lldb testing] NFC: run through clang-format

Author: David Zarzycki Date: 2021-10-05T13:40:27-04:00 New Revision: 5bc32ad08d9a25b1a4fc4fe7daa4056d1d1ef67f URL: https://github.com/llvm/llvm-project/commit/5bc32ad08d9a25b1a4fc4fe7daa4056d1d1ef67f DIFF: https://github.com/llvm/llvm-project/commit/5bc32ad08d9a25b1a4fc4fe7daa4056d1d1ef67f.diff

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. If you want to test more, please let me know and I can test them on my Fedora box. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 __

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f3254b29f37: [lldb] Improve help for platform put-file (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 0f3254b - [lldb] Improve help for platform put-file

Author: Keith Smiley Date: 2021-10-05T10:29:37-07:00 New Revision: 0f3254b29f375d449e815e91d63bef78d9e81354 URL: https://github.com/llvm/llvm-project/commit/0f3254b29f375d449e815e91d63bef78d9e81354 DIFF: https://github.com/llvm/llvm-project/commit/0f3254b29f375d449e815e91d63bef78d9e81354.diff

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

mgorny added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82 + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); + } ted wrote: > mgorny wrote: > > labath wrote: > > > Could this return const iterators?

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny added a comment. I suppose that's good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

ted added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82 + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); + } mgorny wrote: > labath wrote: > > Could this return const iterators? It seems we already

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

ted added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); labath wrote: > omjavaid wrote: > > labath wrote: > > > mgorny wrote: > > >

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. 79bf032fe10546fd1d6e14c5ac8905f25c2b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 __

[Lldb-commits] [lldb] 79bf032 - [lldb testing] Avoid subtle terminfo behavioral differences

Author: David Zarzycki Date: 2021-10-05T10:28:02-04:00 New Revision: 79bf032fe10546fd1d6e14c5ac8905f25c2b URL: https://github.com/llvm/llvm-project/commit/79bf032fe10546fd1d6e14c5ac8905f25c2b DIFF: https://github.com/llvm/llvm-project/commit/79bf032fe10546fd1d6e14c5ac8905f25c2b.diff

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 added a comment. In D110827#3034767 , @clayborg wrote: > Should we be testing if these directories exist before trying to use them? > Might be nice to avoid compiler warnings if the compiler will emit warnings > or errors if these directories do

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. "the buildbot"? There are many. I'd be surprised if this weren't failing on at least one of them. It doesn't seem like subtle terminfo behavior is essential to this test. Can we please trim down the adjustments to only changing the speed? For example: diff --git

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny added a comment. In D110962#3042270 , @davezarzycki wrote: > errno == 22 (EINVAL) > > The FD in question is 3. Here is the output from `lsof`: HostTests 80108 dave >3u CHR5,2 0t0 231 /dev/ptmx I don't think FD is the problem

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

mgorny added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:81 + typedef std::vector reg_collection; + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); labath wrote: > llvm (and, surprisingly, lldb -- I g

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

mgorny updated this revision to Diff 377193. mgorny added a comment. Update to use the new `AugmentRegisterInfo()` API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Targe

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Make AugmentRegisterInfo() take whole DynamicRegisterInfo

mgorny updated this revision to Diff 377186. mgorny added a comment. Add one missing call to `AugmentRegisterInfo()` before `Finalize()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42/new/ https://reviews.llvm.org/D42 Files: lldb/include/lldb/Target/ABI.h lldb/include/ll

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Make AugmentRegisterInfo() take whole DynamicRegisterInfo

mgorny created this revision. mgorny added reviewers: labath, teemperor, emaste, krytarowski. mgorny requested review of this revision. Modify ABI::AugmentRegisterInfo() to take the whole DynamicRegisterInfo rather than being claled per-register. https://reviews.llvm.org/D42 Files: lldb/i

[Lldb-commits] [lldb] cf818b5 - [lldb][NFC] Remove unnecessary include in cpp/const_this test

Author: Raphael Isemann Date: 2021-10-05T14:39:10+02:00 New Revision: cf818b55e79ee637c72f1f94a183eec26b4fa3b9 URL: https://github.com/llvm/llvm-project/commit/cf818b55e79ee637c72f1f94a183eec26b4fa3b9 DIFF: https://github.com/llvm/llvm-project/commit/cf818b55e79ee637c72f1f94a183eec26b4fa3b9.dif

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

labath added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:81 + typedef std::vector reg_collection; + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); llvm (and, surprisingly, lldb -- I guess because its

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, teemperor, emaste. mgorny requested review of this revision. Add DynamicRegisterInfo::Registers() method that returns llvm::iterator_range<> over RegisterInfos. This is a convenient replacement for GetNumRegisters() + GetR

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. errno == 22 (EINVAL) The FD in question is 3. Here is the output from `lsof`: HostTests 80108 dave 3u CHR5,2 0t0 231 /dev/ptmx Can we/I please revert this for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

labath added a comment. In D111052#3042184 , @mgorny wrote: > In D111052#3042181 , @labath wrote: > >> So I guess all that's left to do is to add some cast to placate compilers ? > > Nah, my original logic checks

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny added a comment. …and/or try removing lines from the `// make some arbitrary changes` block to see which one causes the error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 _

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny added a comment. No, it's not. Could you add a quick `printf()` there to see what the value of `errno` is? I need to check if gtest has a better method of checking for failure with errno. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); omjavaid wrote: > labath wrote: > > mgorny wrote: > > > omjavaid wrote:

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4260-4261 if (llvm::to_integer(value, reg_info.byte_size)) - reg_info.b

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); mgorny wrote: > omjavaid wrote: > > mgorny wrote: > > > omjavaid wrote

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. This is failing on my Fedora 34 (x86-64) box. Is this expected? FAIL: lldb-unit :: Host/./HostTests/TerminalTest.SaveRestoreRAII (78548 of 79402) TEST 'lldb-unit :: Host/./HostTests/TerminalTest.SaveRestoreRAII' FAILED

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); omjavaid wrote: > mgorny wrote: > > omjavaid wrote: > > > @mgorny the as

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

mgorny added a comment. In D111052#3042181 , @labath wrote: > So I guess all that's left to do is to add some cast to placate compilers ? Nah, my original logic checks for overflow and replaces the value with `0` if one occurs (which IMO is more correct

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); mgorny wrote: > omjavaid wrote: > > @mgorny the assert already exists

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

labath added a comment. So I guess all that's left to do is to add some cast to placate compilers ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111052/new/ https://reviews.llvm.org/D111052 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); omjavaid wrote: > @mgorny the assert already exists but then we also wan

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); @mgorny the assert already exists but then we also want to allow bit s

[Lldb-commits] [PATCH] D110942: [lldb] Move DynamicRegisterInfo to public Target library

This revision was automatically updated to reflect the committed changes. Closed by commit rG214054f78a4e: [lldb] Move DynamicRegisterInfo to public Target library (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 214054f - [lldb] Move DynamicRegisterInfo to public Target library

Author: Michał Górny Date: 2021-10-05T12:40:55+02:00 New Revision: 214054f78a4e40656b17838300dff2f136032172 URL: https://github.com/llvm/llvm-project/commit/214054f78a4e40656b17838300dff2f136032172 DIFF: https://github.com/llvm/llvm-project/commit/214054f78a4e40656b17838300dff2f136032172.diff

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4261 + reg_info.byte_size = + (reg_info.byte_size + CHAR_BIT - 1) / CHAR_BIT; } else if (name == "type") { I suppose LLD

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid created this revision. omjavaid added reviewers: labath, mgorny. omjavaid requested review of this revision. This patch allows LLDB to accept register sizes which are not aligned to 8 bits bitsize boundary. This fixes a crash in LLDB when connecting to OpenOCD stub. GDB xml description al

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny added a comment. In D110997#3041802 , @labath wrote: > That does not sound unreasonable, though I'm not sure how much is it actually > useful. Do you know if its like standard practice when working with serial > ports, ttys and stuff? To be hone

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

mgorny updated this revision to Diff 377133. mgorny added a comment. Remove support for 1.5 stop bits — it's valid only for 5-bit transmission (which we don't support). Simplify the API to use integer instead of enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111030/new/ https://re

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

mgorny added a comment. @labath has pointed out that this seems not to apply to the `vFile:fstat` that we're using — gdbserver seems to pass (truncated) `st_dev` there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111052/new/ https://reviews.llvm.org/D111052 _

[Lldb-commits] [lldb] ca5be06 - Revert "[lldb] Refactor variable parsing"

Author: Pavel Labath Date: 2021-10-05T10:46:30+02:00 New Revision: ca5be065c4c612554acdcae3ead01a1474eff296 URL: https://github.com/llvm/llvm-project/commit/ca5be065c4c612554acdcae3ead01a1474eff296 DIFF: https://github.com/llvm/llvm-project/commit/ca5be065c4c612554acdcae3ead01a1474eff296.diff

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

labath added inline comments. Comment at: lldb/include/lldb/Target/ABI.h:131-134 virtual void AugmentRegisterInfo(RegisterInfo &info) = 0; + // Routine called before DynamicRegisterInfo::Finalize(). + virtual void + PreFinalizeDynamicRegisterInfo(lldb_private::DynamicRegist

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

labath added a comment. In D110997#3039575 , @mgorny wrote: > In D110997#3039540 , @labath wrote: > >> Why is it important to restore the tty settings? (just asking, I have no >> clue about how this is supposed t

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.org/D110981