[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4261
+              reg_info.byte_size =
+                  (reg_info.byte_size + CHAR_BIT - 1) / CHAR_BIT;
           } else if (name == "type") {
----------------
I suppose LLDB crashed because `byte_size` was zero? Maybe add an assert for 
that then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111131/new/

https://reviews.llvm.org/D111131

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits