mgorny added inline comments.
================
Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:81
+ typedef std::vector<lldb_private::RegisterInfo> reg_collection;
+ llvm::iterator_range<reg_collection::iterator> Registers() {
+ return llvm::iterator_range<reg_collection::iterator>(m_regs);
----------------
labath wrote:
> llvm (and, surprisingly, lldb -- I guess because its a new feature) follows
> c++ naming conventions for methods like these.
/me not understand.
================
Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82
+ llvm::iterator_range<reg_collection::iterator> Registers() {
+ return llvm::iterator_range<reg_collection::iterator>(m_regs);
+ }
----------------
labath wrote:
> Could this return const iterators? It seems we already have some non-const
> accessors, but I'd rather not propagate that..
It can't — we're using these iterators to augment register infos ;-).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111136/new/
https://reviews.llvm.org/D111136
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
