[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid added a comment. In D98153#2610953 , @teemperor wrote: > Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr > checks that affect a normal LLDB session (not sure if we can ever have no > SymbolContext) or is this just fo

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 330884. nealsid added a comment. Rebased on HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/Forma

[Lldb-commits] [lldb] b5657d1 - Fix 34885bffdf43920c0f011e17a65fd678100240dd

Author: Walter Erquinigo Date: 2021-03-15T16:36:32-07:00 New Revision: b5657d1fbf77fc59d4c11476464547d850d9f48a URL: https://github.com/llvm/llvm-project/commit/b5657d1fbf77fc59d4c11476464547d850d9f48a DIFF: https://github.com/llvm/llvm-project/commit/b5657d1fbf77fc59d4c11476464547d850d9f48a.di

[Lldb-commits] [PATCH] D98656: [lldb-vscode] Handle request_evaluate's context attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34885bffdf43: [lldb-vscode] Handle request_evaluate's context attribute (authored by Walter Erquinigo ). Herald added a project: LLDB

[Lldb-commits] [lldb] 34885bf - [lldb-vscode] Handle request_evaluate's context attribute

Author: Walter Erquinigo Date: 2021-03-15T15:09:23-07:00 New Revision: 34885bffdf43920c0f011e17a65fd678100240dd URL: https://github.com/llvm/llvm-project/commit/34885bffdf43920c0f011e17a65fd678100240dd DIFF: https://github.com/llvm/llvm-project/commit/34885bffdf43920c0f011e17a65fd678100240dd.di

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

shafik added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *langu

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. Right, I see. The contained lists are going to make this trickier than I expected, and might even make the code more complicated. (Though this tradeoff will change if we ever end up with two optional regsets that need to mess with contained lists.) Could we at least the

[Lldb-commits] [PATCH] D98653: [lldb] Refactor to support non-pointer instance variables (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor, jingham, JDevlieghere, labath. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `frame variable` contextually supports accessing ivars via a lang

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett added a comment. I still have one known (though rare) limitation to this command. That is, if you try to read across two neighbouring MTE regions it will fail because it thinks that the whole range isn't tagged. When it is, it's just split over two regions. This would require you

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:102 +# Here we read from 1/2 way through a granule, into the next. Expands to 2 granules +self.check_qmemtags_response("{:x},10:1".forma

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 330686. DavidSpickett added a comment. - Update after changing earlier revisions - Read page size only once in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330685. DavidSpickett added a comment. Update after changing parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 330684. DavidSpickett added a comment. Correctly handle the ptrace call by looping until we get all tags as an error. I've gone ahead and treated anything but all tags as an error as far as lldb-server is concerned. Tell me what you think of that. Re

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny updated this revision to Diff 330674. mgorny added a comment. clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 Files: lldb/include/lldb/Utility/GDBRemoteError.h lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny updated this revision to Diff 330671. mgorny edited the summary of this revision. mgorny added a comment. Updated `GetPidTid()` to use `llvm::Optional>` return type with a default PID approach as suggested by @labath. Updated `ReadTid()` to use `llvm::Expected`. Create a new `GDBRemoteErr

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen updated this revision to Diff 330667. justincohen added a comment. squash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529 Files: lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h Index: lldb

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x000F; +} DavidSpickett wrote: > omjavaid wrote: > > How did you come up with this

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen updated this revision to Diff 330665. justincohen added a comment. Move logic to ABIMacOSX_arm64.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529 Files: lldb/source/Plugins/ABI/AArch64/ABIAAr

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Might somebody be willing to sign off on this change (this week or next)? I'd like to cherry-pick it to Swift's LLVM branch. Thanks for all the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > DavidSpickett wrote: > > omjavaid wrote: > > > DavidSpickett wrote: > > > > omjavaid wrote:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > omjavaid wrote: > > DavidSpickett wrote: > > > omjavaid wrote: > > > > DavidSpickett wrote:

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny added a comment. Or scratch that. What you propose is cleaner and requires less changes to tests ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] 0df28ac - [LLDB] Skip TestExitDuringExpression on arm/linux buildbot

Author: Muhammad Omair Javaid Date: 2021-03-15T16:03:06+05:00 New Revision: 0df28acffb5637ffb9abc908ef638f29389e0012 URL: https://github.com/llvm/llvm-project/commit/0df28acffb5637ffb9abc908ef638f29389e0012 DIFF: https://github.com/llvm/llvm-project/commit/0df28acffb5637ffb9abc908ef638f29389e00

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; omjavaid wrote: > DavidSpickett wrote: > > omjavaid wrote: > > > DavidSpickett wrote: > > > > DavidSpickett wr

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x000F; +} omjavaid wrote: > How did you come up with this 36bit mask for PC reg

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

omjavaid requested changes to this revision. omjavaid added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x000F; +}

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2625554 , @omjavaid wrote: > In D96458#2624962 , @labath wrote: > >> Thanks. This looks much better, but there is still one thing which bugs me >> about the register info constru

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2624962 , @labath wrote: > Thanks. This looks much better, but there is still one thing which bugs me > about the register info constructor. Currently, there are three paths through > that constructor: > > 1. when we d

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny added a comment. In D98482#2624973 , @labath wrote: > I'm still bugged by the GetPidTid interface -- the pair of optionals is very > complicated. What if we had this function take a `default_pid` argument > (which would be equal to the currently s