kastiglione added inline comments.
================
Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77
/// in a struct, union or class.
- bool IsClassMethod(lldb::LanguageType *language_ptr,
- bool *is_instance_method_ptr,
- ConstString *language_object_name_ptr);
+ bool IsClassMethod(ConstString *instance_var_name_ptr = nullptr,
+ bool *instance_is_pointer_ptr = nullptr);
----------------
shafik wrote:
> If we are going to refactor this, this change does not feel very C++y passing
> around pointers. I know we want a way to call this w/o any arguments but
> perhaps we can write an overload for that case?
>
> Does `instance_var_name_ptr` need to be a string? Maybe we can encode it
> using an enum, we don't have a lot of cases `this`, `self`, maybe even not a
> pointer as well and get ride of `instance_is_pointer_ptr`.
Something like?
```
enum InstanceVariable {
ThisPointer,
SelfPointer,
Self,
};
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98653/new/
https://reviews.llvm.org/D98653
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
