[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks ok to me. I'll leave it to you to sort out the specific annotations on individual tests. Comment at: lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadNa

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace updated this revision to Diff 303031. wallace marked 10 inline comments as done. wallace added a comment. Herald added a subscriber: mgorny. address issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90490/new/ https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added a comment. Thanks. I'm thinking about doing the early decoding, as doing "trace load" right now doesn't do anything very useful unless you do "dump instructions". However, I'll try to do it once I finish implementing decoding for live processes, because I want to have a unified pr

Re: [Lldb-commits] [lldb] 051da2b - [lldb] [test/Shell] Pass -pthread to host toolchain on FreeBSD too

On Wed, 2020-11-04 at 09:01 +0100, Pavel Labath wrote: > On 03/11/2020 22:02, Michał Górny via lldb-commits wrote: > > Author: Michał Górny > > Date: 2020-11-03T22:01:59+01:00 > > New Revision: 051da2bede4ba7231d009b5708d1191dde1e5dde > > > > URL: > > https://github.com/llvm/llvm-project/commit/0

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

JDevlieghere added a comment. This is great, it's been bothering me a lot. Thank Pedro! Could you please add a test case (something similar to `lldb/test/Shell/ScriptInterpreter/Lua/io.test should be fine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. LLDB regression https://bugs.llvm.org/show_bug.cgi?id=36209 fixed with D61611 and D90769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https:

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Preview for the update: https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html (well I hope styles and scripts will pop up at some point). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https:/

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz created this revision. sgraenitz added reviewers: rnk, eliben. Herald added a project: LLVM. sgraenitz requested review of this revision. Generalize the documentation to include both, GDB and LLDB. Add a link to the interface definition. Make a note on MCJIT's restriction to ELF. Mentio

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny added a comment. In D90757#2374533 , @emaste wrote: > When running locally with this change applied I get: > > > Failed Tests (8): > lldb-api :: > commands/expression/multiline-completion/TestMultilineCompletion.py >

[Lldb-commits] [lldb] c29c24b - [crashlog] Pass the debugger around instead of relying on lldb.debugger

Author: Jonas Devlieghere Date: 2020-11-04T12:51:26-08:00 New Revision: c29c24be638957d471e7991b55f54bff69044239 URL: https://github.com/llvm/llvm-project/commit/c29c24be638957d471e7991b55f54bff69044239 DIFF: https://github.com/llvm/llvm-project/commit/c29c24be638957d471e7991b55f54bff69044239.d

[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger

This revision was automatically updated to reflect the committed changes. Closed by commit rGc29c24be6389: [crashlog] Pass the debugger around instead of relying on lldb.debugger (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch changes the implementation of Lua's `print()` function to respect `io.stdout`. The original implemen

[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90706/new/ https://reviews.llvm.org/D90706 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny updated this revision to Diff 302943. mgorny added a comment. I had accidentally included a commented out xfail for testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90757/new/ https://reviews.llvm.org/D90757 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/sou

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny updated this revision to Diff 302942. mgorny marked an inline comment as done. mgorny added a comment. Fixed test comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90757/new/ https://reviews.llvm.org/D90757 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/sourc

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:955 -# Don't do lldb-server (llgs) tests on anything except Linux and Windows. +# Don't do lldb-server (llgs) tests on platforms not supporti

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added a comment. When running locally with this change applied I get: Failed Tests (8): lldb-api :: commands/expression/multiline-completion/TestMultilineCompletion.py lldb-api :: functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny added a comment. In D90757#2374087 , @emaste wrote: > I added comments in the now-dereferenced bugs linking back to this review - > most of them were submitted by me, and I'll double check and close them once > this lands. I was planning to go th

[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:853 +# can rely on lldb.debugger being set. +SymbolicateCrashLogs(lldb.debugger, shlex.split(command)) except Exception as e: -

[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger

JDevlieghere updated this revision to Diff 302896. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address @vsk's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90706/new/ https://reviews.llvm.org/D90706 Files: lldb/examples/python/crashlog.py ll

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added a comment. I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands. One minor update needed (restoring a comment that was partially deleted) Comment at: l

[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger

vsk added inline comments. Comment at: lldb/examples/python/crashlog.py:853 +# can rely on lldb.debugger being set. +SymbolicateCrashLogs(lldb.debugger, shlex.split(command)) except Exception as e: Why does crashlog.Symbolicate accept a debug

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny updated this revision to Diff 302859. mgorny added a comment. Applied changes as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90757/new/ https://reviews.llvm.org/D90757 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/source/Plugins/Platform/FreeBSD/Plat

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz created this revision. sgraenitz added reviewers: labath, clayborg, bkoropoff, loladiro, lhames. Herald added a project: LLDB. sgraenitz requested review of this revision. Herald added a subscriber: JDevlieghere. Part 2 of a fix for JITed code debugging. This has been a regression from 5

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py:39 @skipIfWindows +@expectedFailureAll(oslist=["freebsd"]) def test_process_connect_sync(self):

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 302845. DavidSpickett added a comment. - Revert stray change of run-qemu.sh file mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442 Files: lldb/docs/lldb-gdb-

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 302843. DavidSpickett added a comment. - Only "mt" flag supported - Don't typedef expected MemoryRegionInfo - Link lldbPluginProcessUtility (not lldbPluginProcessLinux) in proc map tests - "mt" is now the only supported flag - "memory tagging: enabled" i

[Lldb-commits] [lldb] 586c375 - [lldb] Remove [US]IntValueIsValidForSize from CommandObjectMemory

Author: Pavel Labath Date: 2020-11-04T16:28:10+01:00 New Revision: 586c375fa3f0bb6f685a69ea43d7f235b76b6a9f URL: https://github.com/llvm/llvm-project/commit/586c375fa3f0bb6f685a69ea43d7f235b76b6a9f DIFF: https://github.com/llvm/llvm-project/commit/586c375fa3f0bb6f685a69ea43d7f235b76b6a9f.diff

[Lldb-commits] [lldb] e2d24d9 - [lldb/Utility] Delete Scalar::[US]IntValueIsValidForSize

Author: Pavel Labath Date: 2020-11-04T16:28:10+01:00 New Revision: e2d24d91c2a11ea488844d20ef5fabd05936a668 URL: https://github.com/llvm/llvm-project/commit/e2d24d91c2a11ea488844d20ef5fabd05936a668 DIFF: https://github.com/llvm/llvm-project/commit/e2d24d91c2a11ea488844d20ef5fabd05936a668.diff

[Lldb-commits] [lldb] ac6799d - [lldb] Improve RegisterValue::GetScalarValue

Author: Pavel Labath Date: 2020-11-04T14:53:06+01:00 New Revision: ac6799d25a59e262191e0babcd7024537fda467e URL: https://github.com/llvm/llvm-project/commit/ac6799d25a59e262191e0babcd7024537fda467e DIFF: https://github.com/llvm/llvm-project/commit/ac6799d25a59e262191e0babcd7024537fda467e.diff

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. [ I've replying to your message in a slightly different order that what it was written. ] In D82863#2373356 , @omjavaid wrote: > In D82863#2373276 , @labath wrote: > >> I'd like to avoid se

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

labath added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:251-265 + llvm::Triple host_triple{llvm::sys::getProcessTriple()}; + bool use_legacy_plugin; + + switch (host_triple.getArch()) { +case llvm::Triple::x86: +case llvm::Tri

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny updated this revision to Diff 302810. mgorny added a comment. Missed one test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90757/new/ https://reviews.llvm.org/D90757 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.c

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:250 bool PlatformFreeBSD::CanDebugProcess() { + llvm::Triple host_triple{llvm::sys::getProcessTriple()}; @labath, any clue if I am missing something or is this

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a reviewer: JDevlieghere. mgorny requested review of this revision. The new FreeBSDRemote plugin has reached feature parity on i386 and amd64 targets. Use it by

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2373276 , @labath wrote: > I'm sorry about the delay, I was having trouble finding the time to think > this through... > > In D82863#2342112 , @omjavaid wrote: > >> In D82863#234

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I'm sorry about the delay, I was having trouble finding the time to think this through... In D82863#2342112 , @omjavaid wrote: > In D82863#2341628 , @labath wrote: > >> I'm afraid I don't u

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 302794. omjavaid added a comment. This update tries to mitigate effects of fixed offset fields in LLDB register description. We have now replaced Arm64 register infos on lldb-server side to generate offsets which increase with respect to size in increasing

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

labath added a comment. I'd say this looks ok now. Another advantage of doing the decoding early is that we could then simplify the IntelPTInstruction class. If we handle the early decoding errors (file not found, etc.) early, then the only kind of errors this class could contain are errors fro

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

labath added a comment. Just some layering remarks. Other than that, I think this is fine. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:17 #include "lldb/Host/MainLoop.h" +#include "lldb/Target/Trace.h" #include "lldb/Utility/ArchSpec.h"

[Lldb-commits] [PATCH] D90741: [LLDB] Fix SVE reginfo for sequential offset in g packet

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The fact that the byte_offset field doubles as a g offset and a ptrace offset is makes things pretty convoluted. Maybe (just maybe) one day we wouldn't even need to materialize the g offset an

[Lldb-commits] [lldb] 5d64574 - [lldb] Delete Value::Vector class

Author: Pavel Labath Date: 2020-11-04T10:21:56+01:00 New Revision: 5d64574301836c4c17127794121d49a62d24f803 URL: https://github.com/llvm/llvm-project/commit/5d64574301836c4c17127794121d49a62d24f803 DIFF: https://github.com/llvm/llvm-project/commit/5d64574301836c4c17127794121d49a62d24f803.diff

Re: [Lldb-commits] [lldb] 051da2b - [lldb] [test/Shell] Pass -pthread to host toolchain on FreeBSD too

On 03/11/2020 22:02, Michał Górny via lldb-commits wrote: Author: Michał Górny Date: 2020-11-03T22:01:59+01:00 New Revision: 051da2bede4ba7231d009b5708d1191dde1e5dde URL: https://github.com/llvm/llvm-project/commit/051da2bede4ba7231d009b5708d1191dde1e5dde DIFF: https://github.com/llvm/llvm-pr