labath added inline comments.
================
Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:251-265
+ llvm::Triple host_triple{llvm::sys::getProcessTriple()};
+ bool use_legacy_plugin;
+
+ switch (host_triple.getArch()) {
+ case llvm::Triple::x86:
+ case llvm::Triple::x86_64:
+ // FreeBSDRemote plugin supports x86 only at the moment
----------------
I think this ought to go into the `if(host)` block, as it's really not
applicable to remote debugging.
================
Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:250
bool PlatformFreeBSD::CanDebugProcess() {
+ llvm::Triple host_triple{llvm::sys::getProcessTriple()};
----------------
mgorny wrote:
> @labath, any clue if I am missing something or is this really sufficient to
> switch between plugins?
Yeah, this should be fine. I was thinking it should be possible to switch this
on from a single place all along....
================
Comment at:
lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py:39
@skipIfWindows
+ @expectedFailureAll(oslist=["freebsd"])
def test_process_connect_sync(self):
----------------
These may be related to the `if(host)` thingy.
================
Comment at:
lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:54-55
# intended IMHO.
@skipIfLinux
- @skipIfFreeBSD
- @expectedFailureNetBSD
+ @expectedFailureAll(oslist=["freebsd", "netbsd"])
def test_inferior_crashing_expr_step_and_expr(self):
----------------
I'm pretty sure the root cause here is the same for net/free bsd as it is for
linux (it comes down to macos catching the "crashes" specially, before they
even get turned to a SEGV -- something that's not possible elsewhere). I marked
it skip because that's not something we should support, ever. I don't care that
much which decorator (skip vs. xfail) is used here, but I think they should be
consistent.
================
Comment at:
lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py:31
@skipIfLinux
- @skipIfFreeBSD
- @expectedFailureNetBSD
+ @expectedFailureAll(oslist=["freebsd", "netbsd"])
def test_recursive_inferior_crashing_expr_step_and_expr(self):
----------------
ditto
================
Comment at:
lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:32
@skipIfWindows # the test is not updated for Windows.
+ @expectedFailureAll(oslist=["freebsd"])
@llgs_test
----------------
What's up with this? I though you fixed thread names already..
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90757/new/
https://reviews.llvm.org/D90757
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
