[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 255588. yuri added a comment. Do not depend on exitance of /bin/sh anymore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 255581. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h lldb/test/Shell/Process/Win

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. This looks like what I'd like to implement, but unfortunately it breaks other tests. Some C tests start printing null pointers as `nullptr` too. I suppose this is because the expression evaluator is always in C++ mode. Is there a way to get the origin type/language of a v

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 255580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h Index: lldb/source/Plugins/P

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss updated this revision to Diff 255579. friss added a comment. Remove the now useless code in TypeSummary.cpp, and change the C++ implementation of IsNilReference() to return true soemtimes. This breaks other tests though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss updated this revision to Diff 255571. friss added a comment. Implement null C++ printing at the ValueObjectPrinter level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 Files: lldb/include/lldb/Targ

[Lldb-commits] [lldb] 06ea05a - [lldb/test] Fix TestDSYMSourcePathRemapping in the presence of symlnks

Author: Fred Riss Date: 2020-04-06T19:50:34-07:00 New Revision: 06ea05a3fbc6e70cd4c492cced363a8630d65c6a URL: https://github.com/llvm/llvm-project/commit/06ea05a3fbc6e70cd4c492cced363a8630d65c6a DIFF: https://github.com/llvm/llvm-project/commit/06ea05a3fbc6e70cd4c492cced363a8630d65c6a.diff LOG

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:70 const dw_tag_t die_tag = die_info_array[i].tag; -if (die_tag != 0 && die_tag != DW_TAG_class_type && -die_tag != DW_TAG_structure_type) +if (!(die_tag == 0 |

Re: [Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

This should be easy to test. If you have a running process, and haven’t called “process load” then: (lldb) process unload 12345 Should return the error: failed to unload image: invalid image token But instead on x86_64 it returns the error: failed to unload image: expression failed: "dlclose

Re: [Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

Hello Saleem, I am not familiar with this part of the code but is there an easy way to test this failure? We should add a test to make sure we don’t break this accidentally in the future. Thank you! > On Apr 6, 2020, at 5:38 PM, Saleem Abdulrasool via lldb-commits > wrote: > > > Author: Sa

[Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

Author: Saleem Abdulrasool Date: 2020-04-06T17:37:57-07:00 New Revision: 3775be2d8e17aaeae62ab83ded005867f4bf70ac URL: https://github.com/llvm/llvm-project/commit/3775be2d8e17aaeae62ab83ded005867f4bf70ac DIFF: https://github.com/llvm/llvm-project/commit/3775be2d8e17aaeae62ab83ded005867f4bf70ac.

[Lldb-commits] [lldb] 469580a - Add missing include

Author: Adrian Prantl Date: 2020-04-06T17:29:31-07:00 New Revision: 469580a9677473f4ee19d80861f7a5da4e0f316d URL: https://github.com/llvm/llvm-project/commit/469580a9677473f4ee19d80861f7a5da4e0f316d DIFF: https://github.com/llvm/llvm-project/commit/469580a9677473f4ee19d80861f7a5da4e0f316d.diff

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

JDevlieghere added a comment. LGTM, but let's wait for Pavel to sign off on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D77608: [lldb/Scripts] Add script to replay multiple reproducers

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/scripts/reproducer-replay.py:1 +#! /usr/bin/env python3 + This is needed for the timeout

[Lldb-commits] [PATCH] D77608: [lldb/Scripts] Add script to replay multiple reproducers

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/scripts/reproducer-replay.py:1 +#! /usr/bin/env python3 + This is needed for the timeout. I'd rather not rely on an external package for this unless anyone object

Re: [Lldb-commits] [lldb] 29beabb - [lldb/API] Add missing LLDB_REGISTER_METHOD macros

Yep! On Mon, Apr 6, 2020 at 4:18 PM Davidino Italiano wrote: > > > > On Apr 6, 2020, at 4:09 PM, Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > > > Author: Jonas Devlieghere > > Date: 2020-04-06T16:09:40-07:00 > > New Revision: 29beabbe51c222c7ee0f8aead5b45649

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e05d7b3d3c6: Remap the target (Xcode) SDK directory to the host SDK directory. (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D76471?vs=254696&id

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

shafik added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:103 + // Helper iterator for the 'equal_range' method. + class CString_iterator { + public: `CStringIterator`? Comment at: lldb/include/lldb/Core/UniqueCStr

Re: [Lldb-commits] [lldb] 29beabb - [lldb/API] Add missing LLDB_REGISTER_METHOD macros

> On Apr 6, 2020, at 4:09 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-06T16:09:40-07:00 > New Revision: 29beabbe51c222c7ee0f8aead5b45649363cdbea > > URL: > https://github.com/llvm/llvm-project/commit/29beabbe51c222c7ee0f8aead5b45649363cdbe

[Lldb-commits] [lldb] 29beabb - [lldb/API] Add missing LLDB_REGISTER_METHOD macros

Author: Jonas Devlieghere Date: 2020-04-06T16:09:40-07:00 New Revision: 29beabbe51c222c7ee0f8aead5b45649363cdbea URL: https://github.com/llvm/llvm-project/commit/29beabbe51c222c7ee0f8aead5b45649363cdbea DIFF: https://github.com/llvm/llvm-project/commit/29beabbe51c222c7ee0f8aead5b45649363cdbea.d

[Lldb-commits] [lldb] 1e05d7b - Remap the target (Xcode) SDK directory to the host SDK directory.

Author: Adrian Prantl Date: 2020-04-06T15:51:30-07:00 New Revision: 1e05d7b3d3c6d29ff6f9493cc478a36244cc32bd URL: https://github.com/llvm/llvm-project/commit/1e05d7b3d3c6d29ff6f9493cc478a36244cc32bd DIFF: https://github.com/llvm/llvm-project/commit/1e05d7b3d3c6d29ff6f9493cc478a36244cc32bd.diff

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: abidh. JDevlieghere added a parent revision: D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.. Support inline replay as described in the RFC [1] on ll

[Lldb-commits] [lldb] 41610d6 - [gdb-remote] Moving prevents copy elision. Found by clang.

Author: Davide Italiano Date: 2020-04-06T14:59:27-07:00 New Revision: 41610d665013d716da245175ada1d9c5a8b79558 URL: https://github.com/llvm/llvm-project/commit/41610d665013d716da245175ada1d9c5a8b79558 DIFF: https://github.com/llvm/llvm-project/commit/41610d665013d716da245175ada1d9c5a8b79558.dif

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. This adds the necessary boiler plate to capture and replay API tests. http://lists.llvm.org/pipermail/lldb-dev/2020-April/016100.html Repository: rLLDB LLDB https://reviews.llvm.org/D77588 Files: lldb/bindings/head

[Lldb-commits] [lldb] 1b7560b - [lldb/Test] Enable TestGdbRemoteThreadsInfoMemory.py on Windows.

Author: Jonas Devlieghere Date: 2020-04-06T14:29:09-07:00 New Revision: 1b7560b877217adc828ed5c8d7818e14dccc7378 URL: https://github.com/llvm/llvm-project/commit/1b7560b877217adc828ed5c8d7818e14dccc7378 DIFF: https://github.com/llvm/llvm-project/commit/1b7560b877217adc828ed5c8d7818e14dccc7378.d

[Lldb-commits] [PATCH] D77369: Augment the symbol type classification for dyld trie exports with more detail

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG836534f99702: Add more detailed symbol type categorization, based on a swift patch by Greg… (authored by jasonmolenda). R

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

aprantl added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:102 + // Helper iterator for the 'equal_range' method. + class CString_iterator { /// Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2016 +for (size_t i = 0; i < num_matches; ++i) { + const DIERef &die_ref = method_die_offsets[i]; DWARFDebugInfo &de

[Lldb-commits] [lldb] 836534f - Add more detailed symbol type categorization, based on a swift patch by

Author: Jason Molenda Date: 2020-04-06T14:05:33-07:00 New Revision: 836534f9970295ff559ef49d6c49958aac6171f9 URL: https://github.com/llvm/llvm-project/commit/836534f9970295ff559ef49d6c49958aac6171f9 DIFF: https://github.com/llvm/llvm-project/commit/836534f9970295ff559ef49d6c49958aac6171f9.diff

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:130-163 + bool GetValues(ConstString unique_cstr, + std::function callback) const { +for (const Entry &entry : llvm::mak

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255464. lawrence_danna added a comment. delete operator= too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255463. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [lldb] 6f9ea26 - [debugserver] Get rid of `else` after `return`. NFC.

Author: Davide Italiano Date: 2020-04-06T13:35:48-07:00 New Revision: 6f9ea26002914cd3bcc27f09e65a151c81682352 URL: https://github.com/llvm/llvm-project/commit/6f9ea26002914cd3bcc27f09e65a151c81682352 DIFF: https://github.com/llvm/llvm-project/commit/6f9ea26002914cd3bcc27f09e65a151c81682352.dif

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace updated this revision to Diff 255454. wallace added a comment. wallace updated this revision to Diff 255455. . wallace added a comment.

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255455. wallace added a comment. Improve some names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i lldb/inclu

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace updated this revision to Diff 255454. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 Files: lldb/bindings/interface/SBCommandInterpreter.i lldb/include/lldb/API/SBCom

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255447. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig Index:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 255445. wallace edited the summary of this revision. wallace added a comment. See the new description of the diff for the updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

> BTW, I thought when a command returned the command string for the next command, the command interpreter prepended it with the chain of parent commands containing the command that was presenting the “next command string”. That is correct. The GetRepeatCommand function gets the full command with t

Re: [Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Then only time that I can find where I customized the string based on the incoming full command was for “source list” because I needed to know whether the listing was going forward or backward, so I needed to write that into the “keep doing what you were doing” command. That could have also bee

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255429. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h lldb/source/API/SBCommandI

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255426. wallace added a comment. Herald added a subscriber: mgorny. - Moved the test to gtest. It's much better this way and I learned gtest - Changed the API. Some notes: Within the scope of a subcommand, the subcommand doesn't know the parent's command name

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

clayborg added a comment. In D77444#1963354 , @labath wrote: > In D77444#1962952 , @clayborg wrote: > > > The biggest issue is maintaining the API. We can't add anything to > > SBCommandPluginInterface > > > If we'

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

Yes. Now that I think about it a little more, I’m a bit surprised that on most platforms we do have to step in & back out again to step over this function. That’s what we always used to do, but the work Greg & Co. did a little while back added the assumption that call’s return to the PC direct

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. In D77480#1963315 , @labath wrote: > Thanks for getting back to this. Is there any reasonable way of testing this > (e.g. an existing python class with temporary buffer storage), or would we > have to implement our own PyB

[Lldb-commits] [PATCH] D77568: Return correct entry in RangeDataVector::FindEntryThatContains

shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The FindEntryThatContains function does not return the correct entry in the case when two non-consecutive entries contain the range. Eg. Vector = [(0, 40, 0), (10, 10, 1)] and query = (25,

[Lldb-commits] [PATCH] D77460: [lldb] NFC: Fix trivial typo in comments, documents, and messages

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9264b746b81: [lldb] NFC: Fix trivial typo in comments, documents, and messages (authored by kiszk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77460/new/

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. In D77287#1963242 , @labath wrote: > In D77287#1960390 , @compnerd wrote: > > > I think that the basic test is sufficient for this. > > > That test does not seem to be exercising the "unloa

[Lldb-commits] [lldb] e9264b7 - [lldb] NFC: Fix trivial typo in comments, documents, and messages

Author: Kazuaki Ishizaki Date: 2020-04-07T01:06:16+09:00 New Revision: e9264b746b81a63323d884ea07b2ebfbb660d004 URL: https://github.com/llvm/llvm-project/commit/e9264b746b81a63323d884ea07b2ebfbb660d004 DIFF: https://github.com/llvm/llvm-project/commit/e9264b746b81a63323d884ea07b2ebfbb660d004.di

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255340. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:130-163 + bool GetValues(ConstString unique_cstr, + std::function callback) const { +for (const Entry &entry : llvm::mak

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255339. kwk added a comment. - rebased onto master to get rid of NFC change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolv

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG9072df8ac143: [lldb][nfc] remove overriden funcs with default impl (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] 9072df8 - [lldb][nfc] remove overriden funcs with default impl

Author: Konrad Kleine Date: 2020-04-06T10:05:59-04:00 New Revision: 9072df8ac1431dba51394b77ead766aada82867f URL: https://github.com/llvm/llvm-project/commit/9072df8ac1431dba51394b77ead766aada82867f DIFF: https://github.com/llvm/llvm-project/commit/9072df8ac1431dba51394b77ead766aada82867f.diff

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

labath added a comment. In D77045#1956879 , @omjavaid wrote: > Adding a testcase would be tricky as these register overlap in memory and we > store them with overlapping offsets with their children we should not need to > invalidate the children when we

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

This revision was automatically updated to reflect the committed changes. Closed by commit rGa53bf9b7c8f1: [lldb-server] jThreadsInfo returns stack memory (authored by jarin, committed by labath). Changed prior to commit: https://reviews.llvm.org/D74398?vs=251714&id=255316#toc Repository: rG

[Lldb-commits] [lldb] a53bf9b - [lldb-server] jThreadsInfo returns stack memory

Author: Jaroslav Sevcik Date: 2020-04-06T15:43:19+02:00 New Revision: a53bf9b7c8f1ca950226a55c0e99fd706a7b6ad2 URL: https://github.com/llvm/llvm-project/commit/a53bf9b7c8f1ca950226a55c0e99fd706a7b6ad2 DIFF: https://github.com/llvm/llvm-project/commit/a53bf9b7c8f1ca950226a55c0e99fd706a7b6ad2.dif

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

labath updated this revision to Diff 255310. labath marked an inline comment as done. labath added a comment. refactor EOF handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77295/new/ https://reviews.llvm.org/D77295 Files: lldb/source/Core/

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Core/Communication.cpp:318 bool done = false; + bool disconnect = false; while (!done && comm->m_read_thread_enabled) { clayborg wrote: > Can we just init "disco

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255300. kwk added a comment. - Simplify comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFil

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk marked 2 inline comments as done. kwk added a comment. @jankratochvil thanks for the tip. @labath, addressed your comments and will now push it. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri marked an inline comment as done. yuri added inline comments. Comment at: lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:221 +core = f.read() +core = core.replace(b'/home/labath/test/a.out', b'/bin/sh\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0'

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

Thanks Pavel and Jan, Sorry for the inconvenience On Mon, 6 Apr 2020 at 15:42, Pavel Labath wrote: > I guess these should go away after 4f644ff9e (which restrict the > decorator to aarch64). Judging by > < > http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20200330/063428.html > >, > Jim

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

labath added a comment. Thanks for doing this. There are so many levels at which the search for modules is retried and I am glad that we can solve this problem by getting rid of one of them. Unfortunately, all of that complexity also means it's hard to guarantee that this won't break anything,

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. Build failure is a bug of //tidy// script and is not caused by the patch itself. /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lldb/source/Target/RemoteAwarePlatform.cpp:9:10: error: 'lldb/Target/RemoteAwarePlatform.h' file not found [clang-diagnostic-erro

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

I guess these should go away after 4f644ff9e (which restrict the decorator to aarch64). Judging by , Jim is going to look into a better solution for that this week. pl On 06/04/2020 11:50, Jan Kratochvil wrote: > Hi,

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

labath added a comment. In D77444#1962952 , @clayborg wrote: > The biggest issue is maintaining the API. We can't add anything to > SBCommandPluginInterface If we're going to be adding a new inheritable class for this feature, I'd recommend adding abou

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

labath added a comment. Thanks for getting back to this. Is there any reasonable way of testing this (e.g. an existing python class with temporary buffer storage), or would we have to implement our own PyBuffer object? Comment at: lldb/bindings/python/python-typemaps.swig:493

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

Hi, I get XPASSes now on Fedora 31 x86_64: http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/7169 http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=1000 So maybe to remove the expected failure? Jan On Sun, 05 Apr 2020 17:18:54 +0200, Muhammad Omair Javaid via lldb-com

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG203a8adb6542: [lldb] Add option to retry Fix-Its multiple times to failed expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

labath added a comment. Thanks for doing this. This looks more-or-less like what I was expecting. The need for the "bool" return value from the index functions is unfortunate (I did not anticipate that), but it does seem unavoidable. Since none of these functions (I guess) are storing the callb

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

labath accepted this revision. labath added inline comments. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true. virtual bool ModulePasses(const FileSpec &spec); kwk wrote: > jankra

[Lldb-commits] [PATCH] D77460: [lldb] NFC: Fix trivial typo in comments, documents, and messages

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77460/new/ https://reviews.llvm.org/D77460 _

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

labath added a comment. Looks good to me, but let's wait for @shafik and @aprantl to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 ___ lldb-commi

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 255260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.cpp lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore

[Lldb-commits] [lldb] 203a8ad - [lldb] Add option to retry Fix-Its multiple times to failed expressions

Author: Raphael Isemann Date: 2020-04-06T11:25:36+02:00 New Revision: 203a8adb65429ec6b8989afdf5956564972b9703 URL: https://github.com/llvm/llvm-project/commit/203a8adb65429ec6b8989afdf5956564972b9703 DIFF: https://github.com/llvm/llvm-project/commit/203a8adb65429ec6b8989afdf5956564972b9703.dif

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a comment. Checking for presence this way seems ok-ish (definitely better than the environment variable). A possible alternative would be to pass some argument to dotest from cmake which would identify the status of the pt support. Anyway, if you're going to add a new public API fo

[Lldb-commits] [PATCH] D77055: [lldb] Also apply Fix-Its in "note:" diagnostics that belong to an error diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c2dc28d812c: [lldb] Also apply Fix-Its in "note:" diagnostics that belong to an error… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLV

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

labath added a comment. In D77287#1960390 , @compnerd wrote: > I think that the basic test is sufficient for this. That test does not seem to be exercising the "unload" part of this patch. It would also be nice to run some basic command like "image list

[Lldb-commits] [lldb] 3c2dc28 - [lldb] Also apply Fix-Its in "note:" diagnostics that belong to an error diagnostic

Author: Raphael Isemann Date: 2020-04-06T10:37:33+02:00 New Revision: 3c2dc28d812c917e01f46b3bcf5b5e0a2a803276 URL: https://github.com/llvm/llvm-project/commit/3c2dc28d812c917e01f46b3bcf5b5e0a2a803276 DIFF: https://github.com/llvm/llvm-project/commit/3c2dc28d812c917e01f46b3bcf5b5e0a2a803276.dif

[Lldb-commits] [lldb] 4f644ff - [lldb] XFAIL TestThreadPlanCommands _only_ on aarch64

Author: Pavel Labath Date: 2020-04-06T10:36:02+02:00 New Revision: 4f644ff9e8738b5fde4825b929ec69d0b78ed2ea URL: https://github.com/llvm/llvm-project/commit/4f644ff9e8738b5fde4825b929ec69d0b78ed2ea DIFF: https://github.com/llvm/llvm-project/commit/4f644ff9e8738b5fde4825b929ec69d0b78ed2ea.diff

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

teemperor added a comment. I rewrote this test in acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 so this isn't necessary anymore. Thanks for the patch though! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri created this revision. yuri added reviewers: labath, clayborg, EugeneBi. yuri added a project: LLDB. Herald added a subscriber: lldb-commits. In D49685 sysroot behaviour was partially fixed. But files from local filesystem with same path still has priority o

[Lldb-commits] [lldb] acb0b99 - [lldb][NFC] Modernize lang/cpp/scope test

Author: Raphael Isemann Date: 2020-04-06T09:36:54+02:00 New Revision: acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 URL: https://github.com/llvm/llvm-project/commit/acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 DIFF: https://github.com/llvm/llvm-project/commit/acb0b99c8e4f1dc65a7f1e26da9db77239a67da7.dif

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

This revision was automatically updated to reflect the committed changes. Closed by commit rG714324b79ae2: [DebugInfo] Support DWARFv5 index sections. (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.ll

[Lldb-commits] [PATCH] D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0249fe91c7b: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC. (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D77141?vs=254802&id=255232#toc Reposi

[Lldb-commits] [lldb] a0249fe - [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.

Author: Igor Kudrin Date: 2020-04-06T13:28:06+07:00 New Revision: a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb URL: https://github.com/llvm/llvm-project/commit/a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb DIFF: https://github.com/llvm/llvm-project/commit/a0249fe91c7ba0dabf0e8789171fb4aea5fca1cb.diff L