kwk marked 2 inline comments as done. kwk added a comment. @jankratochvil thanks for the tip. @labath, addressed your comments and will now push it.
================ Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true. virtual bool ModulePasses(const FileSpec &spec); ---------------- labath wrote: > kwk wrote: > > jankratochvil wrote: > > > I am not against it but FYI in a paragraph above there is already > > > written: `The default implementation is "Everything Passes."` > > > English: IMO missing "returns". > > Thank you for the missing "returns". I'd like to keep the comment. > You can keep _a_ comment if you want, but this comment is even internally > redundant. I don't see a need to mention overriding, saying "The default > (base?) implementation returns true" should be clear enough. @labath. That is fine. I've changed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
