yuri marked an inline comment as done. yuri added inline comments.
================ Comment at: lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:221 + core = f.read() + core = core.replace(b'/home/labath/test/a.out', b'/bin/sh\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0') + core = core.replace(b'a.out', b'sh\0\0\0') ---------------- labath wrote: > Would it be possible to make this test not depend on the existence of > `/bin/sh`? Maybe if you place the "wrong" file in `$BUILD/a.out`, and the > "right" file at `$BUILD/sysroot/$BUILD/a.out` and then check that the "right" > file was selected? > > I guess that will require creating a new core file with a sufficiently long > path so that it can be replaced by the right runtime value. Yes, it's possible. Can you suggest how to upload binary file into review? Looks like git diff with --binary flag is not supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
