[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin added a comment. Thank you for the feedback! I am a bit busy with other things ATM, but I should be able to get back to this next week. I should give credit where it's due - Pavel pointed me to the debug-server code and I took the idea from there. We do not always have the frame pointer l

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for doing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 ___ lldb-com

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

shafik added a comment. I can see how stripping `__1` would be nice but I seeing `(anonymous namespace)` may be useful to know especially b/c it effects visibility and linkage. It would be nicer if could make this optional and default it off but be able to turn it back on. Repository: rLLDB

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 244300. paolosev added a comment. Fix patch after rebasing: - Use macros to initialize plugins in SystemInitializer. - Move tests from /packages/Python/lldbsuite/test/functionalities/gdb_remote_client/ to /test/API/functionalities/gdb_remote_client/ Repo

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

JDevlieghere updated this revision to Diff 244299. JDevlieghere added a comment. Herald added a subscriber: emaste. Complete rewrite based on the external forward declarations. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73067/new/ https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jasonmolenda added a comment. Nice improvement. debugserver does a similar thing in our jThreadsInfo implementation as well as our ? packet response (T05, etc) where we include the current & caller stack frame, assuming the frame pointer and pc are saved to the stack, 1581545891.235902071 < 6

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg updated this revision to Diff 244275. clayborg added a comment. Added a test to cover breakpoint events. The test has an executable and a shared library and we set breakpoints in the main executable and in the shared library. When we run, we stop at the entry point to the program and th

[Lldb-commits] [lldb] 6e30fd0 - [lldb/Plugins] Move DynamicLoaderMacOS into DynamicLoaderMacOSXDYLD (NFCI)

Author: Jonas Devlieghere Date: 2020-02-12T13:44:20-08:00 New Revision: 6e30fd05c92dff39cc196fadaa0489b907b29be8 URL: https://github.com/llvm/llvm-project/commit/6e30fd05c92dff39cc196fadaa0489b907b29be8 DIFF: https://github.com/llvm/llvm-project/commit/6e30fd05c92dff39cc196fadaa0489b907b29be8.d

[Lldb-commits] [lldb] 654086c - [lldb/Plugins] Move SymbolFileDWARFDebugMap into SymbolFileDWARF (NFCI)

Author: Jonas Devlieghere Date: 2020-02-12T11:30:17-08:00 New Revision: 654086cbf548c8571affcb24f4a4a1cf54988756 URL: https://github.com/llvm/llvm-project/commit/654086cbf548c8571affcb24f4a4a1cf54988756 DIFF: https://github.com/llvm/llvm-project/commit/654086cbf548c8571affcb24f4a4a1cf54988756.d

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG7aabad131288: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D73860?vs=242661&id=2

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6e47a405a34: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl… (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D73808?v

[Lldb-commits] [PATCH] D74018: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG90a94c02fb24: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D74018?vs=24249

[Lldb-commits] [lldb] 7aabad1 - [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

Author: Vedant Kumar Date: 2020-02-12T11:24:03-08:00 New Revision: 7aabad131288a598c90903ae7d96383105ae3fc2 URL: https://github.com/llvm/llvm-project/commit/7aabad131288a598c90903ae7d96383105ae3fc2 DIFF: https://github.com/llvm/llvm-project/commit/7aabad131288a598c90903ae7d96383105ae3fc2.diff

[Lldb-commits] [lldb] 90a94c0 - [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

Author: Vedant Kumar Date: 2020-02-12T11:24:03-08:00 New Revision: 90a94c02fb243f0b49ee9933b0e8145147f84e32 URL: https://github.com/llvm/llvm-project/commit/90a94c02fb243f0b49ee9933b0e8145147f84e32 DIFF: https://github.com/llvm/llvm-project/commit/90a94c02fb243f0b49ee9933b0e8145147f84e32.diff

[Lldb-commits] [lldb] d6e47a4 - [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

Author: Vedant Kumar Date: 2020-02-12T11:24:02-08:00 New Revision: d6e47a405a3481c9c40ebe1c339349c01c504bd6 URL: https://github.com/llvm/llvm-project/commit/d6e47a405a3481c9c40ebe1c339349c01c504bd6 DIFF: https://github.com/llvm/llvm-project/commit/d6e47a405a3481c9c40ebe1c339349c01c504bd6.diff

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk marked an inline comment as done. vsk added a comment. Thanks everyone for the reviews! Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:29 +if (sizeof(std::string) == sizeof(garbage_string_sso)) +

[Lldb-commits] [PATCH] D74018: [lldb/LibCxx] Have ExtractLibcxxStringInfo return an Optional result, NFC

vsk marked 2 inline comments as done. vsk added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:507 size_mode_value = (size_mode->GetValueAsUnsigned(0)); short_mode = ((size_mode_value & 0x80) == 0); JDevlieghere wrote:

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

JDevlieghere added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:152 +ConstString func_name = sym_ctx.GetFunctionName(); +if (func_name == ConstString(function_name) || +alternate_function_name.empty() || teemperor wrot

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D73860#1872746 , @vsk wrote: > Ping, @teemperor do you have any concerns about this one? Didn't see Jonas comment when he accepted, sorry. LG

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk added a comment. Ping, @teemperor do you have any concerns about this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1871751 , @labath wrote: > In D74136#1870029 , @jingham wrote: > > > In D74136#1869622 , @kwk wrote: > > > > > @labath @jingham to summariz

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. This way the only bit of the matrix of "restricting function name breakpoints by containing source file" that we don't support is "set a breakpoint on this function, but ONLY when it is inlined into another CU, NOT when it is in its defining CU." That seems the least u

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

JDevlieghere added a comment. LGTM. I don't know how complex your script is, but could you include it in the commit message or the script directory so that we can run this again in the future? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74475/new/ https://reviews.llvm.org/D74475

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

JDevlieghere added a comment. In D74451#1871641 , @labath wrote: > Yeah, I expected something like this would be needed. This is fine, but I'd > call the files `ABIX86.h` instead of just `X86.h`, to match the names of the > classes and everything... Yu

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

JDevlieghere updated this revision to Diff 244205. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74451/new/ https://reviews.llvm.org/D74451 Files: lldb/source/API/SystemInitializerFull.cpp lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Plugins/ABI/AArch64/ABIAArch64.h

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Option

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg added a comment. Yes, I will add tests now that the code has been finalized! Thanks for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73665/new/ https://reviews.llvm.org/D73665 ___

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg accepted this revision. clayborg added a comment. Looks great, even more refactoring than asked. Thanks for sticking with this doing the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 ___

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 244160. anton.kolesov added a comment. Updated in attempt to reduce amount of code duplication between request_attach and request_launch. Built and tested with testsuite on Linux/x64, also built and manually tested on Windows/x64 host with a baremetal

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 244152. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1871932 , @labath wrote: > In D70840#1871862 , @mstorsjo wrote: > > > > Now someone might argue that the looking up the address of the `ldr` > > > opcode is wrong, because that i

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath added a comment. The whole flow here is pretty nonsensical -- the only reason we ask for the opcode is to get its size so we can put it into the Z0 packet -- however this is only needed for targets like arm, which have mutiple ISAs/opcodes, and we've already gotten complaints about sendi

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. Just one more thing I didn't catch in the previous round :(. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:461-481 +static void CollectRegNums(const RegisterInfo *reg_info, + lldb_priva

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1871862 , @mstorsjo wrote: > > Now someone might argue that the looking up the address of the `ldr` opcode > > is wrong, because that is not the actual pc value, and that we should > > lookup the address of `ldr+1`. In t

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

teemperor created this revision. teemperor added reviewers: shafik, jingham. Herald added subscribers: lldb-commits, JDevlieghere, christof. Herald added a project: LLDB. Currently when printing data types we include implicit scopes such as inline namespaces or anonymous namespaces. This leads to

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. In D73206#1866280 , @jankratochvil wrote: > In D73206#1859944 , @labath wrote: > > > From a high-level, this approach looks like it could be viable. However, > > you have taken this a lot f

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 244130. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Options.SupportsDebugEntryValues) MF.addCall

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1871745 , @labath wrote: > I did not send out any emails for this, but I did talk about this with > @dblaikie when I was in the US last week. My take from that is that we should > start by "fixing" llvm-symbolizer so t

[Lldb-commits] [lldb] 034c2c6 - [lldb/DWARF] Use DWARFDebugInfoEntry * in ElaboratingDIEIterator

Author: Pavel Labath Date: 2020-02-12T12:48:49+01:00 New Revision: 034c2c6771d318f962bbf001f00ee11e542e1180 URL: https://github.com/llvm/llvm-project/commit/034c2c6771d318f962bbf001f00ee11e542e1180 DIFF: https://github.com/llvm/llvm-project/commit/034c2c6771d318f962bbf001f00ee11e542e1180.diff

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is a good idea. I have glanced over the patch, and I have found a couple of places where your script gets things wrong. They all involve doing boolean expressions in the assertion

[Lldb-commits] [lldb] 7002128 - [LLDB] Fix GCC warnings about extra semicolons. NFC.

Author: Martin Storsjö Date: 2020-02-12T13:40:33+02:00 New Revision: 7002128ca935aa02be104e2a0c5812260990b074 URL: https://github.com/llvm/llvm-project/commit/7002128ca935aa02be104e2a0c5812260990b074 DIFF: https://github.com/llvm/llvm-project/commit/7002128ca935aa02be104e2a0c5812260990b074.diff

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted due to http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/21373/steps/build-stage3-compiler/logs/stdio. I will reland this as soon as I fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6ff07f8a39: [DebugInfo] Enable the debug entry values feature by default (authored by djtodoro). Herald added subscribers: lldb-commits, cfe-commits, jrtc27. Herald added projects: clang, LLDB. Changed

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#1870029 , @jingham wrote: > In D74136#1869622 , @kwk wrote: > > > @labath @jingham to summarize from what I read here and what I chatted > > about with @labath , the following is

[Lldb-commits] [lldb] 97ed706 - Revert "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-02-12T11:59:04+01:00 New Revision: 97ed706a962af7c6835c7b6716207c4072011ac1 URL: https://github.com/llvm/llvm-project/commit/97ed706a962af7c6835c7b6716207c4072011ac1 DIFF: https://github.com/llvm/llvm-project/commit/97ed706a962af7c6835c7b6716207c4072011ac1.d

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. I did not send out any emails for this, but I did talk about this with @dblaikie when I was in the US last week. My take from that is that we should start by "fixing" llvm-symbolizer so that it works reasonably in these cases. I'll use this

[Lldb-commits] [lldb] 320647c - [lldb] Pass a valid SourceLocation to Sema::RequireCompleteType in ASTResultSynthesizer

Author: Raphael Isemann Date: 2020-02-12T11:22:56+01:00 New Revision: 320647c02ae9827cae0824c6aec2bcdfcf482e44 URL: https://github.com/llvm/llvm-project/commit/320647c02ae9827cae0824c6aec2bcdfcf482e44 DIFF: https://github.com/llvm/llvm-project/commit/320647c02ae9827cae0824c6aec2bcdfcf482e44.dif

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

labath added a comment. Herald added a subscriber: wuzish. Yeah, I expected something like this would be needed. This is fine, but I'd call the files `ABIX86.h` instead of just `X86.h`, to match the names of the classes and everything... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

labath added a comment. I'm sorry about the delay, I'm quite busy these days. This code looks good to me now, but it's lacking test coverage. Can you add some test where new breakpoint locations get added or removed and check that the lldb-vscode generates the appropriate kind of dap message. A

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

labath added a comment. This approach looks good to me. It'd just be good to do something about the code duplication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 _

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. Just a couple of comments to make this code more llvm-y. Without those, we have just moved the place which constructs the temporary std::string. I haven't highlighted all the uses, but overall I'd recommend using the `Format` function or something similar instead of `Pri

[Lldb-commits] [lldb] 9f6ff07 - [DebugInfo] Enable the debug entry values feature by default

Author: Djordje Todorovic Date: 2020-02-12T10:25:14+01:00 New Revision: 9f6ff07f8a396dfc736c4cb6f9fba9a203531329 URL: https://github.com/llvm/llvm-project/commit/9f6ff07f8a396dfc736c4cb6f9fba9a203531329 DIFF: https://github.com/llvm/llvm-project/commit/9f6ff07f8a396dfc736c4cb6f9fba9a203531329.d

[Lldb-commits] [lldb] 30ce956 - [lldb][NFC] Remove GetConstTypeName and GetConstQualifiedTypeName from CompilerType

Author: Raphael Isemann Date: 2020-02-12T09:49:39+01:00 New Revision: 30ce956aec94ab3785025346a890f4a8cbbe1c58 URL: https://github.com/llvm/llvm-project/commit/30ce956aec94ab3785025346a890f4a8cbbe1c58 DIFF: https://github.com/llvm/llvm-project/commit/30ce956aec94ab3785025346a890f4a8cbbe1c58.dif

[Lldb-commits] [lldb] 440460f - [lldb][NFC] Move common_completions mapping out of CommandCompletions header.

Author: Raphael Isemann Date: 2020-02-12T09:48:51+01:00 New Revision: 440460f1e70193f5805e2fdbc6d91ab5d5d0bbab URL: https://github.com/llvm/llvm-project/commit/440460f1e70193f5805e2fdbc6d91ab5d5d0bbab DIFF: https://github.com/llvm/llvm-project/commit/440460f1e70193f5805e2fdbc6d91ab5d5d0bbab.dif

[Lldb-commits] [lldb] 4617fb0 - [lldb] Move implementation of GetDisplayName to TypeSystem class

Author: Raphael Isemann Date: 2020-02-12T09:32:09+01:00 New Revision: 4617fb0b7fd444dca9bf7612dd632ef3feb61d48 URL: https://github.com/llvm/llvm-project/commit/4617fb0b7fd444dca9bf7612dd632ef3feb61d48 DIFF: https://github.com/llvm/llvm-project/commit/4617fb0b7fd444dca9bf7612dd632ef3feb61d48.dif

[Lldb-commits] [lldb] 572fc89 - [lldb][NFC] Move all completer subclasses into source file

Author: Raphael Isemann Date: 2020-02-12T09:08:44+01:00 New Revision: 572fc8974277e5def25029219daec20d08f85030 URL: https://github.com/llvm/llvm-project/commit/572fc8974277e5def25029219daec20d08f85030 DIFF: https://github.com/llvm/llvm-project/commit/572fc8974277e5def25029219daec20d08f85030.dif