labath added a comment.

I'm sorry about the delay, I'm quite busy these days.

This code looks good to me now, but it's lacking test coverage. Can you add 
some test where new breakpoint locations get added or removed and check that 
the lldb-vscode generates the appropriate kind of dap message. And maybe 
another where a breakpoint is set via the the command line and check that we 
_don't_ emit any events...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73665/new/

https://reviews.llvm.org/D73665



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to