[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should onl

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:733 // Finally, start monitoring the child process for change in state. - m_monitor_thread = Host::StartMonitoringChildProcess( + auto monitor_thread = Host::StartMonitoringChildPro

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen abandoned this revision. devnexen added a comment. Just realised there was an existing PR addressing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen updated this revision to Diff 224256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. This was probably due to: Expected(Error Err) : HasError(true) #if LLVM_ENABLE_ABI_BREAKING_CHECKS // Expected is unchecked upon construction in Debug builds. , Unchecked(true) #endif { assert(Err && "Cannot create Expected fr

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen added a comment. With this I do not get segfault anymore. @dim I just looked up the patch on FreeBSD, if this approach is preferred, I ll go along. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen created this revision. devnexen added reviewers: dim, jbeich. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, JDevlieghere, emaste. Herald added a project: LLDB. devnexen added a comment. With this I do not get segfault anymore. @dim I jus

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added subscribers: teemperor, mgorny. Herald added a project: LLDB. JDevlieghere added a reviewer: friss. JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. C

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(

[Lldb-commits] [PATCH] D68750: Implement serialization and deserialization of scripted points

jingham created this revision. jingham added a reviewer: teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This allows you to use "break read" and "break write" for scripted breakpoints. This is the test Raphael was offering to have Jan write in, plus

[Lldb-commits] [lldb] r374264 - Change debugserver to use the brk #0 for breakpoints.

Author: jmolenda Date: Wed Oct 9 17:12:05 2019 New Revision: 374264 URL: http://llvm.org/viewvc/llvm-project?rev=374264&view=rev Log: Change debugserver to use the brk #0 for breakpoints. debugserver had been using an instruction that would work for armv7 or aarch64 processes, but we don't h

[Lldb-commits] [lldb] r374262 - TestMTCSimple.py: allow the test to run on Darwin embedded platforms

Author: friss Date: Wed Oct 9 16:52:31 2019 New Revision: 374262 URL: http://llvm.org/viewvc/llvm-project?rev=374262&view=rev Log: TestMTCSimple.py: allow the test to run on Darwin embedded platforms The test needed some updates to run using a different UI toolkit and with a different libMTC, bu

[Lldb-commits] [PATCH] D68745: TestFileHandle.py: fix for Python 3.6

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Python 3.6 stringifies exceptions as `ExceptionClass("foo",)` instead of `ExceptionClass("foo")`. This patch makes the test assertions a little more flexible so

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224197. aprantl added a comment. Added a `if (!has_qualified_name_hash)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + l

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. (and my patch is meant primarily for the non-dsym case) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. In D68678#1702418 , @clayborg wrote: > That qualified name hash the Apple tables used to avoid pulling in DWARF for > stuff that didn't match. Did this functionality stop working when accelerator > tables got refactored? The .app

[Lldb-commits] [lldb] r374256 - TestIndirectSymbols: Modernize the Makefile

Author: friss Date: Wed Oct 9 15:47:28 2019 New Revision: 374256 URL: http://llvm.org/viewvc/llvm-project?rev=374256&view=rev Log: TestIndirectSymbols: Modernize the Makefile This old test used a completely hand-rolled Makefile. Modernize so that it's able to cross-compile. And XFAIL the test as

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224193. aprantl added a comment. Address feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1a509417714d: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR (authored by hhb). Repository: rG LLVM Github

[Lldb-commits] [lldb] r374251 - Makefile.rules: add missing CODESIGN call

Author: friss Date: Wed Oct 9 15:35:56 2019 New Revision: 374251 URL: http://llvm.org/viewvc/llvm-project?rev=374251&view=rev Log: Makefile.rules: add missing CODESIGN call When building an executable and a shared library at the same time (yes, Makefile.rules is setup to do this!) the executable

[Lldb-commits] [lldb] r374250 - [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

Author: hhb Date: Wed Oct 9 15:34:55 2019 New Revision: 374250 URL: http://llvm.org/viewvc/llvm-project?rev=374250&view=rev Log: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR Summary: Fixes issue like D68719 Reviewers: tatyana-krasnukha Subscribers: mgorny, lldb-commits Tags: #l

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

On Wed, 09 Oct 2019 21:21:44 +0200, Jonas Devlieghere wrote: > I finally managed to reproduce and check-lldb was indeed broken. I've > fixed it when re-landing the patch in r374201. Yes, it does check-lldb now (47363a148f1d3003f0dd1cce234b60cdc8cc48bd). Thanks, Jan -

[Lldb-commits] [PATCH] D68088: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9276b7d723: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in… (authored by clayborg). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + l

[Lldb-commits] [lldb] r374246 - Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps

Author: gclayton Date: Wed Oct 9 15:16:12 2019 New Revision: 374246 URL: http://llvm.org/viewvc/llvm-project?rev=374246&view=rev Log: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps Stack unwinding was sometimes failing when trying to unwind stacks in 32

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + c

[Lldb-commits] [lldb] r374244 - [CMake] Use the correct lit.cfg.py

Author: jdevlieghere Date: Wed Oct 9 15:09:57 2019 New Revision: 374244 URL: http://llvm.org/viewvc/llvm-project?rev=374244&view=rev Log: [CMake] Use the correct lit.cfg.py Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-pr

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This makes SBFile::GetFile public and adds a SWIG typemap to convert the result back into a python native file. If the underlying File itself came from a python

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0156be59b45d: Fix a crasher due to an assert when two files have the same UUID but different… (authored by clayborg). Changed prior to commit: https://reviews.llvm.org/D68106?vs=222032&id=224185#toc Re

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Jaroslav, I apologize for taking so long to look at this; I've been heads-down on a project the past few weeks an my email inbox is a disaster right now. This patch looks good,

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + Are these really for public consumption? I would hope no

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a subscriber: aprantl. Herald added a project: LLDB. If you look at what this test is doing, it's actually quite mysterious why it works at all. It sets the input file inside a

[Lldb-commits] [lldb] r374242 - Fix a crasher due to an assert when two files have the same UUID but different paths.

Author: gclayton Date: Wed Oct 9 15:03:15 2019 New Revision: 374242 URL: http://llvm.org/viewvc/llvm-project?rev=374242&view=rev Log: Fix a crasher due to an assert when two files have the same UUID but different paths. Summary: The PlaceholderObjectFile has an assert in SetLoadAddress that fir

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da2bc22badd: remove a smattering of isolated, unnecessary uses of FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/ne

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb137192364: SBFile support in SBCommandReturnObject (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68434?vs=223980&id=224179#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb24022cd723f: SBFile: add a bunch of tests that should eventually work. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68433?vs=223979&id=224178#toc Repository: rG L

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68433: SBFile: add a bunch of tests that should eventually work.. This patch adds FileSP versions of SetInputFile(), Set

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg added a comment. That qualified name hash the Apple tables used to avoid pulling in DWARF for stuff that didn't match. Did this functionality stop working when accelerator tables got refactored? The .apple_types has a qualified name hash which is the hash of the complete type named (de

[Lldb-commits] [lldb] r374237 - SBFile: add a bunch of tests that should eventually work.

Author: lawrence_danna Date: Wed Oct 9 14:50:46 2019 New Revision: 374237 URL: http://llvm.org/viewvc/llvm-project?rev=374237&view=rev Log: SBFile: add a bunch of tests that should eventually work. Summary: It's really annoying and confusing to have to keep referring back to earlier versions of

[Lldb-commits] [lldb] r374239 - remove a smattering of isolated, unnecessary uses of FILE*

Author: lawrence_danna Date: Wed Oct 9 14:50:52 2019 New Revision: 374239 URL: http://llvm.org/viewvc/llvm-project?rev=374239&view=rev Log: remove a smattering of isolated, unnecessary uses of FILE* Summary: There a a few call sites that use FILE* which are easy to fix without disrupting anythin

[Lldb-commits] [lldb] r374238 - SBFile support in SBCommandReturnObject

Author: lawrence_danna Date: Wed Oct 9 14:50:49 2019 New Revision: 374238 URL: http://llvm.org/viewvc/llvm-project?rev=374238&view=rev Log: SBFile support in SBCommandReturnObject Summary: This patch add SBFile interfaces to SBCommandReturnObject, and removes the internal callers of its FILE* in

[Lldb-commits] [lldb] r374236 - [Reproducer] Add convenience methods IsCapturing and IsReplaying.

Author: jdevlieghere Date: Wed Oct 9 14:47:49 2019 New Revision: 374236 URL: http://llvm.org/viewvc/llvm-project?rev=374236&view=rev Log: [Reproducer] Add convenience methods IsCapturing and IsReplaying. Add convenience methods to the Reproducer class for when you don't need access to the genera

[Lldb-commits] [lldb] r374234 - TestHelloWorld: Make compatible with remote testing

Author: friss Date: Wed Oct 9 14:41:02 2019 New Revision: 374234 URL: http://llvm.org/viewvc/llvm-project?rev=374234&view=rev Log: TestHelloWorld: Make compatible with remote testing The synchronization token handling was not remote-friendly. Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22314179f066: [test] Split LLDB tests into API, Shell & Unit (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D68606?vs=224072&id=224087#toc Repository: rG LLVM Github Mo

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

I finally managed to reproduce and check-lldb was indeed broken. I've fixed it when re-landing the patch in r374201. On Wed, Oct 9, 2019 at 11:16 AM Jan Kratochvil wrote: > > On Wed, 09 Oct 2019 19:58:35 +0200, Jonas Devlieghere wrote: > > Can you try a clean build as opposed to incremental? > >

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

On Wed, 09 Oct 2019 19:58:35 +0200, Jonas Devlieghere wrote: > Can you try a clean build as opposed to incremental? This is what I do, indicated by that: #rm -rf * (I did put there a # so that someone does not accidentally delete his whole world during a copy-paste.) It rather worked bef

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

Can you try a clean build as opposed to incremental? Before landing I checked that it worked for me for both a clean and incremental build, but it seems like at least GreenDragon had some issues with the incremental one. On Wed, Oct 9, 2019 at 10:27 AM Jan Kratochvil via Phabricator wrote: > > ja

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

jankratochvil added a comment. Before this patch I was getting : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=c

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

JDevlieghere updated this revision to Diff 224072. JDevlieghere added a comment. Herald added a reviewer: alexshap. Rename `lit` to `test` to decrease the number of renames in the git history. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 File

Re: [Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

I'll have a look, sorry about that. On Wed, Oct 9, 2019 at 4:37 PM Shafik Yaghmour via Phabricator < revi...@reviews.llvm.org> wrote: > shafik added a comment. > > This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2

[Lldb-commits] [lldb] r374231 - [LLDB] Fix for regression of test 'TestDataFormatterInvalidStdUniquePtr.py' introduced in r374195

Author: cameron314 Date: Wed Oct 9 14:15:48 2019 New Revision: 374231 URL: http://llvm.org/viewvc/llvm-project?rev=374231&view=rev Log: [LLDB] Fix for regression of test 'TestDataFormatterInvalidStdUniquePtr.py' introduced in r374195 Differential Revision: https://reviews.llvm.org/D68641 Modif

[Lldb-commits] [lldb] r374195 - [LLDB] Fix for synthetic children memory leak

Author: cameron314 Date: Wed Oct 9 11:27:33 2019 New Revision: 374195 URL: http://llvm.org/viewvc/llvm-project?rev=374195&view=rev Log: [LLDB] Fix for synthetic children memory leak The lifetime of a ValueObject and all its derivative ValueObjects (children, clones, etc.) is managed by a Cluste

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224166. hhb added a comment. Simplify the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. I've committed a fix in rG745e57c5939e . Sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [PATCH] D68731: Remove CC autodetection from Makefile.rules

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere, labath. Auto-detecting CC in Makefile.rules is no longer useful. Every since out-of-tree builds you are better off just running lldb-dotest which sets it directly. This also makes it harder to accidentally unset CC in a

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/TestCP

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

hhb added a comment. I think this is caused by D68442 . Can you check whether D68728 fixes it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68719/new/ https://reviews.llvm.org/D68719 __

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

This revision was automatically updated to reflect the committed changes. Closed by commit rG988ad4194848: [LLDB] Remove standalone build dep on llvm-strip (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D68614?vs=224148&id=224160#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb created this revision. hhb added a reviewer: tatyana-krasnukha. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 224159. hhb added a comment. Fix format Fixes issue like D68719 Repository: rG

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224159. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ==

[Lldb-commits] [lldb] r374229 - [LLDB] Remove standalone build dep on llvm-strip

Author: jdevlieghere Date: Wed Oct 9 14:06:03 2019 New Revision: 374229 URL: http://llvm.org/viewvc/llvm-project?rev=374229&view=rev Log: [LLDB] Remove standalone build dep on llvm-strip When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_ta

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:114 + + // When searching for "std::vector::const_iterator", reject any + // files without "vector" early, since there will be many other This comment gives

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG21b8a8ae27f3: allow arbitrary python streams to be converted to SBFile (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/

[Lldb-commits] [lldb] r374226 - Revert "[lldb] Calculate relative path for symbol links"

Author: jingham Date: Wed Oct 9 13:56:43 2019 New Revision: 374226 URL: http://llvm.org/viewvc/llvm-project?rev=374226&view=rev Log: Revert "[lldb] Calculate relative path for symbol links" This reverts commit 958091c209d0a92e38b9cb27fb77a0ff7da11853. This commit incorrectly sets the _lldb.so s

[Lldb-commits] [lldb] r374225 - allow arbitrary python streams to be converted to SBFile

Author: lawrence_danna Date: Wed Oct 9 13:56:17 2019 New Revision: 374225 URL: http://llvm.org/viewvc/llvm-project?rev=374225&view=rev Log: allow arbitrary python streams to be converted to SBFile Summary: This patch adds SWIG typemaps that can convert arbitrary python file objects into lldb_pri

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

friss created this revision. friss added reviewers: teemperor, labath. Herald added a project: LLDB. This commit adds platform selection/connection commands to the base PExpectTest class. I doesn't look like any of the current tests are really interesting to test remotely, but it's easy enough to

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 224147. gmittert added a comment. Updated/Rebased for the rename of lit->test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 224148. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224145. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/TestCP

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik added a comment. This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2411/testReport/ I verified that reverting this commit fixes the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] r374217 - Skip Apple simulator test for all remote testing scenarios.

Author: friss Date: Wed Oct 9 13:39:04 2019 New Revision: 374217 URL: http://llvm.org/viewvc/llvm-project?rev=374217&view=rev Log: Skip Apple simulator test for all remote testing scenarios. The test makes no sense to run remotely, period. The architecture of the target is not the discriminant h

[Lldb-commits] [lldb] r374216 - [CMake] Fix add_lldb_test_dependency

Author: jdevlieghere Date: Wed Oct 9 13:36:29 2019 New Revision: 374216 URL: http://llvm.org/viewvc/llvm-project?rev=374216&view=rev Log: [CMake] Fix add_lldb_test_dependency This function would ignore all but the first argument. Now it correctly adds every dependency by iterating over its argum

[Lldb-commits] [PATCH] D68678: WIP: Speed up accelerator table lookups

aprantl updated this revision to Diff 224140. aprantl added a comment. Now with testcase! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/ll

[Lldb-commits] [lldb] r374215 - [utils] Update lldb-dotest for new test layout

Author: jdevlieghere Date: Wed Oct 9 13:30:54 2019 New Revision: 374215 URL: http://llvm.org/viewvc/llvm-project?rev=374215&view=rev Log: [utils] Update lldb-dotest for new test layout The path to dotest.py changed after the test directory reorganization. Modified: lldb/trunk/utils/lldb-dot

[Lldb-commits] [lldb] r374212 - [test] Skip entry value test when clang < 10.0.0

Author: vedantk Date: Wed Oct 9 13:21:33 2019 New Revision: 374212 URL: http://llvm.org/viewvc/llvm-project?rev=374212&view=rev Log: [test] Skip entry value test when clang < 10.0.0 clang-9 emitted the wrong opcode for entry values on Darwin. rdar://56119661 Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim created this revision. dim added reviewers: devnexen, emaste, MaskRay, mgorny. Herald added a subscriber: krytarowski. dim added a comment. After rLLDB365761 , and with `LLVM_ENABLE_ABI_BREAKING_CHECKS` enabled, launching any process on FreeBSD crashes ll

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. In D62931#1699746 , @labath wrote: > In D62931#1697999 , @guiandrade > wrote: > > > Thank you for looking into this, @labath > > > > I'd like to fix that, but I'm not sure if I understan

[Lldb-commits] [lldb] r374201 - Re-land "[test] Split LLDB tests into API, Shell & Unit"

Added: lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test?rev=374201&view=auto == --- lldb/trunk/test/Shell/SymbolFile/PDB/typedef

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 224120. guiandrade added a comment. Dissociating the use of g/G packets and trying to address the AVX/MPX offset bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224122. lawrence_danna added a comment. Pavel would slightly prefer if the PyObject_GetBuffer happened in the Create function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llv

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. My hope was that something like -find=variable -dump-clang-ast would make sense at least from a theoretical perspective. However, after reading to source code, it looks like that may not be tr

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 224119. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: ll

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

This revision was automatically updated to reflect the committed changes. Closed by commit rG609010d0631a: protect libedit and LLDB gui from receiving null FILE* streams (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6867

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1284 + PythonBuffer(PythonObject &obj, int flags) : m_buffer({}) { +PyObject_GetBuffe

[Lldb-commits] [lldb] r374197 - protect libedit and LLDB gui from receiving null FILE* streams

Author: lawrence_danna Date: Wed Oct 9 11:43:03 2019 New Revision: 374197 URL: http://llvm.org/viewvc/llvm-project?rev=374197&view=rev Log: protect libedit and LLDB gui from receiving null FILE* streams Summary: We now have valid files that will return NULL from GetStream(). libedit and the LLDB

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224114. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed pybuffer error handling weirdness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.l

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG89386daa9571: [LLDB] Fix for synthetic children memory leak (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D68641?vs=223919&id=224112#toc Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: hhb. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. The script failed to make a symlink for liblldb.dll because it tried to find it in //__build_root__/bin// whereas Visual

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik I just pushed a fix, the issue was because on mac there are more unnamed symbols so the number didn't match, I changed it to match any number since this can easily change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] r374192 - Update breakpad lit test to be independent of the unnamed symbol number

Author: aadsm Date: Wed Oct 9 11:02:59 2019 New Revision: 374192 URL: http://llvm.org/viewvc/llvm-project?rev=374192&view=rev Log: Update breakpad lit test to be independent of the unnamed symbol number Modified: lldb/trunk/lit/SymbolFile/Breakpad/symtab.test Modified: lldb/trunk/lit/Symbol

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

jingham added a comment. I have no memory of adding the 'addr' parameter. If you had a search that was guaranteed to only return one address per invocation, this would allow you to have the searcher coordinate gathering the results, rather than having the callback record them on its own. That

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Please go ahead! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r374187 - Revert [test] Split LLDB tests into API, Shell & Unit

Added: lldb/trunk/lit/helper/__init__.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/helper/__init__.py?rev=374187&view=auto == (empty) Added: lldb/trunk/lit/helper/build.py URL: http://llvm.org/viewvc/ll

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

jingham accepted this revision. jingham added a comment. One of the oddities of the Search -> Search callback stuff is that the Searcher's Filter might be narrower than the level at which the Search Callback wants to be invoked. The former is whatever the user actually wants limit the search t

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik thanks, checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

  1   2   >