JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316
 
-# Use a shared module cache when building in the default test build directory.
-CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed 
$(QUOTE)s/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/$(QUOTE))
----------------
We should have a fallback here that defaults to `$(BUILDDIR)/module-cache` if 
the variable is not set in the environment.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68755/new/

https://reviews.llvm.org/D68755



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to