aprantl created this revision. aprantl added reviewers: friss, JDevlieghere, labath.
Auto-detecting CC in Makefile.rules is no longer useful. Every since out-of-tree builds you are better off just running lldb-dotest which sets it directly. This also makes it harder to accidentally unset CC in a Makefile. https://reviews.llvm.org/D68731 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules Index: lldb/packages/Python/lldbsuite/test/make/Makefile.rules =================================================================== --- lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -171,15 +171,8 @@ # o cxx_compiler # o cxx_linker #---------------------------------------------------------------------- -CC ?= clang -ifeq "$(CC)" "cc" - ifneq "$(shell which clang)" "" - CC = clang - else ifneq "$(shell which clang-3.5)" "" - CC = clang-3.5 - else ifneq "$(shell which gcc)" "" - CC = gcc - endif +ifeq "$(CC)" "" +$(error "C compiler is not specified. Please run tests through lldb-dotest or lit") endif #----------------------------------------------------------------------
Index: lldb/packages/Python/lldbsuite/test/make/Makefile.rules =================================================================== --- lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -171,15 +171,8 @@ # o cxx_compiler # o cxx_linker #---------------------------------------------------------------------- -CC ?= clang -ifeq "$(CC)" "cc" - ifneq "$(shell which clang)" "" - CC = clang - else ifneq "$(shell which clang-3.5)" "" - CC = clang-3.5 - else ifneq "$(shell which gcc)" "" - CC = gcc - endif +ifeq "$(CC)" "" +$(error "C compiler is not specified. Please run tests through lldb-dotest or lit") endif #----------------------------------------------------------------------
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
