[Lldb-commits] [lldb] r358550 - Clear the output string passed to GetHostName()

Author: asmith Date: Tue Apr 16 20:13:06 2019 New Revision: 358550 URL: http://llvm.org/viewvc/llvm-project?rev=358550&view=rev Log: Clear the output string passed to GetHostName() LLVM's wchar to UTF8 conversion routine expects an empty string to store the output. GetHostName() on Windows is so

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 195504. asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PEC

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe added a comment. Thanks! Please let me know if it happens again and I'll try my best to debug it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60153/new/ https://reviews.llvm.org/D60153 ___ lldb-commits mailin

[Lldb-commits] [lldb] r358533 - [tools] Only build lldb-test when needed.

Author: davide Date: Tue Apr 16 14:56:07 2019 New Revision: 358533 URL: http://llvm.org/viewvc/llvm-project?rev=358533&view=rev Log: [tools] Only build lldb-test when needed. Modified: lldb/trunk/tools/CMakeLists.txt Modified: lldb/trunk/tools/CMakeLists.txt URL: http://llvm.org/viewvc/llvm

[Lldb-commits] [lldb] r358530 - [Process] Fix linux arm64 single step compilation failure

Author: xiaobai Date: Tue Apr 16 14:21:28 2019 New Revision: 358530 URL: http://llvm.org/viewvc/llvm-project?rev=358530&view=rev Log: [Process] Fix linux arm64 single step compilation failure This was updated in r356703 to use llvm::sys::RetryAfterSignal, which comes from llvm/Support/Errno.h. Th

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358528: [tools] Make vscode and lldb-instr optional. (authored by davide, committed by ). Changed prior to commit: https://reviews.llvm.org/D60780?vs=195454&id=195459#toc Repository: rLLDB LLDB C

[Lldb-commits] [lldb] r358528 - [tools] Make vscode and lldb-instr optional.

Author: davide Date: Tue Apr 16 14:15:28 2019 New Revision: 358528 URL: http://llvm.org/viewvc/llvm-project?rev=358528&view=rev Log: [tools] Make vscode and lldb-instr optional. Summary: Saves some build times, and they're not part of the usual developer workflow. Reviewers: JDevlieghere, friss

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

davide updated this revision to Diff 195454. davide added a comment. Jonas' comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780 Files: lldb/cmake/modules/AddLLDB.cmake lldb/lit/CMakeLists.txt lld

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780

[Lldb-commits] [lldb] r358525 - [debugserver] Relax the codesigning identity check

Author: friss Date: Tue Apr 16 13:54:42 2019 New Revision: 358525 URL: http://llvm.org/viewvc/llvm-project?rev=358525&view=rev Log: [debugserver] Relax the codesigning identity check In an effort to help new LLDB developers, we added checks and messaging around the selection of your codesigning i

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:145 + +macro(add_lldb_optional_tool_subdirectory name) + add_llvm_subdirectory(LLDB TOOL ${name}) Let's drop optional from the name Comment at: lldb/lit/lit.site.

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

davide updated this revision to Diff 195443. davide added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780 Files: lldb/cmake/modules/AddLLDB.cmake lldb/lit/lit.site.cfg.py.in lldb/l

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195422. kubamracek added a comment. Updating test to use run_to_source_breakpoint CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

stella.stamenova added a comment. I ran local tests with this and a couple of the tests from the lldb suite failed: lldb-Suite :: functionalities/inferior-crashing/TestInferiorCrashing.py lldb-Suite :: functionalities/thread/crash_during_step/TestCrashDuringStep.py Here's the error from one

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere added a comment. In D60780#1468927 , @labath wrote: > LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In > fact, if we started using the llvm cmake macros like `add_llvm_subdirectory`, > it would handle this automatic

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

jingham added a comment. One picky comment about the test, otherwise this looks good to me. Pavel had his hands in this code most recently, however, so we should wait on his opinion. Comment at: packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVariables.py:

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

labath added a comment. LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In fact, if we started using the llvm cmake macros like `add_llvm_subdirectory`, it would handle this automatically, including creating the cache variable. The only difference would be that the varia

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

kubamracek updated this revision to Diff 195413. kubamracek added a comment. Adding a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 Files: packages/Python/lldbsuite/test/lang/cpp/global_variables/Makefile packages/Python/lldbsu

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

davide added a comment. OK, on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We need to define these variables in the cache and make sure the test suite knows about them. For lldb-instr for example, which lives in lit/tools/lldb-instr, you'd have

[Lldb-commits] [lldb] r358508 - Fix symtab-macho.test broken by r358500

Author: labath Date: Tue Apr 16 09:57:41 2019 New Revision: 358508 URL: http://llvm.org/viewvc/llvm-project?rev=358508&view=rev Log: Fix symtab-macho.test broken by r358500 Put the correct UUID string into the breakpad file. Modified: lldb/trunk/lit/SymbolFile/Breakpad/Inputs/symtab-macho.sy

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

davide created this revision. davide added reviewers: JDevlieghere, friss. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Saves some build times, and they're not part of the usual developer workflow. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:60 + llvm::StringRef pdb_file; + if (!COFFObj->getDebugPDBInfo(pdb_info, pdb_file) && pdb_info) +return UUID::fromOptionalData(pdb_info->PDB70.Signature); Hui wr

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

clayborg added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); Confused as to

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

Hui added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:60 + llvm::StringRef pdb_file; + if (!COFFObj->getDebugPDBInfo(pdb_info, pdb_file) && pdb_info) +return UUID::fromOptionalData(pdb_info->PDB70.Signature); labath wr

[Lldb-commits] [lldb] r358500 - Breakpad: Match the new UUID algorithm in minidumps

Author: labath Date: Tue Apr 16 07:51:47 2019 New Revision: 358500 URL: http://llvm.org/viewvc/llvm-project?rev=358500&view=rev Log: Breakpad: Match the new UUID algorithm in minidumps D59433 and D60501 changed the way UUIDs are computed from minidump files. This was done to synchronize the U(G)U

[Lldb-commits] [lldb] r358499 - test/PECOFF: Remove REQUIRES: system-windows

Author: labath Date: Tue Apr 16 07:51:27 2019 New Revision: 358499 URL: http://llvm.org/viewvc/llvm-project?rev=358499&view=rev Log: test/PECOFF: Remove REQUIRES: system-windows These tests run fine on non-windows platforms too. Instead I add REQUIRES: lld, as that is what they really require. M

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:420 + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg wrote: > There is a variant of FileSpe

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:61 + if (!COFFObj->getDebugPDBInfo(pdb_info, pdb_file) && pdb_info) +return UUID::fromOptionalData(pdb_info->PDB70.Signature); + Is there a specific reason you us

[Lldb-commits] [PATCH] D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan

This revision was automatically updated to reflect the committed changes. Closed by commit rL358479: Fix typo in ArmUnwindInfo::GetUnwindPlan (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [lldb] r358479 - Fix typo in ArmUnwindInfo::GetUnwindPlan

Author: teemperor Date: Tue Apr 16 01:06:56 2019 New Revision: 358479 URL: http://llvm.org/viewvc/llvm-project?rev=358479&view=rev Log: Fix typo in ArmUnwindInfo::GetUnwindPlan Summary: As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We want to check for `11010nnn`, s

[Lldb-commits] [PATCH] D60653: Correctly check if a warning message lacks a trailing new line

This revision was automatically updated to reflect the committed changes. Closed by commit rL358477: Correctly check if a warning message lacks a trailing new line (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [lldb] r358477 - Correctly check if a warning message lacks a trailing new line

Author: teemperor Date: Tue Apr 16 00:48:11 2019 New Revision: 358477 URL: http://llvm.org/viewvc/llvm-project?rev=358477&view=rev Log: Correctly check if a warning message lacks a trailing new line Summary: Fixes LLVM bug 41489. Reviewers: clayborg Reviewed By: clayborg Subscribers: lldb-comm

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

teemperor updated this revision to Diff 195310. teemperor removed a reviewer: espindola. teemperor added a comment. Herald added a reviewer: espindola. - Made empty/nullptr check more readable. - Removed some uses of the new comparison operator for cases where we don't have a literal to compare a

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

teemperor marked 2 inline comments as done. teemperor added a comment. In D60667#1467387 , @amccarth wrote: > I, too, have some concern that this could have unintended side effects. To > make the temporary `StringRef`s from the zero-terminated strings re

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath edited reviewers, added: amccarth, labath; removed: zturner, llvm-commits. labath added a subscriber: amccarth. labath added a comment. s/@zturner/@amccarth, as Zach probably won't have time to review this Comment at: lit/Modules/PECOFF/export-dllfunc.yaml:11-12 + +# ti