hintonda added inline comments.
Comment at: include/lldb/Utility/FileSpec.h:65-69
+ enum PathSyntax : unsigned char {
ePathSyntaxPosix,
ePathSyntaxWindows,
ePathSyntaxHostNative
};
zturner wrote:
> hintonda wrote:
> > zturner wrote:
> > > This
Author: jmolenda
Date: Wed Nov 1 20:17:07 2017
New Revision: 317183
URL: http://llvm.org/viewvc/llvm-project?rev=317183&view=rev
Log:
Revert r317182 for https://reviews.llvm.org/D39128
we're still failing on android. I'll ask Larry to
ask Pavel for any tips he might be able to give.
Modified:
Author: jmolenda
Date: Wed Nov 1 19:43:27 2017
New Revision: 317182
URL: http://llvm.org/viewvc/llvm-project?rev=317182&view=rev
Log:
Commit Lawrence D'Anna's patch to change
SetOututFileHandle to work with IOBase.
I did make one change after checking with Larry --
I renamed SBDebugger::Flush to
Author: jmolenda
Date: Wed Nov 1 19:33:59 2017
New Revision: 317181
URL: http://llvm.org/viewvc/llvm-project?rev=317181&view=rev
Log:
A roll back that commit, I didn't see that Lawrence had filed
a separate phabracator with the revised change. This was his
first atttempt which broke on the b
Author: jmolenda
Date: Wed Nov 1 19:02:56 2017
New Revision: 317180
URL: http://llvm.org/viewvc/llvm-project?rev=317180&view=rev
Log:
Commit Lawrence D'Anna's patch to change
SetOututFileHandle to work with IOBase.
I did make one change after checking with Larry --
I renamed SBDebugger::Flush to
zturner added inline comments.
Comment at: include/lldb/Utility/FileSpec.h:65-69
+ enum PathSyntax : unsigned char {
ePathSyntaxPosix,
ePathSyntaxWindows,
ePathSyntaxHostNative
};
hintonda wrote:
> zturner wrote:
> > This is actually a very nic
hintonda abandoned this revision.
hintonda added a comment.
Okay, got the message.
Sorry for the noise.
https://reviews.llvm.org/D39436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
hintonda added inline comments.
Comment at: include/lldb/Utility/FileSpec.h:65-69
+ enum PathSyntax : unsigned char {
ePathSyntaxPosix,
ePathSyntaxWindows,
ePathSyntaxHostNative
};
zturner wrote:
> This is actually a very nice change, as it red
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
IIUC, Zachary, Greg and I have all said we don't think adding regular
expressions patterns to FileSpec is a good idea. I'm not sure why you are
pursuing this avenue.
Of course, i
labath added a comment.
In case there isn't enough people disagreeing, I'd like to say that I also
think this does not belong in FileSpec. If for nothing else, then for the
FileSpec::Equal implementation: the semantics of the IsEqual method are
complicated enough to follow even without having r
zturner added inline comments.
Comment at: include/lldb/Utility/FileSpec.h:65-69
+ enum PathSyntax : unsigned char {
ePathSyntaxPosix,
ePathSyntaxWindows,
ePathSyntaxHostNative
};
This is actually a very nice change, as it reduces the size of `
hintonda updated this revision to Diff 121214.
hintonda added a comment.
Addressed @clayborg's comments.
- Added FileSpec ctor that takes an explicit RegularExpression object when
using FileSpec as a regex pattern.
- Removed the RegularExpression member variable, added a flag, and create the
r
Author: davide
Date: Wed Nov 1 16:49:23 2017
New Revision: 317145
URL: http://llvm.org/viewvc/llvm-project?rev=317145&view=rev
Log:
[Core] Comparison for unsigned >= 0 is redundant. NFCI.
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
Modified: lldb/trunk/source/Core/ArchSpec.cpp
URL:
http:
Author: davide
Date: Wed Nov 1 16:48:07 2017
New Revision: 317144
URL: http://llvm.org/viewvc/llvm-project?rev=317144&view=rev
Log:
[XML] Simplify lambda removing unused capture. NFCI.
Modified:
lldb/trunk/source/Host/common/XML.cpp
Modified: lldb/trunk/source/Host/common/XML.cpp
URL:
http
Author: davide
Date: Wed Nov 1 16:46:21 2017
New Revision: 317143
URL: http://llvm.org/viewvc/llvm-project?rev=317143&view=rev
Log:
[Interpreter] Remove unused variable usage. NFCI.
Modified:
lldb/trunk/source/Interpreter/OptionValueDictionary.cpp
Modified: lldb/trunk/source/Interpreter/Opt
jingham added a comment.
Setting categories on directories seems much less useful if you then have to
scan through all the tests and see if any of the tests in the directories
you've added categories to implement getCategories then add the new category to
the return from getCategories list as w
clayborg added a comment.
No objections from me as I don't use these categories.
https://reviews.llvm.org/D39515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
Does anyone care about these tests being in the basic_process category?
The getCategories function is interfering with the filesystem-based
watchpoint category kicking in. If there's any interest in keeping it,
then I can certainly make it happen. However, I haven't s
Author: labath
Date: Wed Nov 1 15:01:03 2017
New Revision: 317130
URL: http://llvm.org/viewvc/llvm-project?rev=317130&view=rev
Log:
dotest: consistently call finalize_build_dictionary in debug info variants
dwarf&dwo versions were doing it, but gmodules and dsym weren't. All
this function does r
Author: jmolenda
Date: Wed Nov 1 14:55:35 2017
New Revision: 317129
URL: http://llvm.org/viewvc/llvm-project?rev=317129&view=rev
Log:
add LibCxxTuple.cpp, LibCxxQueue.cpp to xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.p
hintonda added a comment.
In https://reviews.llvm.org/D39436#912910, @zturner wrote:
>
>> I haven't had time to really look into this, but it seems that maintaining
>> two independent strings, one for directory and one for basename, is just for
>> convenience. We could easily keep it in a
clayborg added a comment.
And yes, the memory savings are quite large as well when sharing directories.
https://reviews.llvm.org/D39436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
clayborg added a comment.
The main reason for two strings is for searching efficiency. Most people don't
set breakpoints using full paths, they give the basename:
(lldb) b main.c:12
When setting breakpoints is it very easy to search for matches by basename
since this is what users usually ty
zturner added a comment.
In https://reviews.llvm.org/D39436#912902, @hintonda wrote:
> In https://reviews.llvm.org/D39436#912829, @clayborg wrote:
>
> > In https://reviews.llvm.org/D39436#912828, @zturner wrote:
> >
> > > In https://reviews.llvm.org/D39436#912810, @clayborg wrote:
> > >
> > > > I
hintonda added a comment.
In https://reviews.llvm.org/D39436#912829, @clayborg wrote:
> In https://reviews.llvm.org/D39436#912828, @zturner wrote:
>
> > In https://reviews.llvm.org/D39436#912810, @clayborg wrote:
> >
> > > I was unhappy when we went over two pointers for a FileSpec when m_syntax
alexandreyy added a comment.
@clayborg Thanks for the review.
@eugene , @labath Could you, please, commit this patch?
I don't have the permission for it.
https://reviews.llvm.org/D39487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
> On Nov 1, 2017, at 9:54 AM, Greg Clayton via Phabricator
> wrote:
>
> clayborg added a comment.
>
> In https://reviews.llvm.org/D39436#912828, @zturner wrote:
>
>> In https://reviews.llvm.org/D39436#912810, @clayborg wrote:
>>
>>> I was unhappy when we went over two pointers for a FileSpe
clayborg added a comment.
In https://reviews.llvm.org/D39436#912828, @zturner wrote:
> In https://reviews.llvm.org/D39436#912810, @clayborg wrote:
>
> > I was unhappy when we went over two pointers for a FileSpec when m_syntax
> > was added due to the extra size. Anything we can do to make this
zturner added a comment.
In https://reviews.llvm.org/D39436#912810, @clayborg wrote:
> I was unhappy when we went over two pointers for a FileSpec when m_syntax was
> added due to the extra size. Anything we can do to make this smaller would be
> great, so the type on the enum would work, but a
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
https://reviews.llvm.org/D39487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added a comment.
I was unhappy when we went over two pointers for a FileSpec when m_syntax was
added due to the extra size. Anything we can do to make this smaller would be
great, so the type on the enum would work, but as you say the alignment will
nullify that. The two ConstString me
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317099: Add data formatter for libc++ std::queue (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D35666?vs=107464&id=121137#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: labath
Date: Wed Nov 1 08:52:08 2017
New Revision: 317099
URL: http://llvm.org/viewvc/llvm-project?rev=317099&view=rev
Log:
Add data formatter for libc++ std::queue
Summary:
std::queue is just a fancy wrapper around another container, so all we
need to do is to delegate to the it.
Revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317095: Add data formatter for libc++ std::tuple (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35615
Files:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-form
Author: labath
Date: Wed Nov 1 08:19:52 2017
New Revision: 317095
URL: http://llvm.org/viewvc/llvm-project?rev=317095&view=rev
Log:
Add data formatter for libc++ std::tuple
Reviewers: jingham, EricWF
Subscribers: srhines, eugene, lldb-commits, mgorny
Differential Revision: https://reviews.llvm
labath updated this revision to Diff 121131.
labath added a comment.
s/nullptr/ValueObjectSP()
https://reviews.llvm.org/D35615
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile
packages/Python/lldbsuite/test/functionalities/data-
labath added a comment.
There wasn't a strong reason for using nullptr, I can convert those to
ValueObjectSP().
Given that this was your only objection to this patch, I'm going to assume it
is ok to land after this.
https://reviews.llvm.org/D35615
__
Author: labath
Date: Wed Nov 1 08:00:58 2017
New Revision: 317093
URL: http://llvm.org/viewvc/llvm-project?rev=317093&view=rev
Log:
Remove uint32_t assignment operator from Status
Summary:
It is not presently used, and it's quite dangerous to use -- it assumes the
integer is an osx kern_return_t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317093: Remove uint32_t assignment operator from Status
(authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35305
Files:
lldb/trunk/include/lldb/Utility/Status.h
lldb/trunk/source/
alexandreyy created this revision.
Herald added subscribers: JDevlieghere, kbarton, nemanjai.
Add read and write functions for VSX, VMX and float registers and fix
watchpoint size
https://reviews.llvm.org/D39487
Files:
packages/Python/lldbsuite/test/make/Makefile.rules
source/Core/ArchSpec
40 matches
Mail list logo
