zturner added inline comments.
================
Comment at: include/lldb/Utility/FileSpec.h:65-69
+ enum PathSyntax : unsigned char {
ePathSyntaxPosix,
ePathSyntaxWindows,
ePathSyntaxHostNative
};
----------------
This is actually a very nice change, as it reduces the size of `FileSpec` by a
couple of bytes. I think you can submit this change as a one-liner by itself,
independent of this patch.
================
Comment at: include/lldb/Utility/FileSpec.h:557
mutable bool m_is_resolved = false; ///< True if this path has been resolved.
- PathSyntax
- m_syntax; ///< The syntax that this path uses (e.g. Windows / Posix)
+ bool m_is_regex = false; ///< Filename is a regular expression.
};
----------------
I thought in previous comments we had decided that this wasn't really the right
direction, and that `FileSpec` should represent one file. //If// we want this
functionality in LLDB (and again, I'm not convinced), it should be done in such
a way that the `FileSpec` class remains unmodified. We should not have to
touch this class for any of this.
https://reviews.llvm.org/D39436
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
