[Lldb-commits] [lldb] r301295 - [LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py.

Author: nitesh.jain Date: Tue Apr 25 01:12:59 2017 New Revision: 301295 URL: http://llvm.org/viewvc/llvm-project?rev=301295&view=rev Log: [LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py. Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D32306: Remove lock from ConstString::GetLength

zturner added inline comments. Comment at: source/Utility/ConstString.cpp:49 + // pointer, we don't need the lock. const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr); return entry.getKey().size(); Why do we even have this fu

[Lldb-commits] [lldb] r301280 - Name the C++ source files for two tests correctly.

Author: spyffe Date: Mon Apr 24 18:58:36 2017 New Revision: 301280 URL: http://llvm.org/viewvc/llvm-project?rev=301280&view=rev Log: Name the C++ source files for two tests correctly. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/main.cpp - copied, changed from r3

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

krytarowski added a comment. In https://reviews.llvm.org/D32271#735354, @emaste wrote: > In https://reviews.llvm.org/D32271#735098, @krytarowski wrote: > > > I have plan to revisit corresponding files in NetBSD and switch from kvm(3) > > to sysctl(3). But this is lower priority than Process Plug

[Lldb-commits] [lldb] r301277 - Fixed two bad Makefiles that might be breaking Linux.

Author: spyffe Date: Mon Apr 24 18:49:06 2017 New Revision: 301277 URL: http://llvm.org/viewvc/llvm-project?rev=301277&view=rev Log: Fixed two bad Makefiles that might be breaking Linux. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/Makefile lldb/trunk/packages/P

[Lldb-commits] [PATCH] D32306: Remove lock from ConstString::GetLength

scott.smith added a comment. In https://reviews.llvm.org/D32306#733316, @labath wrote: > Looks good, thank you. > > Out of curiosity, have you observed any performance improvements resulting > from this? 10.2% reduction in # of instructions executed, 9.1% reduction in # of cycles, as measured

[Lldb-commits] [PATCH] D32100: [Expression parser] Return both types and variables

spyffe closed this revision. spyffe added a comment. Closed by r301273 https://reviews.llvm.org/D32100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301273 - [Expression parser] Return both types and variables

Author: spyffe Date: Mon Apr 24 18:14:04 2017 New Revision: 301273 URL: http://llvm.org/viewvc/llvm-project?rev=301273&view=rev Log: [Expression parser] Return both types and variables Many times a user wants to access a type when there's a variable of the same name, or a variable when there's a

[Lldb-commits] [lldb] r301263 - [DWARF] Fix lookup in the abstract origins of inlined blocks/functions

Author: spyffe Date: Mon Apr 24 17:11:10 2017 New Revision: 301263 URL: http://llvm.org/viewvc/llvm-project?rev=301263&view=rev Log: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions LLDB uses clang::DeclContexts for lookups, and variables get put into the DeclContext for the

[Lldb-commits] [PATCH] D32375: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL301263: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D32375?vs=96229&id=96477#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

I suppose that's a reasonable concern. I also didn't notice that this was a unittest, I assumed it was a lit test. If that's the case, is there any way to use llvm/Object to construct a minimal ELF file in memory with a hardcoded symbol in the BSS section. It can even be missing certain critical

[Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

labath added a comment. > We don't support running the test suite on Windows with MSVC. We run it > with clang targeting windows instead. So anyone running the test suite on > Windows is already using clang, and we can just specify a linux triple to > get an ELF binary. You'll need a linker

Re: [Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

We don't support running the test suite on Windows with MSVC. We run it with clang targeting windows instead. So anyone running the test suite on Windows is already using clang, and we can just specify a linux triple to get an ELF binary. On Mon, Apr 24, 2017 at 2:47 PM Eugene Zemtsov wrote: >

Re: [Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

Microsoft Visual C++ first comes to my mind. On Mon, Apr 24, 2017 at 2:31 PM, Zachary Turner wrote: > Which C compilers do we have that are not capable of producing ELF > binaries? GCC on Windows maybe? That's not even a supported test > configuration. > > On Mon, Apr 24, 2017 at 2:29 PM Pave

Re: [Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

Which C compilers do we have that are not capable of producing ELF binaries? GCC on Windows maybe? That's not even a supported test configuration. On Mon, Apr 24, 2017 at 2:29 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In https://reviews.ll

[Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

labath added a comment. In https://reviews.llvm.org/D32434#735877, @eugene wrote: > Is it really necessary to check in binary ELF files? > I understand that we don't always have a C compiler capable of producing ELF > files, but maybe it's ok to skip this test on those platforms. That is so

[Lldb-commits] [PATCH] D32375: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions

spyffe added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3723-3742 +static DWARFDIE FindAnyChildWithAbstractOrigin(const DWARFDIE &context) { + for (DWARFDIE candidate = context.GetFirstChild(); candidate.IsValid(); + candidate = ca

[Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

eugene added a comment. Is it really necessary to check in binary ELF files? I understand that we don't always have a C compiler capable of producing ELF files, but maybe it's ok to skip this test on those platforms. https://reviews.llvm.org/D32434 _

[Lldb-commits] [PATCH] D32316: Change UniqueCStringMap to use ConstString as the key

scott.smith added a comment. At a high level, I think there might be a misunderstanding on what I'm attempting to do. It isn't to convert things that weren't ConstString into things that are. It is instead to utilize the fact that we have all these ConstString in order to improve the performa

[Lldb-commits] [PATCH] D32375: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions

jingham added a comment. Except for the comment about FindFirstChildWithAbstractOrigin, this seems fine. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3723-3742 +static DWARFDIE FindAnyChildWithAbstractOrigin(const DWARFDIE &context) { + for (DWARFDIE can

[Lldb-commits] [PATCH] D32441: Remove the home-grown android toolchain file and all references to it

tberghammer added inline comments. Comment at: www/build.html:474-475 - from inside the unzipped NDK. Toolchains for other architectures can be produced in - a similar manner. + The NDK also contains a cmake toolchain file, wh

[Lldb-commits] [PATCH] D32441: Remove the home-grown android toolchain file and all references to it

labath created this revision. Herald added subscribers: mgorny, srhines. The toolchain file has been deprecated in favor of the "official" toolchain file present in the Android NDK. Also update the web build instructions to reflect this. https://reviews.llvm.org/D32441 Files: cmake/platforms/

[Lldb-commits] [lldb] r301186 - Update two android XFAILS

Author: labath Date: Mon Apr 24 10:23:21 2017 New Revision: 301186 URL: http://llvm.org/viewvc/llvm-project?rev=301186&view=rev Log: Update two android XFAILS - XFAIL on TestNoreturnUnwind on all architectures - TestStaticVariables fails with clang-3.8 as well Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

labath created this revision. Herald added a subscriber: mgorny. If we have symbol information in a separate file, we need to be very careful about presenting a unified section view of module to the rest of the debugger. ObjectFileELF had code to handle that, but it was being overly cautious -- th

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste added a comment. In https://reviews.llvm.org/D32271#735098, @krytarowski wrote: > I have plan to revisit corresponding files in NetBSD and switch from kvm(3) > to sysctl(3). But this is lower priority than Process Plugin right now. Thanks for the note. I wasn't aware that you had that p

[Lldb-commits] [lldb] r301179 - Fix the new SocketAddressTest on Windows

Author: labath Date: Mon Apr 24 08:34:35 2017 New Revision: 301179 URL: http://llvm.org/viewvc/llvm-project?rev=301179&view=rev Log: Fix the new SocketAddressTest on Windows we need to call WSAStartup before we can use getaddrinfo. Modified: lldb/trunk/unittests/Host/SocketAddressTest.cpp M

[Lldb-commits] [lldb] r301172 - [LLDB][MIPS] Move it into HandleLLVMOptions.cmake.

Author: nitesh.jain Date: Mon Apr 24 05:56:01 2017 New Revision: 301172 URL: http://llvm.org/viewvc/llvm-project?rev=301172&view=rev Log: [LLDB][MIPS] Move it into HandleLLVMOptions.cmake. The revison https://reviews.llvm.org/D32125 will fixed the off_t for GNU specific 32 bit platform. This fix

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL301171: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D32125?vs=95573&id=96374#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

nitesh.jain added a comment. In https://reviews.llvm.org/D32125#734500, @emaste wrote: > In https://reviews.llvm.org/D32125#728166, @krytarowski wrote: > > > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms > > 20+ years ago. > > > > It's perhaps no-op, but it might be no

[Lldb-commits] [PATCH] D32366: Set "success" status correctly

labath added a comment. Thanks for the patch. Could you please also add an appropriate test for it? Doing something similar to what `packages/Python/lldbsuite/test/functionalities/frame_var/TestFrameVar.py` does should be the easiest way to test this. Repository: rL LLVM https://reviews.ll

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. In https://reviews.llvm.org/D32340#733387, @ki.stfu wrote: > Thanks for catching this! Could you update this CL to let me commit it? Yes , Please commit it. https://reviews.llvm.org/D32340 __

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

nitesh.jain updated this revision to Diff 96368. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D32340 Files: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py Index: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py ==

[Lldb-commits] [PATCH] D32357: Add more arguments to SocketAddress::GetAddressInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL301168: Add more arguments to SocketAddress::GetAddressInfo (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32357?vs=96160&id=96363#toc Repository: rL LLVM https://reviews.l

[Lldb-commits] [lldb] r301168 - Add more arguments to SocketAddress::GetAddressInfo

Author: labath Date: Mon Apr 24 04:39:56 2017 New Revision: 301168 URL: http://llvm.org/viewvc/llvm-project?rev=301168&view=rev Log: Add more arguments to SocketAddress::GetAddressInfo Summary: the reason for this is two-fold: - getaddrinfo without the extra arguments will return the same (networ

[Lldb-commits] [PATCH] D32421: Fix segfault resulting from empty print prompt

xiaobai created this revision. I have found a way to segfault lldb in 7 keystrokes! Steps to reproduce: 1. Launch lldb 2. Type `print` and hit enter. lldb will now prompt you to type a list of expressions, followed by an empty line. 3. Hit enter, indicating the end of your input. 4. Segfault! A

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

krytarowski added a comment. I have plan to revisit corresponding files in NetBSD and switch from kvm(3) to sysctl(3). But this is lower priority than Process Plugin right now. https://reviews.llvm.org/D32271 ___ lldb-commits mailing list lldb-comm