labath added a comment. In https://reviews.llvm.org/D32434#735877, @eugene wrote:
> Is it really necessary to check in binary ELF files? > I understand that we don't always have a C compiler capable of producing ELF > files, but maybe it's ok to skip this test on those platforms. That is something very I am very much trying to avoid, as that means people on those platforms cannot validate their changes. (And I'm not sure if I even want to be running a compiler for a test at this level, as that introduces a level of nondeterminism.) That said, I do agree we should be carefully about adding lots of binary bloat. I have been trying to put this off until we have more of these, but maybe I could try integrating this with obj2yaml -- it does not seem to preserve program headers, but I don't actually need those for this test. https://reviews.llvm.org/D32434 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
