Author: jmolenda
Date: Tue Aug 16 22:56:04 2016
New Revision: 278901
URL: http://llvm.org/viewvc/llvm-project?rev=278901&view=rev
Log:
Fix the RangeMapVector::FindEntryThatContainsOrFollows method to
back up the iterator, as long as it still contains the address.
std::lower_bound will point us to
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:29
@@ +28,3 @@
+
+lldb::ByteOrder byteorder = m_data.GetByteOrder();
+lldb::offset_t directory_list_offset = m_header->stream_directory_rva;
I asked some people f
Btw the endian aware types are usable, just include
"llvm/Support/Endian.h". It's just the consumeObject functions that are not
On Tue, Aug 16, 2016 at 10:01 AM Zachary Turner wrote:
> zturner added a comment.
>
> LLVM does have something similar to DataExtractor, but unfortunately it's
> not pre
zturner added a comment.
LLVM does have something similar to DataExtractor, but unfortunately it's not
present in the correct library for you to easily be able to reuse it. I
actually own the code in question, so I'm willing to fix that for you if you're
interested, but at the same time the co
amccarth added a comment.
Are we putting this code in the right place? I wouldn't expect minidump
parsing to fall under Plugins/Process.
I assume the eventual intent is to turn the Windows-specific code into a user
of your new code? I look forward to seeing that happen.
Com
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. I know there are many other functions that we should port down into
the client code.
https://reviews.llvm.org/D23553
___
lldb-co
I see. Let me follow up with the breakpad developers to ask them about
that. If you only have to support one endianness the code can be much
cleaner.
On Tue, Aug 16, 2016 at 9:44 AM Dimitar Vlahovski
wrote:
> dvlahovski added inline comments.
>
>
> Comment at: source/Plugins/P
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35
@@ +30,7 @@
+// the signature might be byte swapped
+data.SetByteOrder(lldb::eByteOrderBig);
+*offset -= 4;
+signature = data.GetU32(offset);
+if (signature ==
zturner added a subscriber: zturner.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35
@@ +30,7 @@
+// the signature might be byte swapped
+data.SetByteOrder(lldb::eByteOrderBig);
+*offset -= 4;
+signature = data.GetU32(offset);
+if (signature
Greg: ping?
On Mon, Aug 8, 2016 at 1:38 PM, Hans Wennborg wrote:
> Greg: ping?
>
> On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote:
>> For LLDB, I think it's up to Greg to decide.
>>
>> On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote:
>>> Hi Hans!
>>>
>>> The author of this commit asks me is
Thanks for the comment. Do you have anything particular in mind from the
llvm types? Is there something similar to DataExtractor?
On Tue, Aug 16, 2016 at 4:21 PM, Zachary Turner wrote:
> I would prefer to use llvm types to do the parsing wherever possible. Why
> do we need DataExtractor? If the
I would prefer to use llvm types to do the parsing wherever possible. Why
do we need DataExtractor? If the only reason is to force little endian,
just use the types in llvm/Endian.h
On Tue, Aug 16, 2016 at 8:13 AM Dimitar Vlahovski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> dvlahovsk
dvlahovski updated this revision to Diff 68180.
dvlahovski added a comment.
Fixing a little bug - should get the byteorder
after calling SignatureMatchAndSetByteOrder
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/
dvlahovski updated this revision to Diff 68177.
dvlahovski added a comment.
Resolving Pavel's remarks
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/
labath added a comment.
Sounds that we're agreed then. Can you please update the patch to use `?=` as
appropriate? I will update the buildbots to set these variables explicitly as
needed, and then we can get this in.
https://reviews.llvm.org/D20386
__
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
Cmake 2.8 support is gone and not coming back. We can remove a bit of legacy
code now.
https://reviews.llvm.org/D23554
Files:
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBConfig.cmake
labath added a comment.
In https://reviews.llvm.org/D22914#511294, @clayborg wrote:
> OK. I can't complain if it doesn't affect performance and could allow
> multiple packets to be in flight with threading, though I think solving this
> issue with threading is a bit of a hack, but it should wor
labath updated this revision to Diff 68171.
labath added a comment.
Fix indentation
https://reviews.llvm.org/D23553
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
source/Plugins/Process/gdb-remote/
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:601
@@ -600,3 @@
-
-if (gdb_comm.SendPacketAndWaitForResponse(packet, packet_len,
response, false) == GDBRemoteCommunication::PacketResult::Success)
-
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
When saving/restoring registers the GDBRemoteRegisterContext class was manually
constructing
the register save/restore packets. This creates appropriate helper functions in
GDBRemoteCommunica
labath added a comment.
The implementation looks nice and clean. I have only some stylistic comments
giving it finishing touches..
Comment at: source/Plugins/Process/minidump/CMakeLists.txt:6
@@ +5,3 @@
+ MinidumpParser.cpp
+ #ProcessMinidump.cpp
+ #ThreadMinidump.cpp
--
dvlahovski created this revision.
dvlahovski added reviewers: labath, amccarth.
dvlahovski added a subscriber: lldb-commits.
Herald added subscribers: dschuff, srhines, danalbert, tberghammer.
This is a work-in-progress minidump parsing code.
There are still some more structures/data streams that
Author: labath
Date: Tue Aug 16 04:36:29 2016
New Revision: 278785
URL: http://llvm.org/viewvc/llvm-project?rev=278785&view=rev
Log:
Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class
Despite its comment, the function is only used in the Client class, and its
presence was
23 matches
Mail list logo
