zturner added a subscriber: zturner. ================ Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35 @@ +30,7 @@ + // the signature might be byte swapped + data.SetByteOrder(lldb::eByteOrderBig); + *offset -= 4; + signature = data.GetU32(offset); + if (signature == MINIDUMP_SIGNATURE) + return true; + ---------------- Why would this be true? Is there a minidump specification somewhere that says that both big endian and little endian are valid byte orderings? I would expect that being a Microsoft created format, it should always be little endian, and if there is a file in big endian we can consider it corrupt.
https://reviews.llvm.org/D23545 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
