[Lldb-commits] [lldb] r278785 - Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class

[Pavel Labath via lldb-commits]

Author: labath
Date: Tue Aug 16 04:36:29 2016
New Revision: 278785

URL: http://llvm.org/viewvc/llvm-project?rev=278785&view=rev
Log:
Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class

Despite its comment, the function is only used in the Client class, and its 
presence was merely
complicating mock implementation in unit tests.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
    lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h?rev=278785&r1=278784&r2=278785&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h 
(original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h Tue 
Aug 16 04:36:29 2016
@@ -126,12 +126,6 @@ public:
     }
 
     //------------------------------------------------------------------
-    // Client and server must implement these pure virtual functions
-    //------------------------------------------------------------------
-    virtual bool
-    GetThreadSuffixSupported () = 0;
-
-    //------------------------------------------------------------------
     // Set the global packet timeout.
     //
     // For clients, this is the timeout that gets used when sending

Modified: 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h?rev=278785&r1=278784&r2=278785&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h 
(original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h 
Tue Aug 16 04:36:29 2016
@@ -65,7 +65,7 @@ public:
                                         std::string &response_string);
 
     bool
-    GetThreadSuffixSupported () override;
+    GetThreadSuffixSupported();
 
     // This packet is usually sent first and the boolean return value
     // indicates if the packet was send and any response was received

Modified: 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h?rev=278785&r1=278784&r2=278785&view=diff
==============================================================================
--- 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
 (original)
+++ 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
 Tue Aug 16 04:36:29 2016
@@ -176,12 +176,6 @@ protected:
                               });
     }
 
-    bool
-    GetThreadSuffixSupported () override
-    {
-        return true;
-    }
-
     //------------------------------------------------------------------
     /// Launch a process with the current launch settings.
     ///

Modified: lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp?rev=278785&r1=278784&r2=278785&view=diff
==============================================================================
--- lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp 
(original)
+++ lldb/trunk/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp Tue Aug 
16 04:36:29 2016
@@ -60,12 +60,6 @@ struct MockServer : public GDBRemoteComm
 {
     MockServer() : GDBRemoteCommunicationServer("mock-server", 
"mock-server.listener") { m_send_acks = false; }
 
-    bool
-    GetThreadSuffixSupported() override
-    {
-        return false;
-    }
-
     PacketResult
     SendPacket(llvm::StringRef payload)
     {
@@ -84,12 +78,6 @@ struct MockServer : public GDBRemoteComm
 struct TestClient : public GDBRemoteClientBase
 {
     TestClient() : GDBRemoteClientBase("test.client", "test.client.listener") 
{ m_send_acks = false; }
-
-    bool
-    GetThreadSuffixSupported() override
-    {
-        return false;
-    }
 };
 
 struct ContinueFixture


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits